Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp2690943rdb; Mon, 4 Dec 2023 05:07:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IHd0sbXZScQarVm+AWMXEx5ggQHFr75XR9PIOc7A0/vU1joPUCBakbbtdp+4bHG87H5mtG5 X-Received: by 2002:a05:6a00:1acb:b0:6c6:9c3b:f0ed with SMTP id f11-20020a056a001acb00b006c69c3bf0edmr1807755pfv.7.1701695245369; Mon, 04 Dec 2023 05:07:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701695245; cv=none; d=google.com; s=arc-20160816; b=mdAmSZQPsy1gkUONSPwUxnJDtB/ojfNkj4uJbcVE8jPbda4FyFiiJtmmD4evPNcvF5 F99HljY5OGAyMJhD3766Scwb4lvn3AZVZJAGgei++2JjfpBHd1Dpxk+RwAvKHHQvzAOp A1nBdpvjo6Kw84o6flsraFTTo2h5DyL9tETafWd/pJKS0IjNwlCU8/vyI3lWZX/2DKB1 wVTl74X2ImLNXIQVMjrnv09C9PQ0Sjcao6gUT5pw+cI7jeXmgqCfwl7CLtcJYmNOkw0t z0fVO9NOod5x3Jpx8OjpZHj3Mx0LUw8XMZly7pYkB5TXksGSZA53EISdF557BG3w41RA aDdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=XfUaVtHFqpZV08SARmtUF4G6OyZJ0yqx8WxjP0veksw=; fh=pizzMoZOyDLOqQxuccYBMhlXo1+k8AFKOVTNR0V+83g=; b=zeavhYn/3mnYn2/7ZCVpuEa/ftguIO+XKwpmuFg9GR91RiXJQQh56ej0BKYqFmDRen ntpQpBzmS4q6gEV6XCy+gtbCtbZeaVdHV03FGOhuQiq9/oEUtgkg21ifizsZc1ZB3YfD ciTW9vERI4iyZ7s/GgYupw9ns430ZqbPUALFqW03b29CZCvoqD34sAISUi+Id4WSjwD8 O+mfb4DChf4zl9ULxjYlEhZQODWuxT1uF1qi/JJUm8d0bCpJ27vNUoEQRrcWAPBdpv+A cq0P7L+KYDAQRde8larJbXopk2JV6uabb++X9OLxKDHBakhVhtZsvzj3eoareU08gHOq C08g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=jVPAaYDy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id f2-20020a056a00228200b006910a45a234si7905683pfe.202.2023.12.04.05.07.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 05:07:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=jVPAaYDy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 3969A8062346; Mon, 4 Dec 2023 05:07:18 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234976AbjLDNHF (ORCPT + 99 others); Mon, 4 Dec 2023 08:07:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232947AbjLDNHE (ORCPT ); Mon, 4 Dec 2023 08:07:04 -0500 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 463C2A7; Mon, 4 Dec 2023 05:07:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701695230; x=1733231230; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=UXznonBwZSh6vXkSOTRxTtrLALPBPOcd61xsNDWj4+I=; b=jVPAaYDyH7Qfu6aYzAqic98Wlrl/0ukje+B8DWj5adDdPsVOjFd6rOmQ N6Fa4B0+ed1pJbgXRY2UPuomb2L9xpb7l+SXLkp3SSBUdiywbj+TAbZrU v8Seex1XCVqaxR6m/dOj7hd4hYLHR+v/vCg29WBMEmyUFECb/FGZkgMZC NvRSQGrLNZA8Cah0to6uDHZ/lEpQ1zvY3+V4c7YXgvZH3R4n1TMiPIUoD nfIEl+ieJZyXAr/847vedbdRgczqhqS5TuukfldvmQYaxsr0+OcVuJRv8 8Cbvyx0v487JQIsZ8hVaBAU59nTpQ2mRO1ig+CCOXLnrpYqC4xpawvmrP w==; X-IronPort-AV: E=McAfee;i="6600,9927,10913"; a="15274919" X-IronPort-AV: E=Sophos;i="6.04,249,1695711600"; d="scan'208";a="15274919" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Dec 2023 05:05:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10913"; a="763935407" X-IronPort-AV: E=Sophos;i="6.04,249,1695711600"; d="scan'208";a="763935407" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga007.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Dec 2023 05:05:41 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rA8dl-00000001kpu-0ppK; Mon, 04 Dec 2023 15:05:37 +0200 Date: Mon, 4 Dec 2023 15:05:36 +0200 From: Andy Shevchenko To: Hans Verkuil Cc: Yury Norov , linux-kernel@vger.kernel.org, Mauro Carvalho Chehab , linux-media@vger.kernel.org, Jan Kara , Mirsad Todorovac , Matthew Wilcox , Rasmus Villemoes , Maxim Kuvyrkov , Alexey Klimov , Bart Van Assche , Sergey Shtylyov Subject: Re: [PATCH v2 27/35] media: em28xx: cx231xx: fix opencoded find_and_set_bit() Message-ID: References: <20231203192422.539300-1-yury.norov@gmail.com> <20231203193307.542794-1-yury.norov@gmail.com> <20231203193307.542794-26-yury.norov@gmail.com> <40783b7c-4353-4366-ad49-95ac87c5f8be@xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <40783b7c-4353-4366-ad49-95ac87c5f8be@xs4all.nl> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 04 Dec 2023 05:07:18 -0800 (PST) On Mon, Dec 04, 2023 at 09:39:59AM +0100, Hans Verkuil wrote: > On 03/12/2023 20:32, Yury Norov wrote: > > Functions in the media/usb drivers opencode find_and_set_bit() by > > polling on a found bit in a while-loop. ... > It's a nice improvement. Wouldn't it be even nicer to utilise IDA framework? -- With Best Regards, Andy Shevchenko