Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Date:   Mon, 4 Dec 2023 15:07:06 +0200 (EET)
From:   =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>
To:     Vadim Pasternak <vadimp@nvidia.com>
cc:     Kunwu Chan <chentao@kylinos.cn>,
        "hdegoede@redhat.com" <hdegoede@redhat.com>,
        "jdelvare@suse.com" <jdelvare@suse.com>,
        "linux@roeck-us.net" <linux@roeck-us.net>,
        Shravan Ramani <shravankr@nvidia.com>,
        "jiri@resnulli.us" <jiri@resnulli.us>,
        "kunwu.chan@hotmail.com" <kunwu.chan@hotmail.com>,
        "platform-driver-x86@vger.kernel.org" 
        <platform-driver-x86@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>
Subject: RE: [PATCH v2] platform/mellanox: Add some null/error pointer checks
 to mlxbf-pmc.c
In-Reply-To: <BN9PR12MB5381B3408452445483B7281EAF81A@BN9PR12MB5381.namprd12.prod.outlook.com>
Message-ID: <b2fa490-4e48-44a6-64d3-45ef4f5c14b@linux.intel.com>
References: <20231201055447.2356001-1-chentao@kylinos.cn> <BN9PR12MB5381B3408452445483B7281EAF81A@BN9PR12MB5381.namprd12.prod.outlook.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-1694539297-1701695235=:3149"
Precedence: bulk

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1694539297-1701695235=:3149
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8BIT

> > Subject: [PATCH v2] platform/mellanox: Add some null/error pointer checks to
> > mlxbf-pmc.c
> > 
> > devm_kasprintf() returns a pointer to dynamically allocated memory which
> > can be NULL upon failure.
> > devm_hwmon_device_register_with_groups return a error pointer upon
> > failure.
> > 
> > Compile-tested only.
> > 
> > Fixes: 1a218d312e65 ("platform/mellanox: mlxbf-pmc: Add Mellanox
> > BlueField PMC driver")
> > Suggested-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> > Suggested-by: Vadim Pasternak <vadimp@nvidia.com>
> > Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
> 
> Reviewed-by: Vadim Pasternak <vadimp@nvidia.com>

> >  		attr->dev_attr.attr.name = devm_kasprintf(dev, GFP_KERNEL,
> >  							  "enable");
> > +		if (!attr->dev_attr.attr.name)
> > +			return -ENOMEM;

> >  	pmc->hwmon_dev = devm_hwmon_device_register_with_groups(
> >  		dev, "bfperf", pmc, pmc->groups);
> > +	if (IS_ERR(pmc->hwmon_dev))
> > +		return PTR_ERR(pmc->hwmon_dev);

Thank you both, applied to review-ilpo and will go into fixes branch once 
LKP has had its chance to build this.

In the end, I decided to split the devm_kasprintf() and 
devm_hwmon_device_register_with_groups() changes into separate commits.

-- 
 i.

--8323329-1694539297-1701695235=:3149--