Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <750c2c64-4fd6-437b-bb14-100f6941d2c4@weidmueller.com>
Date:   Mon, 4 Dec 2023 14:22:56 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] extcon: usbc-tusb320: Set interrupt polarity based on
 device-tree
To:     Chanwoo Choi <cw00.choi@samsung.com>, lkp@intel.com,
        'MyungJoo Ham' <myungjoo.ham@samsung.com>
Cc:     Lukas.Funke@weidmueller.com, linux-kernel@vger.kernel.org,
        oe-kbuild-all@lists.linux.dev
References: <202311221355.yxYpTIw3-lkp@intel.com>
 <CGME20231122080822epcas1p23e2e80d3db305229f9d611d79b667a2f@epcas1p2.samsung.com>
 <20231122080749.947682-1-lukas.funke-oss@weidmueller.com>
 <002e01da26b0$52582960$f7087c20$@samsung.com>
From:   Lukas Funke <lukas.funke-oss@weidmueller.com>
In-Reply-To: <002e01da26b0$52582960$f7087c20$@samsung.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d1d4bm1CcWp6THNFVUZnam5qa2V4elJDenZHU09aeFRHVlV1RXZYNTZOVFpU?=
 =?utf-8?B?QWVKdS95S2dvam00OGxZTUNKTVAySUlHZ2tHRkJWWExyeVQzYUdqZVozV2ND?=
 =?utf-8?B?MW5qWHdZaVRscVc0b25mZzc0eUtXejFUYlJudHpDZW54YzJPOWhJRnl2Zjdn?=
 =?utf-8?B?MEhLdWEzUXVlNGYwMVR0NUFlR25YQThNZjNENlM4VjRRL0ZpYnNPWE1IcVpv?=
 =?utf-8?B?R3VBdXB3by9aZGRjUVZNQXlxMFk1eHRBNlA4Y1l2b0ZMaUVROE5iWUtMMFM5?=
 =?utf-8?B?dnhyV0FnMVlsbS9Ibmdpb05rcGlMQS9qT2JpMXNtWXRvbTZtSTlMSHdIaXlz?=
 =?utf-8?B?bnFLamtoOEhtYlEvQ1YvTW56RFl6cDV2NWQvcG8zc010aTEyS00relFYTUw2?=
 =?utf-8?B?b1BVRXRXSStmbWhCTXBZUm0vZmNabi9MT3JZSmw4aUlTaEpuYlJ3Q0JXZmIx?=
 =?utf-8?B?bVcwU2xrbTRrVzJXa2FzdEFhZUZnT0lxb1FUMS9uclJ3NFhoMGFrNTZGaHBH?=
 =?utf-8?B?eFRTSVlFN0pWdmM2N1NXVk9CbHpvYkdPaFpUbGN4emhwd3gzYmhBMDZaeWUr?=
 =?utf-8?B?cWQ5UXdFL3FLSWZIcTdvcngvN29DYjNETUJTRlI3Vnk0L1liQ2l6VnFBQVRl?=
 =?utf-8?B?c0RwRGYyMnZpdCtyaUJwUUdqRlNaaXR2bFhDbzB1TzZXT21XbFFCUUNra2dL?=
 =?utf-8?B?UG1VU05XNUQ5VkRld2ljNVVBcU5zei8xTEkxN0tveHBDcXppUnVHMFRpVmlP?=
 =?utf-8?B?RzJZaExEcThKV1hQVXRqeVRlMjAvMERqZnNTM0VPRkRyWGRRSjhyck1TQUox?=
 =?utf-8?B?VzVCYmFheDdpWkp5QWFtclhSQTlFaW15ZGtsSURNWVRHclF5KzBINnlUUzhX?=
 =?utf-8?B?b3JreXNYb2l4UFJ2Q3prbFl6bDhDWFlCZW9Hd2RkTzBQZkZOV1R6L1JhSGRR?=
 =?utf-8?B?UW1oWDlGZk16SGVOWjVONXo1UjFZZDM4S2txUk8zd1o5NDJqVFMzdy8rS3Er?=
 =?utf-8?B?d0NiMy84NldFLzVCODIyZlhiL2YwZUR4M0pUVDhvOUhRUktkM2c2TzFiMW1I?=
 =?utf-8?B?QmhHWmxWbEdNTXorU09ZUElvenF5SHZLN0hpT0xvQmh4UDhwYTQ5RS9qKy91?=
 =?utf-8?B?TVZ3ZDdXa0NBeEd2dFcwRHJnOFJFSnBtdDBaUU9sM0ZFbDhKb05uazlTQU1s?=
 =?utf-8?B?Zm1wMmtWdVlIcEZIZHZPV1hIazlod2lRamdqM21jaFg5eElYdlptUlgzV1dJ?=
 =?utf-8?B?VHdza2FDdnAzbzZ0VFZ5c2xHRDZrcTNZaW5YaVpkRTgvakNib0VuQzNDdTJQ?=
 =?utf-8?B?OE8wVTlZM1RUSFNwMHNJZEZCUW5qTGlIMHhjRlpWZmx5NzBuSlMzQUYvVlpp?=
 =?utf-8?B?K0JJMHhmV25VZlUwalZ4T081UWIzUnJWMVRvR01mN092RXlEM1d3Vzk2VUdD?=
 =?utf-8?B?ZGdUV0FteE1sYmRPdklsRWRac2ZyTUFiRVZaK0FWMzdIaGJYd3BIb3dWa2R4?=
 =?utf-8?B?cXI2TEhSNnNoL29sQ3dyOFBKTHg0YTZmb0hsWlVBZjJIZzVuNk5aT0Z2SkxR?=
 =?utf-8?B?UTV4L0JEczlOMXZjeWpaMXBZNTNiU056TDUxYkU1TXVtM2t1L1dlTlQ2SStx?=
 =?utf-8?B?YXRQZ2pRTWRKTmF5R1hqZmcyL1BjaDdCUHlVT0VTNEwrS0VHK0VFNTAvQWo2?=
 =?utf-8?B?VDJJWDNIVm04ZCt5REY5WXN5NTdMaWZ6TmlRQmViV3R6UjZma0ZmZGhUbDNw?=
 =?utf-8?B?NXpuN3N1ekZXVmRpeVh4dE9HQWlWUitFYXZaSm5xeVRnMUQ5T1Z1US84TTRJ?=
 =?utf-8?B?Y3BZYmg2UXRVMUtxY21ReTFFM2xhL1lNNWRhaUpDcEJKR1RkSHNTM2RsUFFi?=
 =?utf-8?B?MmRFKzQ5dDBIbE9PeEs5bC82bW5Ya3JWYXVERENJRitTN2pmSDdLaElERjZ6?=
 =?utf-8?B?TkQ4OE1LYTFaK1VVU1lPaUwwYjdlb3E2Qi9VU0drTW01ajNBT3lrWnJRK3Rr?=
 =?utf-8?B?d21iblJOWFNtZXFDcEwrZUttaElGbldXYnorNmk2OTZnOTgzczFZQ0szWUUv?=
 =?utf-8?B?bWQyL1RoTUpqYk0wZEprVVNuUnJ5V1g4NUM3Y2VUUk5ic2FheFB1S2MzbG1a?=
 =?utf-8?B?dEhKNTFTWlp5SlNpU2VOVG9hTm1nbkhQcURsR0t0Z3NZY2h5QVRVaDJjNldQ?=
 =?utf-8?B?dFE9PQ==?=
X-OriginatorOrg: weidmueller.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c92ce9dd-bfe4-4cb2-3138-08dbf4cc21cf
X-MS-Exchange-CrossTenant-AuthSource: AS2PR08MB8431.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Dec 2023 13:22:58.1791
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e4289438-1c5f-4c95-a51a-ee553b8b18ec
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pYaLFASqHUQG1bA1oCbPlnGtamRCO5cETNj/6LXSmQmjdR6snzMAfsBa37qTC7vl4krlqW9s9Xfzwq4kVVbT/g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8205
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 04 Dec 2023 05:23:09 -0800 (PST)

Hi Chanwoo,

On 04.12.2023 13:49, Chanwoo Choi wrote:
> 
> 
>> -----Original Message-----
>> From: Chanwoo Choi <cw00.choi@samsung.com>
>> Sent: Monday, December 4, 2023 9:33 PM
>> To: 'Lukas Funke' <lukas.funke-oss@weidmueller.com>; 'lkp@intel.com'
>> <lkp@intel.com>; 'MyungJoo Ham' <myungjoo.ham@samsung.com>
>> Cc: 'Lukas.Funke@weidmueller.com' <Lukas.Funke@weidmueller.com>; 'linux-
>> kernel@vger.kernel.org' <linux-kernel@vger.kernel.org>; 'oe-kbuild-
>> all@lists.linux.dev' <oe-kbuild-all@lists.linux.dev>; 'Lukas Funke'
>> <lukas.funke@weidmueller.com>
>> Subject: RE: [PATCH v2] extcon: usbc-tusb320: Set interrupt polarity based
>> on device-tree
>>
>>
>>
>>> -----Original Message-----
>>> From: Chanwoo Choi <cw00.choi@samsung.com>
>>> Sent: Monday, December 4, 2023 9:09 PM
>>> To: 'Lukas Funke' <lukas.funke-oss@weidmueller.com>; 'lkp@intel.com'
>>> <lkp@intel.com>; 'MyungJoo Ham' <myungjoo.ham@samsung.com>
>>> Cc: 'Lukas.Funke@weidmueller.com' <Lukas.Funke@weidmueller.com>;
>>> 'linux- kernel@vger.kernel.org' <linux-kernel@vger.kernel.org>;
>>> 'oe-kbuild- all@lists.linux.dev' <oe-kbuild-all@lists.linux.dev>; 'Lukas
>> Funke'
>>> <lukas.funke@weidmueller.com>
>>> Subject: RE: [PATCH v2] extcon: usbc-tusb320: Set interrupt polarity
>>> based on device-tree
>>>
>>>
>>>
>>>> -----Original Message-----
>>>> From: Lukas Funke <lukas.funke-oss@weidmueller.com>
>>>> Sent: Wednesday, November 22, 2023 5:08 PM
>>>> To: lkp@intel.com; MyungJoo Ham <myungjoo.ham@samsung.com>; Chanwoo
>>>> Choi <cw00.choi@samsung.com>
>>>> Cc: Lukas.Funke@weidmueller.com; linux-kernel@vger.kernel.org;
>>>> lukas.funke- oss@weidmueller.com; oe-kbuild-all@lists.linux.dev;
>>>> Lukas Funke <lukas.funke@weidmueller.com>
>>>> Subject: [PATCH v2] extcon: usbc-tusb320: Set interrupt polarity
>>>> based on device-tree
>>>>
>>>> From: Lukas Funke <Lukas.Funke@weidmueller.com>
>>>>
>>>> Remove 'IRQF_TRIGGER_FALLING' request which is not allowed on every
>>>> interrupt controller (i.e. arm64 GIC). Replace flag by a request
>>>> that depends on the actual device-tree setting.
>>>>
>>>> Reported-by: kernel test robot <lkp@intel.com>
>>>> Closes: https://lore.kernel.org/oe-kbuild-all/202311221355.yxYpTIw3-
>>>> lkp@intel.com/
>>>> Signed-off-by: Lukas Funke <lukas.funke@weidmueller.com>
>>>> ---
>>>>   drivers/extcon/extcon-usbc-tusb320.c | 13 ++++++++++++-
>>>>   1 file changed, 12 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/extcon/extcon-usbc-tusb320.c
>>>> b/drivers/extcon/extcon- usbc-tusb320.c index
>>>> 4d08c2123e59..140ab28dbd36 100644
>>>> --- a/drivers/extcon/extcon-usbc-tusb320.c
>>>> +++ b/drivers/extcon/extcon-usbc-tusb320.c
>>>> @@ -17,6 +17,7 @@
>>>>   #include <linux/usb/typec.h>
>>>>   #include <linux/usb/typec_altmode.h>  #include <linux/usb/role.h>
>>>> +#include <linux/irq.h>
>>>>
>>>>   #define TUSB320_REG8				0x8
>>>>   #define TUSB320_REG8_CURRENT_MODE_ADVERTISE	GENMASK(7, 6)
>>>> @@ -515,6 +516,8 @@ static int tusb320_probe(struct i2c_client
> *client)
>>>>   	const void *match_data;
>>>>   	unsigned int revision;
>>>>   	int ret;
>>>> +	int irq_pol;
>>>> +	struct irq_data *irq_d;
>>>>
>>>>   	priv = devm_kzalloc(&client->dev, sizeof(*priv), GFP_KERNEL);
>>>>   	if (!priv)
>>>> @@ -568,9 +571,17 @@ static int tusb320_probe(struct i2c_client
> *client)
>>>>   		 */
>>>>   		tusb320_state_update_handler(priv, true);
>>>>
>>>> +	irq_d = irq_get_irq_data(client->irq);
>>>> +	if (!irq_d) {
>>>> +		dev_err(&client->dev, "Invalid IRQ: %d\n", client->irq);
>>>> +		return -ENODEV;
>>>> +	}
>>>> +
>>>> +	irq_pol = irqd_get_trigger_type(irq_d);
>>>> +
>>>>   	ret = devm_request_threaded_irq(priv->dev, client->irq, NULL,
>>>>   					tusb320_irq_handler,
>>>> -					IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
>>>> +					IRQF_ONESHOT | irq_pol,
>>>>   					client->name, priv);
>>>>   	if (ret)
>>>>   		tusb320_typec_remove(priv);
>>>> --
>>>> 2.30.2
>>>
>>>
>>> Applied it. Thanks.
>>>
>>>
>>> Best Regards,
>>> Chanwoo Choi
>>
>>
>> In order to remove the build warning, I changed the variable type
>> of 'irq_pol' as following:
>>
>>
>> index 140ab28dbd36..cec1889549a6 100644
>> --- a/drivers/extcon/extcon-usbc-tusb320.c
>> +++ b/drivers/extcon/extcon-usbc-tusb320.c
>> @@ -516,7 +516,7 @@ static int tusb320_probe(struct i2c_client *client)
>>          const void *match_data;
>>          unsigned int revision;
>>          int ret;
>> -       int irq_pol;
>> +       u32 irq_pol;
>>          struct irq_data *irq_d;
>>
>>          priv = devm_kzalloc(&client->dev, sizeof(*priv), GFP_KERNEL);
>>
>> Best Regards,
>> Chanwoo Choi
> 
> 
> How about changing this patch as following?
> When irq_getg_irq_data returns NULL, just use the IRQF_TRIGGER_FALLING flag
> to support previous version. Because I didn't' check the all use-case
> of this driver on DT. I think that better to keep the IRQF_TRIGGER_FALLING
> flag
> when irq_d is NULL.

Good call. Just one minor change to make the 'else' obsolete (see below).

Best regards
Lukas Funke

> 
> 
> diff --git a/drivers/extcon/extcon-usbc-tusb320.c
> b/drivers/extcon/extcon-usbc-tusb320.c
> index 4d08c2123e59..bd5ed8dd8fdd 100644
> --- a/drivers/extcon/extcon-usbc-tusb320.c
> +++ b/drivers/extcon/extcon-usbc-tusb320.c
> @@ -17,6 +17,7 @@
>   #include <linux/usb/typec.h>
>   #include <linux/usb/typec_altmode.h>
>   #include <linux/usb/role.h>
> +#include <linux/irq.h>
>   
>   #define TUSB320_REG8				0x8
>   #define TUSB320_REG8_CURRENT_MODE_ADVERTISE	GENMASK(7, 6)
> @@ -515,6 +516,8 @@ static int tusb320_probe(struct i2c_client *client)
>   	const void *match_data;
>   	unsigned int revision;
>   	int ret;
+	u32 irq_trigger_type = IRQF_TRIGGER_FALLING;
> +	struct irq_data *irq_d;
>   
>   	priv = devm_kzalloc(&client->dev, sizeof(*priv), GFP_KERNEL);
>   	if (!priv)
> @@ -568,9 +571,15 @@ static int tusb320_probe(struct i2c_client *client)
>   		 */
>   		tusb320_state_update_handler(priv, true);
>   
> +	irq_d = irq_get_irq_data(client->irq);
> +	if (irq_d)
> +		irq_trigger_type = irqd_get_trigger_type(irq_d);
> +
>   	ret = devm_request_threaded_irq(priv->dev, client->irq, NULL,
>   					tusb320_irq_handler,
> -					IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
> +					IRQF_ONESHOT | irq_trigger_type,
>   					client->name, priv);
>   	if (ret)
>   		tusb320_typec_remove(priv);