Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp2701710rdb; Mon, 4 Dec 2023 05:24:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IFMFGBK6Ej2uaNr1+te/480nUacdI0q+wMkOPK9oxp4zaHz6mzKBGWT8gmtdcQrv7T7gHGs X-Received: by 2002:a05:6358:91c:b0:16d:fc53:8528 with SMTP id r28-20020a056358091c00b0016dfc538528mr3401463rwi.7.1701696244027; Mon, 04 Dec 2023 05:24:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701696243; cv=none; d=google.com; s=arc-20160816; b=HN+hVN67jEaXOayHbXhEtyWJ6JQAoDQtd/u5VzqSn4HxKfBfyMppoVEgukrl9a2srP o24MC69E2pczolW3bBvaS2BhLXNgZ63ZLMg2cx/zHI3cZ6xpigu+C4SeBiSOup6uDcIq mbLEkEqyoWcg6ssKf83DfYrZokWxy8mOaxg1UbXWslvozHgMr22EyqTCZTUjxBm0IBqi htwp4aZgIi3wo/ECqm0VSTBcSlbB62DssX3Pf2FKkvGiXU0HgGc9fYW9iNaAiNXj7n5p 5x7BA96SzM9JYBeRap9H7LlG9qvSskUos3PeYtKMv0jdG1dVsVoNGWs+HoTB6MEVpH5p LlVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=AGmTjuqu0z1VgYzaHDOP5QTof7kCDEqGnKVi4314icA=; fh=hmt8g+YmcCjkgsJIFZO3Po9LII+duHmr+8PdaW3eCao=; b=kVEO+dJaRuuS+LQF3h6ejskkrpbM+SIlJDcO77UMnGDWwUfoPisuoT62WqgV8sXnYG ojUhtpmabJKaJKLoDt7188aLWbkRprj8153kdK21Ix6D7Kvc71OQS/WrpxAcpZsx7hVP dz6QhvTyN009wIeFmuOfAFXWlXbtw30lvv1xrAPTmyiCoh4qnhKcwuS5znoZ+tAdlvQH hfxexPuSDNrz1BM/w/9hBbIo3PsH/K+CV60/nnvbHU/zEcvqrwxAhp6gtbSWJrR48DK/ saaxeul8CHsEA9dpm8T8BvQIuQYBMEMFo74CC8EnfJz3/TlukDGJ6TeSvQyTbE6FGJ5z vOtw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=YPPjIMOu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id d24-20020a63d718000000b005be1ee5b99fsi7843264pgg.526.2023.12.04.05.24.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 05:24:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=YPPjIMOu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 82DFD809E8C6; Mon, 4 Dec 2023 05:24:00 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344313AbjLDNXl (ORCPT + 99 others); Mon, 4 Dec 2023 08:23:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344279AbjLDNXj (ORCPT ); Mon, 4 Dec 2023 08:23:39 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D1FDF3; Mon, 4 Dec 2023 05:23:43 -0800 (PST) Received: from benjamin-XPS-13-9310.. (ec2-34-240-57-77.eu-west-1.compute.amazonaws.com [34.240.57.77]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: benjamin.gaignard) by madras.collabora.co.uk (Postfix) with ESMTPSA id 1A05C66071CC; Mon, 4 Dec 2023 13:23:42 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1701696222; bh=vUKzmdehCfLCcwbM7gaKkVboVYXsxqKFA6kaBbI0L2I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YPPjIMOunjZNuH8fAjPP3b4mSMCV/NHPckS3LjK+bXSYdCykIk5tD/FGV9U+H/5BR m01dBoNIjvgtGuQ3gycq515tlISsPaWjtLe1l1HCvCUuzbKHYMfRmzn1Yqf2oUMFFo UnOxQa3CzjSVhOlkDrK40q/eNTj9/3QcyAcxPhfgEdavnwo7rrJTEAPLUdGnN5gnbG ia8NC9nuPQbrn98fm+9YJKNZrlzbyIh+IT2bAQClJ7hgJqqvN08+t5efAoom6JLvXd 0Vog+unbItWp5hnYhKxsWoojzQY0GHbQ2HcPaVEYfjhxYGUM/gMewLLC0a6GDP+R3m Tq0BN32TcXvRg== From: Benjamin Gaignard To: hverkuil@xs4all.nl, mchehab@kernel.org, tfiga@chromium.org, m.szyprowski@samsung.com, matt.ranostay@konsulko.com Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, kernel@collabora.com, Benjamin Gaignard , Ming Qian , Zhou Peng Subject: [PATCH v2 04/36] media: amphion: Remove useless setting of min_buffers_needed Date: Mon, 4 Dec 2023 14:22:51 +0100 Message-Id: <20231204132323.22811-5-benjamin.gaignard@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231204132323.22811-1-benjamin.gaignard@collabora.com> References: <20231204132323.22811-1-benjamin.gaignard@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 04 Dec 2023 05:24:00 -0800 (PST) This driver uses min_buffers_needed which vb2 uses to ensure start_streaming is called when at least 'min_buffers_needed' buffers are queued. However, this driver doesn't need this, it can stream fine without any buffers queued. Just drop this unnecessary restriction. Signed-off-by: Benjamin Gaignard CC: Ming Qian CC: Zhou Peng --- drivers/media/platform/amphion/vpu_v4l2.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/platform/amphion/vpu_v4l2.c b/drivers/media/platform/amphion/vpu_v4l2.c index 87afb4a18d5d..a80c5f28c659 100644 --- a/drivers/media/platform/amphion/vpu_v4l2.c +++ b/drivers/media/platform/amphion/vpu_v4l2.c @@ -649,7 +649,6 @@ static int vpu_m2m_queue_init(void *priv, struct vb2_queue *src_vq, struct vb2_q src_vq->mem_ops = &vb2_vmalloc_memops; src_vq->drv_priv = inst; src_vq->buf_struct_size = sizeof(struct vpu_vb2_buffer); - src_vq->min_buffers_needed = 1; src_vq->dev = inst->vpu->dev; src_vq->lock = &inst->lock; ret = vb2_queue_init(src_vq); @@ -666,7 +665,6 @@ static int vpu_m2m_queue_init(void *priv, struct vb2_queue *src_vq, struct vb2_q dst_vq->mem_ops = &vb2_vmalloc_memops; dst_vq->drv_priv = inst; dst_vq->buf_struct_size = sizeof(struct vpu_vb2_buffer); - dst_vq->min_buffers_needed = 1; dst_vq->dev = inst->vpu->dev; dst_vq->lock = &inst->lock; ret = vb2_queue_init(dst_vq); -- 2.39.2