Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp2701805rdb; Mon, 4 Dec 2023 05:24:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IHsYeI5ekKkW2K1iCCXCjttUszFgQVA+EBi2Wwo0FnlJyysHMnqUqYwZzXAYKKCc5ngXbPL X-Received: by 2002:a05:6a00:e17:b0:6cb:8beb:15dc with SMTP id bq23-20020a056a000e1700b006cb8beb15dcmr1218479pfb.30.1701696251499; Mon, 04 Dec 2023 05:24:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701696251; cv=none; d=google.com; s=arc-20160816; b=m7+pU5lQkjd8adyLeuhCkz9yciLwst+a7xDciIe3lhQahnadrlv5OiPV0EzOPKRk9z 7emPDccJ0Q3MhPdRmn/BNKhoQOUaIRUFrqDq1HLKZA0gqBLjRpUjcm4B/6A6noreIto/ rFRY8enZ/0ANYCBmUTlnak35LIwuppA5GHp5b3w50gfZjy/UN3Bn19zNZ2/M/kuKpzXz 5Ko67p43TB4U8up/5C/2P5lyWM/I5Anb0ViwlS10xroYhRM09ji8peCUadWFVIGXXh0i Thy7YWxa4yR88cC5pYJvFXO/frr0J1+KPTC2NYRuScaXNnxPjCTYPs3N3rocOKek0n3Y dqpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=EOfSvA72lEUOd2TZd5sQacdDF1rCQT0+aRZnHnkpTO0=; fh=SHDo9UqUs2L09c+CFX9UZsoU3+oauFqPePLotxsxoYw=; b=Xd1dAxoK8dn2jABt6M8KFxkB9BPnOSzu1bGjFrEziaW8HQ8dEv6FyfYpQbTjl2nqg8 f6I2XPrwKBOAyRO44Peh0yVHPJ9svKCds+YH9GlVxaWoSaLh/xQrvtTSjm8uT92A4sqY cJkdRkeocm8wPPBj1beBRm7Q+JmqRfPQVxbXB8hOy16numROAzyd6Ul+spZuztlGRcbt pyyHEnSv/TY0ZKoOV4+Jjrb3rgpCizh2SJprXJ0GmyJpwRyf4mWdsBIMhLBZP1dMfaLF pwgPx9OyOFbcOk1zufdWy8dpnU1CbOCMUZ2w0G19OEdwqREsbHuo4hfGY5hOffd5ZSIh WFig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b="e4isb/PH"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id q26-20020a63f95a000000b005b95ccd1b4dsi7557842pgk.82.2023.12.04.05.24.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 05:24:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b="e4isb/PH"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id F2E7280A9317; Mon, 4 Dec 2023 05:24:06 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344227AbjLDNXf (ORCPT + 99 others); Mon, 4 Dec 2023 08:23:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37676 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344217AbjLDNXd (ORCPT ); Mon, 4 Dec 2023 08:23:33 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 88880D2; Mon, 4 Dec 2023 05:23:39 -0800 (PST) Received: from benjamin-XPS-13-9310.. (ec2-34-240-57-77.eu-west-1.compute.amazonaws.com [34.240.57.77]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: benjamin.gaignard) by madras.collabora.co.uk (Postfix) with ESMTPSA id DB358660711D; Mon, 4 Dec 2023 13:23:37 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1701696218; bh=SGWc3SJhUtEriZPP5qupv/R50VZL3SHH8MYp7sJ69S4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=e4isb/PHzPqbYTiDeO0t2dgjXId0TEpiepai054+cSFHueB9PjmQG14sNxwrOoL9y Jale9GU8xk5ZPILkf7eoZoxxGaWFjgBq5g2Xo7+42VAtB7SaOSgSy6mUO/5Y/3UBU3 tsmO+daHgh4NxoiuI/65um63McMKYsRsKB1grdewU6f1qtNirrqzzh35/ikYuN0uVL oR7seZX2nKDzLe5KG8WNfoasMFnCZ2JXzoI4kqrtAnKtcx66EkvR7pSQhovGJYFbEa e9yMzJUFaVyHFMp957ZfjTgr7XExwyQm0AlNDS5BXt1NYWcRUAef17zP7J4w26aHIJ VtJcwuMYLAzTg== From: Benjamin Gaignard To: hverkuil@xs4all.nl, mchehab@kernel.org, tfiga@chromium.org, m.szyprowski@samsung.com, matt.ranostay@konsulko.com Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, kernel@collabora.com, Benjamin Gaignard , Philipp Zabel Subject: [PATCH v2 02/36] media: chips-media: coda: Remove useless setting of min_buffers_needed Date: Mon, 4 Dec 2023 14:22:49 +0100 Message-Id: <20231204132323.22811-3-benjamin.gaignard@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231204132323.22811-1-benjamin.gaignard@collabora.com> References: <20231204132323.22811-1-benjamin.gaignard@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 04 Dec 2023 05:24:07 -0800 (PST) This driver uses min_buffers_needed which vb2 uses to ensure start_streaming is called when at least 'min_buffers_needed' buffers are queued. However, this driver doesn't need this, it can stream fine without any buffers queued. Just drop this unnecessary restriction. Signed-off-by: Benjamin Gaignard CC: Philipp Zabel --- drivers/media/platform/chips-media/coda/coda-common.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/platform/chips-media/coda/coda-common.c b/drivers/media/platform/chips-media/coda/coda-common.c index f1d85758f6dd..d5529f988d2c 100644 --- a/drivers/media/platform/chips-media/coda/coda-common.c +++ b/drivers/media/platform/chips-media/coda/coda-common.c @@ -2546,7 +2546,6 @@ static int coda_queue_init(struct coda_ctx *ctx, struct vb2_queue *vq) * would need to be reflected in job_ready(). Currently we expect all * queues to have at least one buffer queued. */ - vq->min_buffers_needed = 1; vq->dev = ctx->dev->dev; return vb2_queue_init(vq); -- 2.39.2