Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp2701967rdb; Mon, 4 Dec 2023 05:24:31 -0800 (PST) X-Google-Smtp-Source: AGHT+IH0yLH7SqPEkuWmuamWcNDBYUL8Qnh94k6Kv3BK77lsk97mCHHJncSP6dTbjd+3WRikP/a5 X-Received: by 2002:a05:6a20:2209:b0:18f:97c:4f6a with SMTP id u9-20020a056a20220900b0018f097c4f6amr1341508pzb.118.1701696270858; Mon, 04 Dec 2023 05:24:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701696270; cv=none; d=google.com; s=arc-20160816; b=LnTDlKbl6zTTbFBqDHC/dKt6Xp7Qwwgit9zF5ni2hMli/qBtEXILiaxeljgVnBr5Ne b/IbehbWeecShG5NdoR+tzvR1vvu2j4mrXEGnMgxFfshC5lw7e200SBN9r6jIWKbEHxh E0spLlgGQjQEV3hHE4u71PEp3YscqZGSHGJs/G0y0oQD0tnuO9qHzKZb2Q6stOwYzj2z LX+YhGFFshnx74NxU/IW2B4ApgW/vywoRn8PMCcHpjXMMFeeHp7b7O4GAn3Zmp1J4Ioz 811atTijINt0SXe+ssr46KJg5Y56PrZ64I9XIYJUaJmVR34nIy/rxHZisdRwNkrjmCwV TlZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=GZ3/8Zdkd3idqphpmVHTquts916GW5WhET+zQlq/Vpg=; fh=MoA/KwnmaAdqA04K4vaZuIAl9GhCiDkX32OevKKEBOE=; b=0C/xYniv3epRUwxGl7LSzRt5G73mXwMgqpa1+dCMTJR5RX2ii2U/HKDD956smhs72M CfKoWtSMIHIrgQBoDjGs0CJIBANlEQ2TGfBvNcRMBt3gBACNGiGxj0dVdarWCsvTGAUl lf5jqmC22wsbbVsQj8+5kvvzW3cPWkGKQZkEop+ubOMm+3iQsVHgQgQD2wv8tJO0TaET INCTNBsu0q86YVOCePnSX6HPII52w8Q8DoKGC0Yy1WFGi5kEjNLRD5euM2eypzV7sz+L HmSm0mG7WLggWMshW0GiXNtXCgOM4Ze2p3JwRC1AuWeBrK7ygF6GOjkTQzeMwywOaafK NTGw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=R1cyr0Cz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id q7-20020a634307000000b005c18dd91684si7965171pga.352.2023.12.04.05.24.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 05:24:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=R1cyr0Cz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id F375E80966CB; Mon, 4 Dec 2023 05:24:26 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344343AbjLDNYI (ORCPT + 99 others); Mon, 4 Dec 2023 08:24:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344350AbjLDNXz (ORCPT ); Mon, 4 Dec 2023 08:23:55 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55E94D4B; Mon, 4 Dec 2023 05:23:56 -0800 (PST) Received: from benjamin-XPS-13-9310.. (ec2-34-240-57-77.eu-west-1.compute.amazonaws.com [34.240.57.77]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: benjamin.gaignard) by madras.collabora.co.uk (Postfix) with ESMTPSA id A5222660711D; Mon, 4 Dec 2023 13:23:54 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1701696235; bh=INhnWKxfeyDOt5+MSDz9mj1pvx9+8U4kzLbB8RirFts=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=R1cyr0Cz6N9zmXvAIXxoYllx2wyLKTZZi4UYPUCpchQiqpZuk7NPNTzz3K3ba6nGW U65GelxmN6oDuAemsPWzYSVsdMZ5L5VpLjLgHzafY7hXTt1Bfd6rpAJ3+OMe0nAhSV LvPfgrilMfXz+gqfJCoeX4RMCHXmpkC2oC/mSQkTw8iCrgP3KTz2BTKby2C0kBTPeo /iRGBvglcJwdnpUDyyTsp0gY1cdgwlANhHhT2akrKRbVaNGNQpVicR/3xKaXRDAn9E qcYRl+2pZAfgnqhozV1MrzMUmc/9uk/eCDUre8aw4G14HthQUetSCFgnjGchc2GRhl rHRWGCFHaQ1cg== From: Benjamin Gaignard To: hverkuil@xs4all.nl, mchehab@kernel.org, tfiga@chromium.org, m.szyprowski@samsung.com, matt.ranostay@konsulko.com Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, kernel@collabora.com, Benjamin Gaignard , "Lad, Prabhakar" Subject: [PATCH v2 10/36] media: ti: am437x: Remove useless setting of min_buffers_needed Date: Mon, 4 Dec 2023 14:22:57 +0100 Message-Id: <20231204132323.22811-11-benjamin.gaignard@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231204132323.22811-1-benjamin.gaignard@collabora.com> References: <20231204132323.22811-1-benjamin.gaignard@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 04 Dec 2023 05:24:27 -0800 (PST) This driver uses min_buffers_needed which vb2 uses to ensure start_streaming is called when at least 'min_buffers_needed' buffers are queued. However, this driver doesn't need this, it can stream fine without any buffers queued. Just drop this unnecessary restriction. Signed-off-by: Benjamin Gaignard CC: "Lad, Prabhakar" --- drivers/media/platform/ti/am437x/am437x-vpfe.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/platform/ti/am437x/am437x-vpfe.c b/drivers/media/platform/ti/am437x/am437x-vpfe.c index f18acf9286a2..228920450e7a 100644 --- a/drivers/media/platform/ti/am437x/am437x-vpfe.c +++ b/drivers/media/platform/ti/am437x/am437x-vpfe.c @@ -2234,7 +2234,6 @@ static int vpfe_probe_complete(struct vpfe_device *vpfe) q->buf_struct_size = sizeof(struct vpfe_cap_buffer); q->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC; q->lock = &vpfe->lock; - q->min_buffers_needed = 1; q->dev = vpfe->pdev; err = vb2_queue_init(q); -- 2.39.2