Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp2701995rdb; Mon, 4 Dec 2023 05:24:34 -0800 (PST) X-Google-Smtp-Source: AGHT+IF6v9CZBrQZ5lvDiAb+IZC41YCjf/G1+XIRc8swJl28s/IRLg/XsXyZzESkI9mq/f8cMQgl X-Received: by 2002:a05:6a00:4193:b0:6ce:4055:511b with SMTP id ca19-20020a056a00419300b006ce4055511bmr3844534pfb.30.1701696274435; Mon, 04 Dec 2023 05:24:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701696274; cv=none; d=google.com; s=arc-20160816; b=aa2CAvdDxnH+IIwwVPl+1mllh6YyoKocgrhv6g2zKrkmzlAuy9w2OLp8QEQOs0DVHN qgQyxYiDSLwWANaWSCVtkOlHvBFE/zxv24JVHidL1xmAn2pabKhZ1kJXYdW7t0DDDFvs 2CEfpX6VHTbbdn/EqF8bnc0jpOxrBvj9ScsGYkSAP/1NJKqRAIgq4UDQ30sjO7dCN7n3 qm7qbp59KbeN/x60/yuQP7VB7W8mO2bF5KOWWvGDk4/T9v4PJQs/kGSyPD+tha3qti4B Erej4IKbRTFWq5ET7B/fvSdur96ZnUgmrFKwZmL4q7byPq0sc66CwjXbJ//sa4buudP8 G9vQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=sR9uKrugBZo1NGZBb5xPvtUVTDmR09i+fYv4rZQCYfs=; fh=p007ZZnBoIZCdm2IGyLxFZB1GSDa400lEu+i15yUK1w=; b=TSxymNfCvY3KCR/qSlSdCcKbiW9bmc0gqkMDjoJuydOQaU+xUwQ2oPphJ9npmZuTdJ XPPJ/5+CVoNk1PWrZbe/YfIrzOD4fzH/c2kaZBh52rZt32INqiWJvTTVtfMxss6nhvG/ T6Pbe00oDxCbTX3zlk8/IpDLX1d7Wl30/7Lwlf29XBQrK7Ambzdi8oGSCHfTQNVYoFyb /P255LpD0cKcIRl7KR/jCV/AsJ/MIyqPgP//+loYA1nyXEq00EYGt5If4E6X/+GGYiCg TFWIN31MJ2wSyNBDaN4+EgjXFi0GzMvIWDInPTp8Vf9gFom/X2PtYYcu5LWQK1G6NkNR sU3Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=DQGdEJLn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id k15-20020aa788cf000000b0068fe0f46f27si7992944pff.171.2023.12.04.05.24.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 05:24:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=DQGdEJLn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 1B086809E8F6; Mon, 4 Dec 2023 05:24:30 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233992AbjLDNX5 (ORCPT + 99 others); Mon, 4 Dec 2023 08:23:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235518AbjLDNXu (ORCPT ); Mon, 4 Dec 2023 08:23:50 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED6A9191; Mon, 4 Dec 2023 05:23:52 -0800 (PST) Received: from benjamin-XPS-13-9310.. (ec2-34-240-57-77.eu-west-1.compute.amazonaws.com [34.240.57.77]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: benjamin.gaignard) by madras.collabora.co.uk (Postfix) with ESMTPSA id 1AFAC66071CC; Mon, 4 Dec 2023 13:23:51 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1701696231; bh=6AlqOx+FFImcfZDLMEeEUovXA4Sft7cnaCjngZduvsw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DQGdEJLnbAtvICwkzkiwILiCu5IFwCGI3sKELOnaQ4qA6uN+I1q949usc+7kddK47 1T1h+qb9y7tP7O6BmnN0dyLk7S3GuIlq0TUdEhECJt6//xOlguCvaPsCk1/urrQFuR A99ucfpNWRhBfrlpWCNn7I5kMJPhas7NFwhwsNDNXTyWFGcSnK5yCsCPB7r7CTwIjw YahM0Wd0SKKbJ5Z8RPCSvfej+gFaQMyS4JiQ+wy4p72PPBDUwCy5fcg1TzA/jjstM2 8yf1cVzOjIFQyWvlUv9KRj+Tx9paigAZMVKsM8YhFY9kAVp+4hTyzakBXHulctGw43 ROG7G9CFiDylg== From: Benjamin Gaignard To: hverkuil@xs4all.nl, mchehab@kernel.org, tfiga@chromium.org, m.szyprowski@samsung.com, matt.ranostay@konsulko.com Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, kernel@collabora.com, Benjamin Gaignard , Eugen Hristev , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea Subject: [PATCH v2 08/36] media: atmel: Remove useless setting of min_buffers_needed Date: Mon, 4 Dec 2023 14:22:55 +0100 Message-Id: <20231204132323.22811-9-benjamin.gaignard@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231204132323.22811-1-benjamin.gaignard@collabora.com> References: <20231204132323.22811-1-benjamin.gaignard@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 04 Dec 2023 05:24:30 -0800 (PST) This driver uses min_buffers_needed which vb2 uses to ensure start_streaming is called when at least 'min_buffers_needed' buffers are queued. However, this driver doesn't need this, it can stream fine without any buffers queued. Just drop this unnecessary restriction. Signed-off-by: Benjamin Gaignard CC: Eugen Hristev CC: Nicolas Ferre CC: Alexandre Belloni CC: Claudiu Beznea --- drivers/staging/media/deprecated/atmel/atmel-isc-base.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/media/deprecated/atmel/atmel-isc-base.c b/drivers/staging/media/deprecated/atmel/atmel-isc-base.c index 468568b5bb7a..c18f3ba5ae1a 100644 --- a/drivers/staging/media/deprecated/atmel/atmel-isc-base.c +++ b/drivers/staging/media/deprecated/atmel/atmel-isc-base.c @@ -1871,7 +1871,6 @@ static int isc_async_complete(struct v4l2_async_notifier *notifier) q->mem_ops = &vb2_dma_contig_memops; q->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC; q->lock = &isc->lock; - q->min_buffers_needed = 1; q->dev = isc->dev; ret = vb2_queue_init(q); -- 2.39.2