Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp2702144rdb; Mon, 4 Dec 2023 05:24:50 -0800 (PST) X-Google-Smtp-Source: AGHT+IEiGw16ZbEQ0wnLotccl9Y2norPaBLV94Qx+BcpNxDgE01yK7hGdzDul3jXYKT0cQFs00IK X-Received: by 2002:a17:902:8f8c:b0:1d0:6ffd:f1f8 with SMTP id z12-20020a1709028f8c00b001d06ffdf1f8mr1654788plo.78.1701696289800; Mon, 04 Dec 2023 05:24:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701696289; cv=none; d=google.com; s=arc-20160816; b=bsL0PxxpZxHWHvJA/W/fl8888Tn5qG6KXuBLoMKabnsE3xBldi9a+YLVOWmKPsvqS5 auKOQZS/YUnJGxD/Fiy0qIQs6aiJGVRRd0M0+R0PU8dpB4YBQ2/AIn24KX/Ds7AiQ261 FgfnCAK/+kcJiFmpFaKTHUQjQZ2yj9f2yTohrTFWilOz28440iQzpSt3WGKpndvr0WSP VcowrAPkyquimW/8LEbCTYkOEXYjPbN3T6G5oGJd71B3TgaTQbwwFqVGBYTNg1r3P7q1 GkfIq2gPidvDpTWR6zdaGPVxaUpNNePZiUjzGnyi3m/9XAXZ3cS2d9BED9ABi9qo32E+ i0xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=LI0lWI5qs6/DijOp7ivOhoeLVwXQk/B7TmVhXqrHHLI=; fh=nikTID0PJ6NwkGNufN11Ag6f/xC6mcRAltiCDIW3jKo=; b=hwSxv1BF9YD2Kqpkr0C2iypnkoQhm5Yrym/AtP4GrWBLGWwoFw8grIdwLjbLa6Rn+X WRNXib5Tl9aa4zgnofNvjFyjd5GddvSlkRC9GMDNA6Ly8DqM62MzSwGK+IFqeL1Vs1dK hSfFwDWp3frEl9WSsCpGWPJ6QJCYD1rRwwoStPsw38Xz7AgEIcNIwzqK35yqS7NhJCGA LUR0h4oUBkR+U8HErlasLATU88gwrVne+6xpYGaHNfEKmgx8Wxs0bN48BzTg/TXJNPxG kHTnUgSXCcCSQRu6DeUPEpgjzUWzt48MvIQVwVOBnWa9yk80NDrLpjuz7ilnWAN1gEFv UWeQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b="QYIu4Je/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id u1-20020a17090341c100b001cfe100a99fsi1983387ple.487.2023.12.04.05.24.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 05:24:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b="QYIu4Je/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id BDD07809D471; Mon, 4 Dec 2023 05:24:46 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344455AbjLDNYb (ORCPT + 99 others); Mon, 4 Dec 2023 08:24:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344457AbjLDNYE (ORCPT ); Mon, 4 Dec 2023 08:24:04 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30BFE184; Mon, 4 Dec 2023 05:24:03 -0800 (PST) Received: from benjamin-XPS-13-9310.. (ec2-34-240-57-77.eu-west-1.compute.amazonaws.com [34.240.57.77]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: benjamin.gaignard) by madras.collabora.co.uk (Postfix) with ESMTPSA id 640EC66071CC; Mon, 4 Dec 2023 13:24:01 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1701696241; bh=Td6waqKLfQADCpGtVukzLb1z1c+xWCgcYmy4mUTwhEM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QYIu4Je/wnXRFw0SFkQ7Eq60kt3d91eWlmUmvf2Cj5q0PczHT970mjh3G3MovqjZx oGGTnV3iT3vERDBgP06goLwxus9Cel/ivoJ2FdYzlkDNatZEDdrhT+f0YCF7aU+zNO 5zb0G7yq4w73dYvBr++4kRz9/aX1hRjgtYroPfyviFM2ZBYu4C8IgT4a/TYRLi+kyE T/Cfr+K0iRsMHG7dVBl5RviAPi89RhyMB48CxM+QwJArSFHgj1C1qMZ2wI3HZVvyVI uKk+ywXY5pYsa99DOee58zFfCrVbIGVMXYCJNcON7YWqMaDSAKcjhUTo7g7GOD3nFv ehOrezeltVeTg== From: Benjamin Gaignard To: hverkuil@xs4all.nl, mchehab@kernel.org, tfiga@chromium.org, m.szyprowski@samsung.com, matt.ranostay@konsulko.com Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, kernel@collabora.com, Benjamin Gaignard Subject: [PATCH v2 14/36] media: ti: omap: Remove useless setting of min_buffers_needed Date: Mon, 4 Dec 2023 14:23:01 +0100 Message-Id: <20231204132323.22811-15-benjamin.gaignard@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231204132323.22811-1-benjamin.gaignard@collabora.com> References: <20231204132323.22811-1-benjamin.gaignard@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 04 Dec 2023 05:24:46 -0800 (PST) This driver uses min_buffers_needed which vb2 uses to ensure start_streaming is called when at least 'min_buffers_needed' buffers are queued. However, this driver doesn't need this, it can stream fine without any buffers queued. Just drop this unnecessary restriction. Signed-off-by: Benjamin Gaignard --- drivers/media/platform/ti/omap/omap_vout.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/platform/ti/omap/omap_vout.c b/drivers/media/platform/ti/omap/omap_vout.c index 72ce903717d3..f67a45f1441b 100644 --- a/drivers/media/platform/ti/omap/omap_vout.c +++ b/drivers/media/platform/ti/omap/omap_vout.c @@ -1404,7 +1404,6 @@ static int __init omap_vout_setup_video_data(struct omap_vout_device *vout) vq->ops = &omap_vout_vb2_ops; vq->mem_ops = &vb2_dma_contig_memops; vq->lock = &vout->lock; - vq->min_buffers_needed = 1; vfd->queue = vq; ret = vb2_queue_init(vq); -- 2.39.2