Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp2702207rdb; Mon, 4 Dec 2023 05:24:54 -0800 (PST) X-Google-Smtp-Source: AGHT+IGUPv+a4KLedeQlMG83NGg1eF4WjQAEwp+uCBMDcYryvpPnU+9SGKlB8wdybA2k+0Hck7zx X-Received: by 2002:a17:903:25d1:b0:1d0:559e:412d with SMTP id jc17-20020a17090325d100b001d0559e412dmr1767946plb.61.1701696294163; Mon, 04 Dec 2023 05:24:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701696294; cv=none; d=google.com; s=arc-20160816; b=HX06C071JsY4bJu2aUJ9O/wnymclN5wdaWM6auqQUBZeIY0YzQZ+sEvHrX4Fn0Aah9 LunSiYuS2qgi8wwXoZJf2RGcXRQdTsIW8gMH3Dx/ZTm+j3o2lSGr9G0Ui3LzEx6Akiva dnQLtijlyuDONzWzJcGLjnXLjtbZjhhcj/XDHjQQa4PyQ6cb51/SkIxxUSB1nu6USTjp XjtN9LBgCyzWAAfZA+9b75+7ga2TKRsOAg5NbgSy/2hfxQ5SAybq+zaTGvXyKfeu46Vq WYuXDVPuKM2+KgYhgTB9I1U71uN8vZH4oY9CVxM3uGRp3Tpy4rXQMas70YFazcTVIpZZ UKUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=xG0AJpbc/uNPOTV+EEMcUWI1QnhahI9oExdDgUNm3JQ=; fh=nikTID0PJ6NwkGNufN11Ag6f/xC6mcRAltiCDIW3jKo=; b=FteDQoT1Pd6/lgnvy0skTktikXYwc0upRGXtD/wJuyrZGaQOZHfeqWxMo49+Ufgg+5 9XMfB4LnQmBl8tn3Y6nNSJ/c/lf1mZk3UJIED7Uf9xc15T9yWHjU3G34kJdL2yyVG6sF sJzfW5ZsHv5hdk64ObR1FTbVkOj+zw2YY7oay9bjzwCTqVzoEcRnoLSrXdGh79+a2FMd +oD3FLaHharXnQUsyjgeMzwW4yOz86sgruwl6j98Q5GfbFaAoNEWBqJaBqzwNxo/JRy+ 0veU5a6f7pTib7+wmV4rf2Y3/rTYz+9S2wT6Gu/JnmOGROegawXRU7Eua6qP5D/JO3gW aUtA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=DRrAzwNQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id i6-20020a17090332c600b001d0bcd70814si204928plr.294.2023.12.04.05.24.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 05:24:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=DRrAzwNQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 979A4804138A; Mon, 4 Dec 2023 05:24:46 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235515AbjLDNXu (ORCPT + 99 others); Mon, 4 Dec 2023 08:23:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344330AbjLDNXm (ORCPT ); Mon, 4 Dec 2023 08:23:42 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9A92D2; Mon, 4 Dec 2023 05:23:48 -0800 (PST) Received: from benjamin-XPS-13-9310.. (ec2-34-240-57-77.eu-west-1.compute.amazonaws.com [34.240.57.77]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: benjamin.gaignard) by madras.collabora.co.uk (Postfix) with ESMTPSA id 275526602020; Mon, 4 Dec 2023 13:23:47 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1701696227; bh=jON8BOdCAHEK/Xd0Dl3W1Jb3UXgsTiGXSbXsYdLJdIY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DRrAzwNQiG4aTqwGt24i0ROd0oGyvYIvQoLFxdhV2VVgvYsljYfEhYcQkBslVXJig ZSEOGDiKkbaKKqcfCpQsALuYmKrRM6y9U9ZTrKCpTvLi+/vIBEdDcE3xTiRvzTO/Lh d7Ngg6cYlsOqWbNqxL0N4oxbdBCnE68dzmZkAWfewpr22zpU9Z2K5jAuajOlnyj5ZS bNHQuVPYCMi1o16ue5fP/0IY9xUdvQIEmC0C2WTNaGdkeNDB9nL12p5D15uE/ixo2i vwbFEwI5bya62nzVGDU1WcTBJo2a+38rG0nvQUeCy9MEyQ76ao8B2lIuN88juzYftp WglNxhx/vKSbw== From: Benjamin Gaignard To: hverkuil@xs4all.nl, mchehab@kernel.org, tfiga@chromium.org, m.szyprowski@samsung.com, matt.ranostay@konsulko.com Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, kernel@collabora.com, Benjamin Gaignard Subject: [PATCH v2 06/36] media: i2c: video-i2c: Remove useless setting of min_buffers_needed Date: Mon, 4 Dec 2023 14:22:53 +0100 Message-Id: <20231204132323.22811-7-benjamin.gaignard@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231204132323.22811-1-benjamin.gaignard@collabora.com> References: <20231204132323.22811-1-benjamin.gaignard@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 04 Dec 2023 05:24:46 -0800 (PST) This driver uses min_buffers_needed which vb2 uses to ensure start_streaming is called when at least 'min_buffers_needed' buffers are queued. However, this driver doesn't need this, it can stream fine without any buffers queued. Just drop this unnecessary restriction. Signed-off-by: Benjamin Gaignard --- drivers/media/i2c/video-i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/i2c/video-i2c.c b/drivers/media/i2c/video-i2c.c index ebf2ac98a068..8d7f01b50aa7 100644 --- a/drivers/media/i2c/video-i2c.c +++ b/drivers/media/i2c/video-i2c.c @@ -795,7 +795,6 @@ static int video_i2c_probe(struct i2c_client *client) queue->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC; queue->drv_priv = data; queue->buf_struct_size = sizeof(struct video_i2c_buffer); - queue->min_buffers_needed = 1; queue->ops = &video_i2c_video_qops; queue->mem_ops = &vb2_vmalloc_memops; -- 2.39.2