Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp2702228rdb; Mon, 4 Dec 2023 05:24:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IEfubftYLUfbU9nMFYpNV4LEVPPaOFLXTpdYcuLBqsYRBHkXfd8w6+EG+upa3XNDSkfGv+O X-Received: by 2002:a05:6a20:144a:b0:18c:548d:3d1a with SMTP id a10-20020a056a20144a00b0018c548d3d1amr1859859pzi.58.1701696296127; Mon, 04 Dec 2023 05:24:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701696296; cv=none; d=google.com; s=arc-20160816; b=V7XKPFlHNqQTsM2IoUI77Pt8MvYnUMkkkzvcGR4WvQs/516I2yJVEhlIgWlOgj/90F 4Pq02/3fTm3Mf3bA/Fqc3Dj9hPR3RL04D0Wm10EZq1Vz5RQ1pL/s8qJoBVK4AsdMVZ6a fwPQxWY2X4rMkk7ILL1FH0WVDWWLFXQS5wNrLZ6LUaJUDsOR7u1GwJPhI5Y5WbaFRW6j pVzcw9/ttq+cIO+og3TeyZwBtRwvT03+xGMDpj8Ej+5t5CVI4fu+HGfWNfrzSlNenyR0 Llt+eRgNhZoBouRuqTzdrGSYTISYAlmqL5uEUfOfH+VikomFMHMBVojFto36rUWf6Evl KKCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=HvI4j6UX8HLvH4wh6dgpBr0z2kFUOR6NsIeg4IOgNeE=; fh=Eo/XmICo8RNj9cSgIUzFxXl6B5wV7+CHH/7p7ygfjD8=; b=ghWfWnyjC76jzMJVoj6RhyZ0vopMjv+iM+eq1feEacknD8oLMBPxFqf9plU9PtICjU ylA1IshIYA5AUu5NC4vePRFxblkln8mwH/dyhbq4suZlq5oE2kT0j3uEcYe2IFqGsu6Q RbcTC+mneVE0/rfVBhygOXevpBhyb9idsxuv8QGkx1TeA2nz+qI4cYYJuJdnbgLC3JjI J27Byx8p07HGMqCvU0qPefQt+kU1VIB5M3XhlozVu13E/r7wO2yttLglE6Iq8Q8vepsW +mgJZKIEiy9mW/B+cxfr9Z2X4TKhHJEjTSQ3xrooGyFgTAtQGQ5Mio6ScMWGGxHGEAvH 2+gg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=IKAhwex1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id em13-20020a17090b014d00b00286b7ade15esi1445542pjb.51.2023.12.04.05.24.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 05:24:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=IKAhwex1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 1B9468041394; Mon, 4 Dec 2023 05:24:47 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235527AbjLDNYV (ORCPT + 99 others); Mon, 4 Dec 2023 08:24:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34662 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344431AbjLDNYD (ORCPT ); Mon, 4 Dec 2023 08:24:03 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89F68D60; Mon, 4 Dec 2023 05:24:01 -0800 (PST) Received: from benjamin-XPS-13-9310.. (ec2-34-240-57-77.eu-west-1.compute.amazonaws.com [34.240.57.77]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: benjamin.gaignard) by madras.collabora.co.uk (Postfix) with ESMTPSA id D9B866607285; Mon, 4 Dec 2023 13:23:59 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1701696240; bh=Zf8T0QawxN16ZAg63GdDflHcfaq5H6YtXv9s0/s7xXc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IKAhwex1gFYRAx3hDHfxpFowqZMci/itc9EIWax2F28K5av71bY6AVFdDwDMabDkO F8pei7hGvnqijiEDT8b65C8XvUu4EI4ZZaDIHGzUqC4dquLlXEtD3yBW+Th49QhiJ+ 3oTpIFx23HMiPvuZ+zq0TnCF4aa8+6gsItQxoVcIQGVez444eYTocYRSL53yzBNCyk LdVOdnecbd5E1ZaknmOjUHASrCY7aw9X+yfCB/uWMGFMTBnmuutl2o4wPe7siRIfIS KkWz5t2H7+wjmFmUirL8yrcOdcungJwNuleDKCRkbG7mKeDHgUop1vsAFZKjENCoyb U3nnMlT5mKcNA== From: Benjamin Gaignard To: hverkuil@xs4all.nl, mchehab@kernel.org, tfiga@chromium.org, m.szyprowski@samsung.com, matt.ranostay@konsulko.com Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, kernel@collabora.com, Benjamin Gaignard , Jai Luthra Subject: [PATCH v2 13/36] media: ti: j721e-csi2rx: Remove useless setting of min_buffers_needed Date: Mon, 4 Dec 2023 14:23:00 +0100 Message-Id: <20231204132323.22811-14-benjamin.gaignard@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231204132323.22811-1-benjamin.gaignard@collabora.com> References: <20231204132323.22811-1-benjamin.gaignard@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 04 Dec 2023 05:24:47 -0800 (PST) This driver uses min_buffers_needed which vb2 uses to ensure start_streaming is called when at least 'min_buffers_needed' buffers are queued. However, this driver doesn't need this, it can stream fine without any buffers queued. Just drop this unnecessary restriction. Signed-off-by: Benjamin Gaignard CC: Jai Luthra --- drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c b/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c index ada61391c8d2..1e5f68f50afb 100644 --- a/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c +++ b/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c @@ -873,7 +873,6 @@ static int ti_csi2rx_init_vb2q(struct ti_csi2rx_dev *csi) q->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC; q->dev = dmaengine_get_dma_device(csi->dma.chan); q->lock = &csi->mutex; - q->min_buffers_needed = 1; ret = vb2_queue_init(q); if (ret) -- 2.39.2