Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp2702713rdb; Mon, 4 Dec 2023 05:25:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IHP8v3dlDIJUIyDYDH+ZIPX0GDYA9OvZ5v7CV7kezQT6Y9StjMWBoQo+o1Slj5JGCE5Els/ X-Received: by 2002:a17:903:1211:b0:1d0:6ffd:e2cf with SMTP id l17-20020a170903121100b001d06ffde2cfmr4102671plh.105.1701696349506; Mon, 04 Dec 2023 05:25:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701696349; cv=none; d=google.com; s=arc-20160816; b=aJZPoxPic0T+pAsh8eWi7D4njMhbg8ZJQ3QtB6BkvK3YtLQL/wOdttAIlnTXEhKcRB sL5TyLOnsNycgNwFirWoz2wSUfMKI086EN4j83v2sXsaPVzV4zLtDlp762yY+V7kKDXs uhWQzLE8Yu7d5c3EEQ8roxSiDp9DVV73/DDqRIXTzRPYhM4lREYjn6xP84lSLjG4HxTQ Ueg2lEQx7dBlQjSJ11GQ5AjNW4QiUvV0gMUUrJ7RbCDbXcEoVNpdJLghASZr272UhZoy OLq4HHaSvUoddPbyblk0UW+gnBmDSidk5dxIMSbe+mMn09/FpeWCijDW2PGOqxhTZB5l ykJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=+HcsJRDXaTlPPrQoBj0PF5orj8T5RajAObx8/Ai3TGU=; fh=X7Ma/cemRPsjpK6kVEx/6P3iPO1SzFjCnWIIn7w15JY=; b=wEO9jPtpxv8lro88hOYHRRg0MpPfwzKKJHkYobK/upmtyRTNt4vrS1SRgN0K1YifMk Ats4Cuk41UF4FXbQVMRB9dSz764G8vhf0Z58bn/W7XRy5IXmZNDuMdHie/cJvKBJZTi2 hsCkp/sVBW+yyDSCsZa6CPKcOodL2o7m8sPPq+bSGhxXPHia4zKfFBP0G4sP/c4vI2aH RzKk3PFgz7pEu4GNaej/RLTYF3muzAczLqUAscP2BFqjck8zNK8qaJHtoX+33gOnCFC5 I8iK2qi5DMOUr23fxwysQqYdQCGfn6ozJpB0CQa00GQ2IL3xpu3ba6RCeQHaqoKwNCqr KRBw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=Q16SfkSU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id k24-20020a170902ba9800b001d0bf9348e7si26700pls.63.2023.12.04.05.25.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 05:25:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=Q16SfkSU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 86052809269F; Mon, 4 Dec 2023 05:25:43 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344333AbjLDNYm (ORCPT + 99 others); Mon, 4 Dec 2023 08:24:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344307AbjLDNYG (ORCPT ); Mon, 4 Dec 2023 08:24:06 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E0151134; Mon, 4 Dec 2023 05:24:08 -0800 (PST) Received: from benjamin-XPS-13-9310.. (ec2-34-240-57-77.eu-west-1.compute.amazonaws.com [34.240.57.77]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: benjamin.gaignard) by madras.collabora.co.uk (Postfix) with ESMTPSA id 362426607090; Mon, 4 Dec 2023 13:24:07 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1701696247; bh=nXea1hVd1CLJC4QjmTPo1Qmgjq3TpB25wTNYX2076fw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Q16SfkSUODOUuv0aRr1a3vsuwi50wG5boYx5dbxzV+1JktEOinEGm2IbRY9SpbKIV uM2jMqTnnGkJTXKKIa8mKU7hq6w1abgA7+HUszwqS82ybLLjoXljwQygr7sorOQRB7 KZwGn6pABnYlJv7ayfvX9QB860fC9ChvBaocsCayHnHRWp4AJE6RWCnPzPBxda0HHt vnVWvcjjNz7i1wyRuKe2qbBTVG9/qsj5O/UOfArfMDW43kU60C6gjjfNL3VH36Cp9Y BLJsRd8531dND0h9nAJRsyvud+k5/sVWisQpOXTHzV/objUYPOyC4YM4mU6wdBvTA6 kz5tfeY4HaeOg== From: Benjamin Gaignard To: hverkuil@xs4all.nl, mchehab@kernel.org, tfiga@chromium.org, m.szyprowski@samsung.com, matt.ranostay@konsulko.com Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, kernel@collabora.com, Benjamin Gaignard , Michael Krufky Subject: [PATCH v2 18/36] media: usb: dvb-usb: cxusb-analog: Fix misuse of min_buffers_needed field Date: Mon, 4 Dec 2023 14:23:05 +0100 Message-Id: <20231204132323.22811-19-benjamin.gaignard@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231204132323.22811-1-benjamin.gaignard@collabora.com> References: <20231204132323.22811-1-benjamin.gaignard@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 04 Dec 2023 05:25:43 -0800 (PST) 'min_buffers_needed' is suppose to be used to indicate the number of buffers needed by DMA engine to start streaming. cxusb-analog driver doesn't use DMA engine and just want to specify the minimum number of buffers to allocate when calling VIDIOC_REQBUFS. That 'min_reqbufs_allocation' field purpose so use it. Signed-off-by: Benjamin Gaignard CC: Michael Krufky --- drivers/media/usb/dvb-usb/cxusb-analog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/dvb-usb/cxusb-analog.c b/drivers/media/usb/dvb-usb/cxusb-analog.c index deba5224cb8d..a038d97dd62e 100644 --- a/drivers/media/usb/dvb-usb/cxusb-analog.c +++ b/drivers/media/usb/dvb-usb/cxusb-analog.c @@ -1632,7 +1632,7 @@ static int cxusb_medion_register_analog_video(struct dvb_usb_device *dvbdev) cxdev->videoqueue.buf_struct_size = sizeof(struct cxusb_medion_vbuffer); cxdev->videoqueue.timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC; - cxdev->videoqueue.min_buffers_needed = 6; + cxdev->videoqueue.min_reqbufs_allocation = 6; cxdev->videoqueue.lock = &cxdev->dev_lock; ret = vb2_queue_init(&cxdev->videoqueue); -- 2.39.2