Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp2702869rdb; Mon, 4 Dec 2023 05:26:05 -0800 (PST) X-Google-Smtp-Source: AGHT+IHA5yM9CRQd4he1oe/J+kZusOv8rYoDa7J8dQjDmYi81AQIH1ZHJjgNU0Up26RlH1KHOIJL X-Received: by 2002:a05:6358:71c8:b0:170:17eb:1e6 with SMTP id u8-20020a05635871c800b0017017eb01e6mr1699555rwu.41.1701696365174; Mon, 04 Dec 2023 05:26:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701696365; cv=none; d=google.com; s=arc-20160816; b=PYPBwxWHjrUfb9YPxmvO5KgVOkzIgcGNs+4k2lBQdrpDerUV7H37mDko0dGs35jI+C ZUeLkIVaPROG3Qy3au8c/R9gWgAplhuvXG0I8bmJdi4sXtBQWV+m6AY2IILcHCmyFNLx m+0KPKHG+tH0AE6IepwtptH5w6eIBtLmF9/WZtQMgplnkkjcYgarjJUIJw7/owxvlDG1 qKCj1tUg3iGv32j+Ngr8lMHuBBbDuq/3scS5MKHQb0nVUAd8qTveQAVtqxScl4Osca/r fclTcWzb6XcMf7nM+zoOusiSMpJ8zfQOb7J8u8Rnld2b27Ct2BQI+VmJXyj7LR8HyYtc KM+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=lY//fy0IHfLBSa9Pn2kLo+eycY/XdjQVI/4ZSSgpz5I=; fh=kFeEET2Sn7AfPPwZWtXJEfQj1r+0ZzDCkmJDn3z6yDY=; b=ShIbT2EGIjylCveF5UZ7bHp1Tt4HiuOFkxVpT8IuEfLnDPvrUUj0AdG7MvZKp1CAjv VG7DcsF1X13XuLU0xGlcTEIEQWiJG0yuVD1LZ147tZsY8Cl0aeinJeXJumx4Ce3L9cz3 fMS2TYa9PD2iYGMBeLeSLRQGTv76EXojb67ImhTGTU25dpaNU7MvE61zaRCKJ4fAeeqZ /2qmiJ/3DCkSTK2+I6a+fB/6nEOK6fqVvR5NWSQnp0C9Ybqx9xPYvDAIhbYw3E0ecq3A sACUBfH+m49d48khrX5s2KlRgBsjw/eNav8Q53bCGF4vb2ZBQ1SFh10vSWIm6ds9L8/n Gw3A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b="ScY/owUY"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id r5-20020a632045000000b005c1c489bfc6si8087419pgm.627.2023.12.04.05.26.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 05:26:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b="ScY/owUY"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id CDD56806D47B; Mon, 4 Dec 2023 05:25:31 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235565AbjLDNYe (ORCPT + 99 others); Mon, 4 Dec 2023 08:24:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344468AbjLDNYF (ORCPT ); Mon, 4 Dec 2023 08:24:05 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 92C1418F; Mon, 4 Dec 2023 05:24:04 -0800 (PST) Received: from benjamin-XPS-13-9310.. (ec2-34-240-57-77.eu-west-1.compute.amazonaws.com [34.240.57.77]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: benjamin.gaignard) by madras.collabora.co.uk (Postfix) with ESMTPSA id B79946607090; Mon, 4 Dec 2023 13:24:02 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1701696243; bh=hw+EcJmQWwZPR1A5B99ReLj35TY7AMeTL9JoTuzkKAo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ScY/owUYVMArpLwsZLqwD8BURKTytyZwaGhIdZHnATD5V85sPJdmyfgFtfJ3W58n1 AzJOV3V9/JsgScBZdgNAdJY9+25vMZ5RiDFw9inseTsVPtLLrZ+jueagxnryoW3wk0 3Krn8WecTG7xtTt3bIhU/cwVFCTe7JG7YYmjkJLgi3dkMOw9vVOqt5Puo4w3vwMvrr dTxcbbpDVNka5SRJH3yZagQbR3c96AdjTNGETYIVjf1cQvRFDZkUEKXg9qT7b7CTe3 aFnm2Cg6rjBUGVDvm5fxjhAtsj/PK3ikUklYREsbhNeyZD/tQpaFVkqWXKI5TmAM1r GaIgzX1iEKCzw== From: Benjamin Gaignard To: hverkuil@xs4all.nl, mchehab@kernel.org, tfiga@chromium.org, m.szyprowski@samsung.com, matt.ranostay@konsulko.com Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, kernel@collabora.com, Benjamin Gaignard , Yong Zhi , Sakari Ailus , Bingbu Cao , Dan Scally , Tianshu Qiu Subject: [PATCH v2 15/36] media: pci: intel: ipu3: Remove useless setting of min_buffers_needed Date: Mon, 4 Dec 2023 14:23:02 +0100 Message-Id: <20231204132323.22811-16-benjamin.gaignard@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231204132323.22811-1-benjamin.gaignard@collabora.com> References: <20231204132323.22811-1-benjamin.gaignard@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 04 Dec 2023 05:25:32 -0800 (PST) This driver uses min_buffers_needed which vb2 uses to ensure start_streaming is called when at least 'min_buffers_needed' buffers are queued. However, this driver doesn't need this, it can stream fine without any buffers queued. Just drop this unnecessary restriction. Signed-off-by: Benjamin Gaignard CC: Yong Zhi CC: Sakari Ailus CC: Bingbu Cao CC: Dan Scally CC: Tianshu Qiu --- drivers/media/pci/intel/ipu3/ipu3-cio2.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.c b/drivers/media/pci/intel/ipu3/ipu3-cio2.c index 5d3b0ffd3d08..7f72be686981 100644 --- a/drivers/media/pci/intel/ipu3/ipu3-cio2.c +++ b/drivers/media/pci/intel/ipu3/ipu3-cio2.c @@ -1589,7 +1589,6 @@ static int cio2_queue_init(struct cio2_device *cio2, struct cio2_queue *q) vbq->mem_ops = &vb2_dma_sg_memops; vbq->buf_struct_size = sizeof(struct cio2_buffer); vbq->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC; - vbq->min_buffers_needed = 1; vbq->drv_priv = cio2; vbq->lock = &q->lock; r = vb2_queue_init(vbq); -- 2.39.2