Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp2703106rdb; Mon, 4 Dec 2023 05:26:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IHiugzU0VsrWRHkoM+LVZCr5Eh/q9i5oa34wexyR8pFAcFKG3U8+YE+bERO4fGJV+2uOjZ5 X-Received: by 2002:a05:6359:29b:b0:170:17eb:2054 with SMTP id ek27-20020a056359029b00b0017017eb2054mr3054695rwb.61.1701696390161; Mon, 04 Dec 2023 05:26:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701696390; cv=none; d=google.com; s=arc-20160816; b=alk5xLzV3zHPVsIMCtqbbIqfe2cnngpQmsRMrpxS8Zr9r0MmdF4qwhCpSi1kMYMA8i 8gQek6y83Eg0rLS+qO6OD9riihcVKnEsJrFA8g60sxUiD29svq+g34DSpNrEaquML+Q7 uOMLa4KdOt4yHNF1VM0A9kGkAHKVIypDa/Xyt6ZRLtlCFWAzP22g3p9xZdo4eTYpn5Yg XSy/c6lcV9zmhUOnXR3cx/CZRtCG7Qh+n4D5AIb0JFuYzLvmYMNg67r7ms7IdnhsPLZs xICshPJybHOhADgIH5LdrOzwIeQCxsi3F/8XHLyrqzcTmNHjWZBp9P/8m94teZqDkO8J aXjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=dacwjV9GZ8fbusF4fqlg88GIJyDKYCvTV+c7K23zUnY=; fh=AJvajGurJww4MIiKHtF6oSDbh02msZyVL2eyE+ODfEQ=; b=TIN4A7zd5ZGGwsKznBoywvuJ97S+nlxFwAYctJRODWkDMrkxya3u1EXIGgBd0xQ6yl f9QUwaJEyZ7hVnevXDqb/OrvdJxwhMsDFMLJ5HpKCzlTuaXixZrLPo6p2oLduXQu/dV6 WvYGYUWvkHtBEoFeH8AblVTF26jRgHIbgwulcj5JrnLWK86uiEuwVJcO97+lQdvq4g9m UnZ36NFBx59hxDBOSIPAjR6t2hWXu4bRf2IMbYwAUX6VVOr2UU9zL5XBXMJan5QKcVhH wNxQWuIT/f2idwcg2p6JQFVrWtVy8Z4Qsd6Y7OnyCT8fn39sV5lCXJhZ/DuWub1xXvs+ 4R+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=bsemf9sM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id k190-20020a6384c7000000b005c2783b71cesi7579037pgd.661.2023.12.04.05.26.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 05:26:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=bsemf9sM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 806E880A30C9; Mon, 4 Dec 2023 05:25:43 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344461AbjLDNZW (ORCPT + 99 others); Mon, 4 Dec 2023 08:25:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235413AbjLDNYc (ORCPT ); Mon, 4 Dec 2023 08:24:32 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37C2B1981; Mon, 4 Dec 2023 05:24:20 -0800 (PST) Received: from benjamin-XPS-13-9310.. (ec2-34-240-57-77.eu-west-1.compute.amazonaws.com [34.240.57.77]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: benjamin.gaignard) by madras.collabora.co.uk (Postfix) with ESMTPSA id 6121066072A4; Mon, 4 Dec 2023 13:24:18 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1701696259; bh=nJOkOwWG7HAPg6iANkaE4/DJj5MpFIvKCNqxFpSa5Zo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bsemf9sMBDox41v7pChvajWkARkXsziAH64yIkLruyeXdNhLanAXUykBK0iYk6LqM P5B52tdP2M6EOzsi85N6KnczR+8NwAr6ESG3bmgM2Q+TnNJLDIKVr8j13XqYF7/8vb r9h7ay6XTl2zDTa8+kE5YjXRO2IdNmfICN26EU7AQRH+h4gnULKBCO1VyLT3TNVVCQ 4N3+xpjLOQ5Qy/v578gl8HNP/wy2jEtJIY4wF2J5IQIrn6dvpV/Y6TvnynTnpoSRsp 5cF8p6BstrnU7dk8eDwXMnPASKfPQfplh/RZtZpuUdZOWrrt85YEX6vOe8y5TXi7By pUPCc7WS/vXZg== From: Benjamin Gaignard To: hverkuil@xs4all.nl, mchehab@kernel.org, tfiga@chromium.org, m.szyprowski@samsung.com, matt.ranostay@konsulko.com Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, kernel@collabora.com, Benjamin Gaignard , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland Subject: [PATCH v2 26/36] media: sun4i-csi: Fix misuse of min_buffers_needed field Date: Mon, 4 Dec 2023 14:23:13 +0100 Message-Id: <20231204132323.22811-27-benjamin.gaignard@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231204132323.22811-1-benjamin.gaignard@collabora.com> References: <20231204132323.22811-1-benjamin.gaignard@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 04 Dec 2023 05:25:43 -0800 (PST) 'min_buffers_needed' is suppose to be used to indicate the number of buffers needed by DMA engine to start streaming. sun4i-csi driver doesn't use DMA engine and just want to specify the minimum number of buffers to allocate when calling VIDIOC_REQBUFS. That 'min_reqbufs_allocation' field purpose so use it. Signed-off-by: Benjamin Gaignard CC: Chen-Yu Tsai CC: Jernej Skrabec CC: Samuel Holland --- drivers/media/platform/sunxi/sun4i-csi/sun4i_dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/sunxi/sun4i-csi/sun4i_dma.c b/drivers/media/platform/sunxi/sun4i-csi/sun4i_dma.c index 95b5633b7914..8f071cba2d25 100644 --- a/drivers/media/platform/sunxi/sun4i-csi/sun4i_dma.c +++ b/drivers/media/platform/sunxi/sun4i-csi/sun4i_dma.c @@ -411,7 +411,7 @@ int sun4i_csi_dma_register(struct sun4i_csi *csi, int irq) for (i = 0; i < CSI_MAX_BUFFER; i++) csi->current_buf[i] = NULL; - q->min_buffers_needed = 3; + q->min_reqbufs_allocation = 3; q->type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE; q->io_modes = VB2_MMAP | VB2_DMABUF; q->lock = &csi->lock; -- 2.39.2