Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
From:   Donald Robson <donald.robson@imgtec.com>
To:     <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
CC:     <frank.binns@imgtec.com>, <donald.robson@imgtec.com>,
        <matt.coster@imgtec.com>, <maarten.lankhorst@linux.intel.com>,
        <mripard@kernel.org>, <tzimmermann@suse.de>, <airlied@gmail.com>,
        <daniel@ffwll.ch>, kernel test robot <lkp@intel.com>
Subject: [PATCH 1/2] drm/imagination: Removed unused functions in pvr_fw_trace
Date:   Mon,  4 Dec 2023 13:36:11 +0000
Message-Id: <20231204133611.53913-1-donald.robson@imgtec.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?EwJsaXDw+2m6G/1vtcarul3DHqpiNGP9B4BzkBxA19xP9XjOoOc/ZpLDYvEg?=
 =?us-ascii?Q?+NSsFMKB1TkOmlu9NKrUK2v63IUQ7AjswIlWtmSZjs8cYqIxrC3hDN08FIHU?=
 =?us-ascii?Q?USEbZeHzrvPOooPUiyfQbU2oI8FkXtpuV+igYl4ys3Y3ibIzzBtvK1ZhwIwV?=
 =?us-ascii?Q?QPhu6Ub44vpVu5C5hBU5VckePl6gtZdau7zeHXb5KhlxN6xO/XrtwNd2K6QA?=
 =?us-ascii?Q?Y+HYkIprijh/hEAYPkxdV+zUbmMq3CqPBoOkSCHkXHnehs+HaElMXoczM8lu?=
 =?us-ascii?Q?xCkaU74n5vrVh+aEDNqyv5wHljlpOrAvK8mNCl8VTf6MKbMhQgg/s3LHOQNx?=
 =?us-ascii?Q?c/dZAC9GjbH7MEeZX/KIa5MWuQnGTqGmjQVEoq03tGf7uFvFaZlFwsV12Vpe?=
 =?us-ascii?Q?XkLtyVFaw7Ddnv0cWwodiZgdHdv+tkz0n4gaZgK4LsZuuAa1Ut8F41j0ev7L?=
 =?us-ascii?Q?G4di0IBG9F2onrPXEv3sp63lGgmaOJTdD7K69dGH7kgslJCu8msb4UZQ35n+?=
 =?us-ascii?Q?1q75vA6fQ1DZ6yeUJWUaBm0AKM8DVuLCMrXzYtKwE6KTcOc0/dU8gpwP+3O0?=
 =?us-ascii?Q?9jeOIcnxXB3iJuSJJ1RjoOST3kPJnp7kIjGSZZ9OeScNZ69A5FNOFbWbLbyd?=
 =?us-ascii?Q?nEG9Nvpbf6UKR0UUGoJqaY1U4VlTp5B3ltRR3Ecs6vp/TuwGh8lQz9D9wNQO?=
 =?us-ascii?Q?djXBdaLS/gSiRpXjrxAMBquP45zS/4pnsKtwBOSeUnlkWMzseJsZrPtEWJ/+?=
 =?us-ascii?Q?pSCQfgy2GLiU6AcKz7tmeI+obDY/r7O2bK8ASXIirNleRjMVPa5WHnQowjyF?=
 =?us-ascii?Q?RYWCH/1n4siJhhE1TWo88NT/MYtc/aXrEdHBUKuckisawl53gnUQ7mKECbhp?=
 =?us-ascii?Q?XJJbs9LvEv6NG4Z+eoQDyyzRqMZA1+bzFdXnIS1uSPstOew06uJ6jsanPiJ2?=
 =?us-ascii?Q?IugVq7LipZR+eoE+Jc7WVV5HdnwBlGOkXAQeKS3qV9FK+M7OnVmQny6HL5eA?=
 =?us-ascii?Q?66BeTzpyrad6Cn9u2XhwQXP4F8197/DrURRONGTaKR5SP6XiKuFr0AIxdNbR?=
 =?us-ascii?Q?o5/WzCzUiKXFbtLnODhWyTzh3CKo+pmh9u47fTqAwVNKqdZocqzklnB31WOz?=
 =?us-ascii?Q?px8y/zFhc4PhtCdQ7zj2D3glPYrUoumT7eHFj4NGMSfoBILVdVHY2cceeSjS?=
 =?us-ascii?Q?UlIDKnTPmLaUFuNrFhj7oRXtaIM5QKeANzg/eRPInYX/UQx/Sk6iEKECFkYq?=
 =?us-ascii?Q?YSG3Qa9EyErf0ThsWJFOAse2TbkNxnbmooPgI5jUL7pODNFrkn1HHpYKxZG8?=
 =?us-ascii?Q?hpn/nRGy5rEY6Z/k1JG1YkKkuQl4kuE7SZr77teN6TyfAQm0XYxMShKkmG3W?=
 =?us-ascii?Q?MVJxItlHqEd6SK6mWdbUbXU3Ieh5h2VFnZkw06/yJF5sI/QdbhVs2Yjg41LO?=
 =?us-ascii?Q?b+6cyIZiaOdHwBr+WRZfPjTAoKKxnUelu8RURM9efRHq8nhn89eKyUcOOtAf?=
 =?us-ascii?Q?b2VBDZCzJ3PiePrihPnCSOyLRzaOJQRB8Kp/djS6CDsfTc34XS8+SGkmnQo5?=
 =?us-ascii?Q?tFJtBF0xQUL06B27FwGt64945OVmyHOXNJpg4bz2vAm8bESrwbsAio0+vOVR?=
 =?us-ascii?Q?xg=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a2a9db46-9a04-426e-e6c4-08dbf4ce08c3
X-MS-Exchange-CrossTenant-AuthSource: CWLP265MB5770.GBRP265.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Dec 2023 13:36:35.1928
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0d5fd8bb-e8c2-4e0a-8dd5-2c264f7140fe
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LX37Ax3Me5rNCKMDSD7en9vIoMbwV21sey8Mx9OtPr5IGV63LoMntE7m3ewud1JXNZ7NcIemNetIai/kad8sKUBtPhVsU+UTOV3L5JMb8Ck=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CWXP265MB2389
X-OriginatorOrg: imgtec.com
X-EXCLAIMER-MD-CONFIG: 15a78312-3e47-46eb-9010-2e54d84a9631
X-Proofpoint-GUID: pP7d2Pk51SyxniYPK9gY5cA_80gGjits
X-Proofpoint-ORIG-GUID: pP7d2Pk51SyxniYPK9gY5cA_80gGjits
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 04 Dec 2023 05:37:05 -0800 (PST)

Fixing the warning below due to an unused file level vtable. Removing
only this causes additional warnings for the now unused functions, so
I've removed those too.

>> drivers/gpu/drm/imagination/pvr_fw_trace.c:205:37: warning: 'pvr_fw_trace_group_mask_fops' defined but not used [-Wunused-const-variable=]
     205 | static const struct file_operations pvr_fw_trace_group_mask_fops = {
         |                                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202311302054.MVYPxFCE-lkp@intel.com/
Fixes: c98cc92ab6ce ("drm/imagination: Add firmware trace to debugfs")
Signed-off-by: Donald Robson <donald.robson@imgtec.com>
---
 drivers/gpu/drm/imagination/pvr_fw_trace.c | 44 ----------------------
 1 file changed, 44 deletions(-)

diff --git a/drivers/gpu/drm/imagination/pvr_fw_trace.c b/drivers/gpu/drm/imagination/pvr_fw_trace.c
index 87a42fb6ace6..30f41a10a0cf 100644
--- a/drivers/gpu/drm/imagination/pvr_fw_trace.c
+++ b/drivers/gpu/drm/imagination/pvr_fw_trace.c
@@ -167,50 +167,6 @@ update_logtype(struct pvr_device *pvr_dev, u32 group_mask)
 
 #if defined(CONFIG_DEBUG_FS)
 
-static int fw_trace_group_mask_show(struct seq_file *m, void *data)
-{
-	struct pvr_device *pvr_dev = m->private;
-
-	seq_printf(m, "%08x\n", pvr_dev->fw_dev.fw_trace.group_mask);
-
-	return 0;
-}
-
-static int fw_trace_group_mask_open(struct inode *inode, struct file *file)
-{
-	return single_open(file, fw_trace_group_mask_show, inode->i_private);
-}
-
-static ssize_t fw_trace_group_mask_write(struct file *file, const char __user *ubuf, size_t len,
-					 loff_t *offp)
-{
-	struct seq_file *m = file->private_data;
-	struct pvr_device *pvr_dev = m->private;
-	u32 new_group_mask;
-	int err;
-
-	err = kstrtouint_from_user(ubuf, len, 0, &new_group_mask);
-	if (err)
-		return err;
-
-	err = update_logtype(pvr_dev, new_group_mask);
-	if (err)
-		return err;
-
-	pvr_dev->fw_dev.fw_trace.group_mask = new_group_mask;
-
-	return (ssize_t)len;
-}
-
-static const struct file_operations pvr_fw_trace_group_mask_fops = {
-	.owner = THIS_MODULE,
-	.open = fw_trace_group_mask_open,
-	.read = seq_read,
-	.write = fw_trace_group_mask_write,
-	.llseek = default_llseek,
-	.release = single_release,
-};
-
 struct pvr_fw_trace_seq_data {
 	/** @buffer: Pointer to copy of trace data. */
 	u32 *buffer;
-- 
2.25.1