Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp2710716rdb; Mon, 4 Dec 2023 05:39:33 -0800 (PST) X-Google-Smtp-Source: AGHT+IHBmYLnUW3hG5YudDz4kSoCejICrsxmYyWYe+J/TQVOQsx2irU1c1twm7hQNglunf5hISIk X-Received: by 2002:a05:6a21:789a:b0:18c:3260:e20f with SMTP id bf26-20020a056a21789a00b0018c3260e20fmr2383849pzc.33.1701697173400; Mon, 04 Dec 2023 05:39:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701697173; cv=none; d=google.com; s=arc-20160816; b=pj/5FJ6hDasYssOZuVqXYDdVzNpbc+1fIDjwdUnSqcOyVXoR+Vx/QF260bOCYJoc4+ 2E8L8jvw31DZAgJPq5b5MiZTwyc0BghF6zz51AoLQuxz26Rw0gN5G+LUuyNIZATbXjyo qUvSnWKLUIxSAkeSaVrXIhWvUc0ljuNdC8Y8bm8dJzom6qNaEUEYUCXDgrKilv6NxpW2 ijVn3bW66Vnww39RFvRLa99N8E4tGd28OYZwXyum6aCN+4dRXQUOd6AOuEDzkvjDZnSx m/CwfF5LOlU8cBeOYeay1X8yDoKlGr6/tbz1N0Ly2+1J9dEVlfqKfoVj7InP25CD8N74 BTDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Wv0cy3hplZY36Hom/Qpi7IkV4MUxMgC8hO9AMWIUkAs=; fh=HPV+/rMTDNY35l7Q/Lrz2M9QVTyRhdK+9EUmYXHagBA=; b=0gxuW/TaKx8mWsIPnLn+wn+tG3/9pDa+PT59hbM7g+7S5T/3OpZ+wqH3rA85ZhnsgI HkCbkqkO1VwgXwX/EtUF5+l5RqM5XLYEEkaRlfc+7yr+WLFultw1RIj37Xzj8iLvybKY QmZq7d5hkv1CZeEXSZt9zM1ODJCTEq1LRZ9tZe96eEWDvo7O3KTN014xskRvscgCi8T8 EEUT1vkIfOMvWhNCmMKUwRvEZIQsj4u/vrrZEZHzamTgBhkmxw6MN7FkyqNp5HLjXSwx Cu5Q1w7Ug03BWzEK07IngIxWgjK9muGjP2sCI2NgIDZd5E1FDw4BUIeFqgo4rx46RDxy O/jQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="TTu/2Mi0"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id l4-20020a656804000000b005acb92781fbsi2858008pgt.415.2023.12.04.05.39.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 05:39:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="TTu/2Mi0"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id AD0AB80A97A5; Mon, 4 Dec 2023 05:39:30 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235700AbjLDNi7 (ORCPT + 99 others); Mon, 4 Dec 2023 08:38:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235696AbjLDNi3 (ORCPT ); Mon, 4 Dec 2023 08:38:29 -0500 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED15F1985; Mon, 4 Dec 2023 05:29:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701696580; x=1733232580; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=WoWMFgig9uBFYI9AMo/dQVD9UIUxJBVY04YdMlNiXMI=; b=TTu/2Mi083EJ/MyyWeuORnhiw/hRtos2vaMm11HRZfkO4UWJtVTFLDGW 8tz7LTFbvAbDzSIRNq0+v0zpzWxKA5ixd6RtMriMGG59TAijs4O53lUvf xmJrVZOJnK4iigCyS0TKJaqyaZWBA1B4Y6TYMsgE49qFNoy2+77NfpF7t FoZpFAyZMGFtFMYbV/c1WU0MeAIzkMt1U3X8nKN+gLxJk+lC5Pg5TFtjn xQ/3MzA6VOprzK2hATeUYNVmAjd5lnNI+9ixKArV6xXS49GzJR4Gdh0KK LsErjkiV8mznDwdLxJHjh/AjosOteQXRDlhbu5fsK4UN0wpc6Mv+61Av7 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10913"; a="390890360" X-IronPort-AV: E=Sophos;i="6.04,249,1695711600"; d="scan'208";a="390890360" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Dec 2023 05:29:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10913"; a="836583187" X-IronPort-AV: E=Sophos;i="6.04,249,1695711600"; d="scan'208";a="836583187" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga008.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Dec 2023 05:29:38 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rA90x-00000001lAf-1yEw; Mon, 04 Dec 2023 15:29:35 +0200 Date: Mon, 4 Dec 2023 15:29:35 +0200 From: Andy Shevchenko To: Ilpo =?iso-8859-1?Q?J=E4rvinen?= Cc: Dawei Li , Greg Kroah-Hartman , Jiri Slaby , jszhang@kernel.org, LKML , linux-serial , set_pte_at@outlook.com, stable@kernel.org Subject: Re: [PATCH] serial: dw8250: Make DLF feature independent of ADDITIONAL_FEATURE Message-ID: References: <20231204130820.2823688-1-dawei.li@shingroup.cn> <48f6fcce-4b5-a7c0-2fc0-989b9a2fba8@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <48f6fcce-4b5-a7c0-2fc0-989b9a2fba8@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 04 Dec 2023 05:39:30 -0800 (PST) On Mon, Dec 04, 2023 at 03:20:09PM +0200, Ilpo J?rvinen wrote: > On Mon, 4 Dec 2023, Dawei Li wrote: > > > DW apb uart databook defines couples of configuration parameters of DW_apb_uart (as it's part of file name, or spell this fully). > > dw8250 IP, among which there are 2 of them: DesignWare 8250 IP ... > > The bug was hit when we are bringing up dw8250 IP on our hardware Ditto. > > platform, in which parameters are configured in such combination: > > - ADDTIONAL_FEATURE disabled; > > - FRACTIONAL_BAUD_DIVISOR_EN enabled; ... > The very same code change is already in tty-next (from another author). For your convenience: d804987153e7 ("serial: 8250_dw: Decouple DLF register check from UCV") -- With Best Regards, Andy Shevchenko