Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp2717224rdb; Mon, 4 Dec 2023 05:51:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IEVAcBvXnaqRiLI6pvzSgD6G6hU8TmVp4OBcOTEsmLq525NRo4+99ZpT7ozfoPgE8Vn9Fha X-Received: by 2002:a17:90a:6c43:b0:286:6cc1:271 with SMTP id x61-20020a17090a6c4300b002866cc10271mr1411326pjj.60.1701697916405; Mon, 04 Dec 2023 05:51:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701697916; cv=none; d=google.com; s=arc-20160816; b=L1G7bh7PbTS6UnPFh8fZfruPA5GE76YmMSa9E8dTH/hJKFROrgK9zgRuPnTV5Us6AV YzFdqf9sB5ASmurmhd2FlJ6aYLu9r2oiQmDIFkxM1SAKmnzx5FCJ3dUjSNc3dR0gbmqv 9203Dm8sy8q689bYlOzbJdHlr+xwZhHPETl9QpGdMn+Ctptk5oQelvJzXUfb3EYi3lNg DstX7HHqVhbAdwxb1aFDP/YebbdXq9mDaMvZdGBa6zgTBkS57Fvf5KnvDHaciuIS6vgh gpeIRgffsca/4IFTqDEFVTq3eOCiG7DSz0hNeYJ3fTD1RJ6K6fiXCkIsLmJgMkfthrU2 r6Jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=72X5Wx7LJbQTbyf33h850yY8f/1o2sQBGfw5DIxl4Xg=; fh=vX/7SZptA+2eeJwl0U40eCIPalCcAe3G7v05A+ZoRAA=; b=lzCCyyXGuMVCfGwTtYXyhl4TYX2p7A1tjFAQVHK8qunEuD9oI55bWcgSFS80WVShul U7JK6hLIJhUOPc3a8Bw4rP5BAJ82wxNSXNoqvM2aAYVpH+jUpr3tc36zOiOlHcG3ETXa 5UX1mMs/D2jVcq3MB0nzEZFyv4xnzl93yNDESyNn5DajdN+jJhu64EQgD4rftbZ+rzNz W8FkUZmGt7sSuB77jFTyTiEAv7EA7tExbKEwqLNDJL8m6/HKHbnUs+zCw5R/8G0RhEJg mjtOO6F1vM4btVZ+6VXI6VrKqhYBVLvI5mj4dntkvpoTUHMNVuTOmeuSX5oivnIp9Bmt PdgA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Q2tHwSN+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id h20-20020a17090ac39400b002869bbcf386si2263849pjt.93.2023.12.04.05.51.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 05:51:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Q2tHwSN+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 7F7488041185; Mon, 4 Dec 2023 05:51:49 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344722AbjLDNux (ORCPT + 99 others); Mon, 4 Dec 2023 08:50:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344854AbjLDNup (ORCPT ); Mon, 4 Dec 2023 08:50:45 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC0FD135 for ; Mon, 4 Dec 2023 05:50:50 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 74557C433C8; Mon, 4 Dec 2023 13:50:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701697850; bh=fsFu1k8Z5gwLxuCeGp27lPUgeerquZ+RKi0ABLqEljs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Q2tHwSN+wWn8UHYIA69m57D3iBC71gI5x8Pv1eEK43/eRjSFxlbPoyD96+QOH3oGd x0LHblC+pDkyrDJ06GPEDjlIzjTw8HTzxBPea4TaBkEJ1upSxdo2wAv84q/rhRsPF8 RRivfL7Ve0W169YUbouf4mIY5DrAzJWybYfAcxcdwijnICYE/rgVBKrsrF6GAsnDHI Yvvw+hrRMEvvuaQqmxv0KRC8srVVRKcH5b8J21JPPoO5PuQrS7ZQIaZTnS7Y6hm0SD BQz75iDt5+3JDe9ltkNe8mM4LB7mbQhhOtoaMktj5RGBnR4ysL2fyixFtsz3C1SLVQ 7lD++6S6e3Tbg== Received: from johan by xi.lan with local (Exim 4.96.2) (envelope-from ) id 1rA9MB-0003Ud-0P; Mon, 04 Dec 2023 14:51:31 +0100 Date: Mon, 4 Dec 2023 14:51:31 +0100 From: Johan Hovold To: srinivas.kandagatla@linaro.org Cc: broonie@kernel.org, alsa-devel@alsa-project.org, perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, johan+linaro@kernel.org Subject: Re: [PATCH 1/2] ASoC: ops: add correct range check for limiting volume Message-ID: References: <20231204124736.132185-1-srinivas.kandagatla@linaro.org> <20231204124736.132185-2-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231204124736.132185-2-srinivas.kandagatla@linaro.org> X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 04 Dec 2023 05:51:50 -0800 (PST) On Mon, Dec 04, 2023 at 12:47:35PM +0000, srinivas.kandagatla@linaro.org wrote: > From: Srinivas Kandagatla > > Volume can have ranges that start with negative values, ex: -84dB to > +40dB. Apply correct range check in snd_soc_limit_volume before setting > the platform_max. Without this patch, for example setting a 0dB limit on > a volume range of -84dB to +40dB would fail. > > Signed-off-by: Srinivas Kandagatla Seems to work as intended with the following patch on the X13s: Tested-by: Johan Hovold Reviewed-by: Johan Hovold Should you add a Fixes and CC-stable tag so we can get this backported (at least to 6.5 for the X13s)? Johan