Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp2718095rdb; Mon, 4 Dec 2023 05:53:38 -0800 (PST) X-Google-Smtp-Source: AGHT+IHQYFCUvdCvL8JmnwyMOe1pbUuaR4yqNOUM5g8X7TEot7azcysszSBCOqhq2fnqIsEXfay1 X-Received: by 2002:a17:903:1c5:b0:1cf:d660:5b01 with SMTP id e5-20020a17090301c500b001cfd6605b01mr1534596plh.27.1701698018127; Mon, 04 Dec 2023 05:53:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701698018; cv=none; d=google.com; s=arc-20160816; b=fsKUZvu+/MG9rzZW30EBM/9gyeXdnEGP09hKczbUtzlCHQqBGnR9g/+g2UlNCkSQOF kwj6lGvwa0oEesjHf2Tvm+3q/JTJPA8pF6p+K+N0IiT6rjWoUwQ2Sig2sIWzNxweYUZC iSUDyRFqfat+z+MEPST2qRW9hwR+pW4omsIcW60ZBdawIL3E9bH7E4YuHpW7exb9cCwa hEtmaSlqTP66YKqE+aV31/PTgIaw0VfYh///X4H+xAW/EW5rdg7lOW8Uc1oHgHscCDRJ msjZD1geQElIdPuhCvtCjyTUyQrDfEOvmjYu1hqybTUc2JuL3jv6vmnr7AxeU5mJivut WH6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=0t/y4leT8yBh8F49CZ0qXZ6x3OUUJzrUej7Z6rJvgxo=; fh=vX/7SZptA+2eeJwl0U40eCIPalCcAe3G7v05A+ZoRAA=; b=s4KbtAuJ5zLgf2xfKk2tL/Jhm4sdH/C87r/DE8CmNpleE0hU8wDw2K7/t6QMI4hGwt aeTLYRrwjaXFpzIKGOGf4JXCfRI+HpwAXRurzCRneIFshy9m0fqZ0c91aX2PpwPQpKfw tEtqJnUv3Bnen2iDc7Ul4oFOYloZflk2iFrMAsrC+iNCUpR+KvO11W/6YnovRSzRyZF1 0LAUEx3J1WouP7W9UEBrgtwQX38QWdZ+BN1aVbg01oczdvt28a2VifxbCqJCJKlLzJtz i875dO34ADFMqlnzbLQmLAQfDBTaeki6W9qRcKFIY7Dj2MCRd7xqNwPvdHMUSYbOdZk1 MpQA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=S7jPfNYo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id j5-20020a170902690500b001cf7c82c00asi7879157plk.499.2023.12.04.05.53.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 05:53:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=S7jPfNYo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id A58848061416; Mon, 4 Dec 2023 05:53:35 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344537AbjLDNxS (ORCPT + 99 others); Mon, 4 Dec 2023 08:53:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344599AbjLDNxP (ORCPT ); Mon, 4 Dec 2023 08:53:15 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1EE1BD5 for ; Mon, 4 Dec 2023 05:53:20 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B81ACC433C8; Mon, 4 Dec 2023 13:53:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701697999; bh=esHuCLsnYzWLmm5Oa6L+Kmza70Ps3RCO18AT+iUJYoM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=S7jPfNYoSehiFCVmvkeB3YWHBnjgSiFuETLq9dY1RH90k0MXl6dSB376aJQmxz/SJ QRqiBrCPDEv1NNNLFRdNyVkjtcdqEqUL/zpg/AxF++c9EonLkx58tZ+UvojQSP6YXE 62SIy3Jbw8gCBjUohCYs20csnvEtT+ev3iQwuumVREZmjFQv/HL4+Z6/ikawOUcHaD JW0zXl6b3XoZFkJE+nF3JlC2xpaEMk9MhOOQFq4Dz0q2tgyz7G4hyemrsz9elc7pyY lVqrA/RCi1ut+Rh8FCFmoevezMjQhYb7V/4hj5lL35IcaU/LhMTlMSJYbRWuEnne3T MMAeJQzpMoK1A== Received: from johan by xi.lan with local (Exim 4.96.2) (envelope-from ) id 1rA9Ob-0003VA-1F; Mon, 04 Dec 2023 14:54:01 +0100 Date: Mon, 4 Dec 2023 14:54:01 +0100 From: Johan Hovold To: srinivas.kandagatla@linaro.org Cc: broonie@kernel.org, alsa-devel@alsa-project.org, perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, johan+linaro@kernel.org Subject: Re: [PATCH 2/2] ASoC: qcom: sc8280xp: Limit speaker digital volumes Message-ID: References: <20231204124736.132185-1-srinivas.kandagatla@linaro.org> <20231204124736.132185-3-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231204124736.132185-3-srinivas.kandagatla@linaro.org> X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 04 Dec 2023 05:53:35 -0800 (PST) On Mon, Dec 04, 2023 at 12:47:36PM +0000, srinivas.kandagatla@linaro.org wrote: > From: Srinivas Kandagatla > > Limit the speaker digital gains to 0dB so that the users will not damage them. > Currently there is a limit in UCM, but this does not stop the user form > changing the digital gains from command line. So limit this in driver > which makes the speakers more safer without active speaker protection in > place. > > Signed-off-by: Srinivas Kandagatla Works as intended: Reviewed-by: Johan Hovold Tested-by: Johan Hovold Given the reason for why you are adding this, it seems you should have added: Cc: stable@vger.kernel.org # 6.5 as well. Johan