Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Date:   Mon, 4 Dec 2023 14:55:39 +0100
From:   Maxime Ripard <mripard@kernel.org>
To:     Donald Robson <donald.robson@imgtec.com>
Cc:     dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        frank.binns@imgtec.com, matt.coster@imgtec.com,
        maarten.lankhorst@linux.intel.com, tzimmermann@suse.de,
        airlied@gmail.com, daniel@ffwll.ch,
        kernel test robot <lkp@intel.com>
Subject: Re: [PATCH 1/2] drm/imagination: Removed unused functions in
 pvr_fw_trace
Message-ID: <7rwnnzsh6mlfnp5nqsxlehtc7siznebppixap7lh56kkr274jo@wtilprrqiuw4>
References: <20231204133611.53913-1-donald.robson@imgtec.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="ywz7mwoosg3s7mrw"
Content-Disposition: inline
In-Reply-To: <20231204133611.53913-1-donald.robson@imgtec.com>
Precedence: bulk


--ywz7mwoosg3s7mrw
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Mon, Dec 04, 2023 at 01:36:11PM +0000, Donald Robson wrote:
> Fixing the warning below due to an unused file level vtable. Removing
> only this causes additional warnings for the now unused functions, so
> I've removed those too.
>=20
> >> drivers/gpu/drm/imagination/pvr_fw_trace.c:205:37: warning: 'pvr_fw_tr=
ace_group_mask_fops' defined but not used [-Wunused-const-variable=3D]
>      205 | static const struct file_operations pvr_fw_trace_group_mask_fo=
ps =3D {
>          |                                     ^~~~~~~~~~~~~~~~~~~~~~~~~~=
~~
>=20
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202311302054.MVYPxFCE-lkp@i=
ntel.com/
> Fixes: c98cc92ab6ce ("drm/imagination: Add firmware trace to debugfs")

That commit doesn't exist (upstream).

You made that mistake on the 5 patches you sent last week too but I
forgot to tell you about it. Are you working from a private branch?

Maxime

--ywz7mwoosg3s7mrw
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCZW3aVgAKCRDj7w1vZxhR
xSPgAP9erofg/RVkKD6Ziz2dMHCcsc0gXGrd4hdAvP82eS74UwEA373CvQO6UY9S
Ckpcx+NprA48bphjtNrUQ2gzOIhevwI=
=wEwQ
-----END PGP SIGNATURE-----

--ywz7mwoosg3s7mrw--