Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Date:   Mon, 4 Dec 2023 10:36:50 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Borislav Petkov <bp@alien8.de>
Cc:     ankita@nvidia.com, alex.williamson@redhat.com,
        naoya.horiguchi@nec.com, akpm@linux-foundation.org,
        tony.luck@intel.com, linmiaohe@huawei.com, rafael@kernel.org,
        lenb@kernel.org, james.morse@arm.com, shiju.jose@huawei.com,
        bhelgaas@google.com, pabeni@redhat.com, yishaih@nvidia.com,
        shameerali.kolothum.thodi@huawei.com, kevin.tian@intel.com,
        aniketa@nvidia.com, cjia@nvidia.com, kwankhede@nvidia.com,
        targupta@nvidia.com, vsethi@nvidia.com, acurrid@nvidia.com,
        apopple@nvidia.com, anuaggarwal@nvidia.com, jhubbard@nvidia.com,
        danw@nvidia.com, mochs@nvidia.com, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-mm@kvack.org, linux-edac@vger.kernel.org,
        linux-acpi@vger.kernel.org
Subject: Re: [PATCH v2 3/4] mm: Change ghes code to allow poison of
 non-struct pfn
Message-ID: <20231204143650.GB1493156@nvidia.com>
References: <20231123003513.24292-1-ankita@nvidia.com>
 <20231123003513.24292-4-ankita@nvidia.com>
 <20231202232319.GAZWu8Z6gsLp1kI5Dw@fat_crate.local>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231202232319.GAZWu8Z6gsLp1kI5Dw@fat_crate.local>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8XTRJ0y5qOe8OVBCwqk8Ag92yJj36qBdidDhEXh8PTOAKipZjZmUk7bw53tJ?=
 =?us-ascii?Q?1wItBiX9hBPVcuQccbTQDE9NebRmb12Po/FxwZYVJ5glmM+2aPkLMcdUMX5C?=
 =?us-ascii?Q?kegfA5IknuAGvipJVeyqjKzJAMNjzsrKp/OC1UpvB595dhLtRTqseU3sX7hC?=
 =?us-ascii?Q?kdqybMb+cWbduvkV3FV4lOaw5CaCOzq9+w84bwIJshx8G4CiV2yHlZQK0sHh?=
 =?us-ascii?Q?T6XHn97vJO15cCzljdcMSk+ukx8rQE/U4vOcC5RbBPeVEqdeU0R+qVlHo08n?=
 =?us-ascii?Q?MmqAYpoGmjHvXsahvyqnq6vgWGDzAkiBzBVrQ3Mvui+KlI19DEScEAD6mkyC?=
 =?us-ascii?Q?kr/Sp0TSXslAOLnX6wOxTHXnXbWCCeB4zNci/3dWQmkdYDfoLK1WclIuCCio?=
 =?us-ascii?Q?ant7MS/hwLAinZ3I3eUFTItnwfvOZWNdBALPnNaJ2E2KA0KLow+WYwBYopqI?=
 =?us-ascii?Q?VM9utvDS3okVtaoEY1sFe33f8oL0VRA7UwecErnruYUEuGBB9iiiAmlboE7o?=
 =?us-ascii?Q?EwgoWgPvSZVpNPkVikhMV5xfqTka5OO9OSe9lk8hKa7mAmpihJGfTzPuE3kI?=
 =?us-ascii?Q?kFaIHx9zkGpgXacitg0YIM9TF608x8F69+v/65esG5x3Sz4Hx9StL+4NjWws?=
 =?us-ascii?Q?IX2tPd0yNBYPKW3ExDCGPS7WnCvn3vJe5/us6GvINblBMjq0qqCdi5tOY9/U?=
 =?us-ascii?Q?213JFZF5Ur4ZF7H7etsKgqi52VlU0LroshGQYJ/pugHbfdh3koLOP1pI2Ybz?=
 =?us-ascii?Q?nTXIQTirg7lMDqjKLJWyRYpuF47ikbIuBUIMY36pzNKPk71olk6h9JGDHUGB?=
 =?us-ascii?Q?SdNwjeAAJ/lBU2gepCaBGoRXEaeZWW+LaTluS/o/tG1Ha6ln/wxTX8g7dbWb?=
 =?us-ascii?Q?rffjCe8/++sxgCZEllnXd5oGtXZ0NLz7FLD8zZlqJIhA5hnqiAwNUfp6hXnP?=
 =?us-ascii?Q?LBo5Hz+wNBbwUjdr2E5L+CdQIJOKtmlnhhn9dmEOfbxqoYH/l68axL/7s5x6?=
 =?us-ascii?Q?TVMwGmOBEZ7BbE8xQsqOBhqkSabVC0wvh/E8U9fZGF/4jWvQH0U2jht6cyWt?=
 =?us-ascii?Q?R0HuzGjt+ZyD9p9vlqLx84ZcgNRgox+Ro6+eJpx+Mr/Hoes5/Qa6VjlfOFof?=
 =?us-ascii?Q?u0U1wPPoWNegYHKudVBO8OD0MLnkoDOlmUDkm9k5ObwB+dlGHpYWTAVPO8aE?=
 =?us-ascii?Q?eKltx7yE7YHEWZPqEV2UIdCvoh3tqF9hgYbp/VK2a9VSdK70dZ2+/Z0c2n9h?=
 =?us-ascii?Q?WHcdDT/mHGVaWUwH7oO2W+6n48e13x18dDjtPEv/X0z//f+8MXYvx5aqNsWp?=
 =?us-ascii?Q?vsA+owenTC7QsOAHQTTH9HUXi6/WeulMewTsF1gf9PicjGFibTOZnzDGip6X?=
 =?us-ascii?Q?H+GNYk0obqsKxiKw0X7eMBuWUDv5ttIXp71jwvtzjkm+3ZMHAZpD0rnsz13u?=
 =?us-ascii?Q?FJTgkduhyhyIH3ujYkl9eiuHVPcBu6p/vpEacL3Iux7X76T2V5KVGsHunhI/?=
 =?us-ascii?Q?gvQW7d8Rgq/kyhX/03YYwILqv3337ubA06Ovg48Rmi7X+eSVGh0jQWOZ9Dec?=
 =?us-ascii?Q?CGxNFCOhn3Aj0YSU5mDxJTlZQDNcZ3MOHpCnvLY0?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8f5076a9-00ba-45f2-9a27-08dbf4d673f8
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Dec 2023 14:36:51.1206
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +EI32Z4t7c+rBB+jcvB3z6Yjfbr+bCHqGdpequP2Co8hjITionB9JvE+uICnAobR
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5110
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 04 Dec 2023 06:37:23 -0800 (PST)

On Sun, Dec 03, 2023 at 12:23:19AM +0100, Borislav Petkov wrote:
> On Thu, Nov 23, 2023 at 06:05:11AM +0530, ankita@nvidia.com wrote:
> > -	pfn = PHYS_PFN(physical_addr);
> > -	if (!pfn_valid(pfn) && !arch_is_platform_page(physical_addr)) {
> > -		pr_warn_ratelimited(FW_WARN GHES_PFX
> > -		"Invalid address in generic error data: %#llx\n",
> > -		physical_addr);
> > -		return false;
> > -	}
> 
> You don't just remove a pfn valid test just because your weird device
> can't stomach it - you extend it, like

It wasn't removed. patch 1 moved it to memory_failure() where it makes
a lot more sense.

Jason