Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Message-ID: <7f9fffe3-2fb8-41a2-9eb0-4adf91566a21@huawei.com>
Date:   Mon, 4 Dec 2023 22:43:44 +0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
CC:     <shaojijie@huawei.com>, <shenjian15@huawei.com>,
        <wangjie125@huawei.com>, <liuyonglong@huawei.com>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2 net 2/2] net: hns: fix fake link up on xge port
To:     Wojciech Drewek <wojciech.drewek@intel.com>,
        <yisen.zhuang@huawei.com>, <salil.mehta@huawei.com>,
        <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>
References: <20231204011051.4055031-1-shaojijie@huawei.com>
 <20231204011051.4055031-3-shaojijie@huawei.com>
 <c382dc51-3a3c-4c79-90c0-13e2e716d0a9@intel.com>
From:   Jijie Shao <shaojijie@huawei.com>
In-Reply-To: <c382dc51-3a3c-4c79-90c0-13e2e716d0a9@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


on 2023/12/4 18:19, Wojciech Drewek wrote:
>
> On 04.12.2023 02:10, Jijie Shao wrote:
>>   
>> +static void hns_mac_link_anti_shake(struct mac_driver *mac_ctrl_drv,
>> +				    u32 *link_status)
>> +{
> It would be cleaner to return the link status than using output arg IMO
>
Yes, it's a good suggestion, and this is modified in v3