Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Date:   Mon, 4 Dec 2023 14:53:39 +0000
From:   Carlos Llamas <cmllamas@google.com>
To:     Alice Ryhl <aliceryhl@google.com>
Cc:     arve@android.com, brauner@kernel.org, gregkh@linuxfoundation.org,
        joel@joelfernandes.org, kernel-team@android.com,
        linux-kernel@vger.kernel.org, maco@android.com, surenb@google.com,
        tkjos@android.com
Subject: Re: [PATCH v2 23/28] binder: document the final page calculation
Message-ID: <ZW3n8w7L5ZJ_mlFK@google.com>
References: <20231201172212.1813387-24-cmllamas@google.com>
 <20231204115727.42370-1-aliceryhl@google.com>
 <ZW3kjj6KC73zpnw4@google.com>
 <CAH5fLgjmN4xYHZc=ZVdwOMMTEk4PwXwnqvXWSJrE1J-2xaKL7g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAH5fLgjmN4xYHZc=ZVdwOMMTEk4PwXwnqvXWSJrE1J-2xaKL7g@mail.gmail.com>
Precedence: bulk

On Mon, Dec 04, 2023 at 03:43:54PM +0100, Alice Ryhl wrote:
> You could also just remove the `next_used_page` part entirely. This
> means that you will sometimes call `binder_lru_freelist_del` on a page
> that's in use, but that's just a no-op.

Yes, that is right and I did look into this. The WARN_ON(!on_lru) checks
are a bit confusing when it's a no-op as you mention. The purpose though
is to assert the "algorithm" of add/del pages from the lru is somewhat
correct (particularly the page range).

--
Carlos Llamas