Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp2760196rdb; Mon, 4 Dec 2023 06:57:10 -0800 (PST) X-Google-Smtp-Source: AGHT+IGtldsjrmKbXJ9KtgwdrvzqysuJzmAt7jSlkjx/dfia+66A2uebFAZMJe4mO+kiVplJWx+Z X-Received: by 2002:a05:6a20:9153:b0:18f:97c:6161 with SMTP id x19-20020a056a20915300b0018f097c6161mr5633969pzc.94.1701701830514; Mon, 04 Dec 2023 06:57:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701701830; cv=none; d=google.com; s=arc-20160816; b=PsDMvaBbBeKpQ7sDMemdztgbL+xr0Ha3VYl3ALWz7FTzn0xoaozKgEmir9VaBJkArL WoT0+VicgrpQ2N93dyga09oMHHK3aoUbidY5nLhQiCPCYPP4zi6K0JuPN0c0ODPAc+IB KFBbpc06N9tA0Itdhd88BbOe7fQLXRoZ1xg3qXLljJo24qfZ2GhsnrSiQmaFPLngZPFf kiYyQrG1fhNiBnLGvJgQBI3Gm8KIOOWzAsFUcBf6Znfl+BqjTK5XinARJ6PnaKOsPDxS 4CTazQW9G85STMTaz7zUNMQvTIVsIAZvkChecVFHf0uU0C8AHgn1VH/WaWhXm4lIEm3h 3FaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:dkim-signature; bh=kRCtstHEKF0Pojy00GltFVIfI9uWZ2LjfoKa32WYfuY=; fh=E8x67n2wuYWVpdHgyKnpye61tpCTJAPGcYI+/PBtvFg=; b=xHYE72PHD0QaYyTx1Dq1qSBEUCetnsmI2GHHTs/9eM8qK9wsUrn0tS6vew+DwPi/zK Sra/1Tlqkq0UG4uXFet3JzBTnldCwDd9woQ67Mhu82B3sh8CxpOpkEYQOkmhkp/7DWPY D1Nt8762jbiVG8ymZYwLZEtamVquqosOTxBcCsHZyPC6G5tTvlNGev76bGt11IYxChVM dSRy3G5LhmwgJWjeqBsbfpFtZXko7o4jug6yPuNQyJyQ4Q9ZhSseD5LqWcP4+1640Z9d SN1q9BF1Az03LGBpdlryHq5cfBm3cBk10nCBOOIGs2icP0fXc3ET5AFcL62Pc/aMkvpL /yPQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=LOxvFvht; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id n22-20020a63ee56000000b005c6125b1731si4000022pgk.547.2023.12.04.06.57.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 06:57:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=LOxvFvht; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 1BF57804F605; Mon, 4 Dec 2023 06:57:06 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233512AbjLDO4u (ORCPT + 99 others); Mon, 4 Dec 2023 09:56:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235705AbjLDNzs (ORCPT ); Mon, 4 Dec 2023 08:55:48 -0500 Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::228]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 29CECD8; Mon, 4 Dec 2023 05:55:52 -0800 (PST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 36AEE1BF215; Mon, 4 Dec 2023 13:55:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1701698151; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kRCtstHEKF0Pojy00GltFVIfI9uWZ2LjfoKa32WYfuY=; b=LOxvFvht3eA9pfgnVIlTiinjgEWJ/qLzOyOC/LMtV117eJ7zXLfSiZ4jCOxf18Yx51l9wL TTpSn7EWmh7/wCSPbn0ualoFVbUO3dgLTLrkG3YhLmIVyIGqkwwwbwlL7PZn0vKDoYPYqz izOA8I0jqC5qIU4tFydzdfO2ndA9I2BUT9AiPJvJRtiJeGMNi5wQVKJRhyjqSnwrOC+gyw Dh5DuHHZdw1JP4E/9YaQ3MNntKogWLyY5D4oxUqauygoiGor5lVO8E5BzOsp6rIUFv3N6m UvcNsnRG97sQqVUPS7FoCH8EozzqeiwZW7CKzeqnt/KtOZQK32SsYLZi8eBMSA== Date: Mon, 4 Dec 2023 14:55:48 +0100 From: =?UTF-8?B?S8O2cnk=?= Maincent To: Oleksij Rempel Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jonathan Corbet , Luis Chamberlain , Russ Weight , Greg Kroah-Hartman , "Rafael J. Wysocki" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thomas Petazzoni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, devicetree@vger.kernel.org, Dent Project Subject: Re: [PATCH net-next v2 3/8] net: pse-pd: Introduce PSE types enumeration Message-ID: <20231204145548.37f7a06d@kmaincent-XPS-13-7390> In-Reply-To: <20231204125131.GE981228@pengutronix.de> References: <20231201-feature_poe-v2-0-56d8cac607fa@bootlin.com> <20231201-feature_poe-v2-3-56d8cac607fa@bootlin.com> <20231204125131.GE981228@pengutronix.de> Organization: bootlin X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: kory.maincent@bootlin.com X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 04 Dec 2023 06:57:06 -0800 (PST) Thanks for your review! On Mon, 4 Dec 2023 13:51:31 +0100 Oleksij Rempel wrote: > On Fri, Dec 01, 2023 at 06:10:25PM +0100, Kory Maincent wrote: > > +u32 pse_get_types(struct pse_control *psec); =20 >=20 > I would add here some helper function. Something like: > pse_has_podl() or pse_has_c33() Instead of pse_get_types function? It is indeed maybe cleaner to use such helper functions instead. Regards, --=20 K=C3=B6ry Maincent, Bootlin Embedded Linux and kernel engineering https://bootlin.com