Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp2760256rdb; Mon, 4 Dec 2023 06:57:16 -0800 (PST) X-Google-Smtp-Source: AGHT+IEvQeZxy+XWez9hOK30wZbsA9gSJhyy1KRhayjykHhAfOTZjHZ502WgCDfChj8AJJQqN1lc X-Received: by 2002:a05:6a20:1591:b0:18d:c72:63b3 with SMTP id h17-20020a056a20159100b0018d0c7263b3mr5718434pzj.16.1701701835410; Mon, 04 Dec 2023 06:57:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701701835; cv=none; d=google.com; s=arc-20160816; b=Uh8CO3ionGxlf01SruIYjcIsFEo0lV8gGChXx97GJZ31TT2v50ziJBvwIcQDF84aOo 3Tv6NFYMx1dxLztoOOrSP+fC4m5DEDVdyr/GBiD5r427Imo8PkMrxYSxEryqs/ZpASDA GjoHN5yNM2ZgyQvS1FSfQj1PKbaj2oauUtJgXqQZ2Q8FU0LwD82qVyGyMAMOWSZfk6oj UADrjP8NDqgEJYDPMFtb59+T8AkycFY7HEcRozIESULPUeiQGyEssGyrHyNk1X4zFlR7 kl+41G8Z6bkUtETuLMLAf0B0IDb0mqfZ4QZYlMNlPPvHovV4UB9Iyw0OXXA/lf6D4Ano YjOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=veurVNi6s6aoa+f1h1oB8b9G9+kFGgAmw5qlxaQt2EI=; fh=AJvajGurJww4MIiKHtF6oSDbh02msZyVL2eyE+ODfEQ=; b=kjp2Qg3LswRU9rtxliw5VH/AaDJUv5PtCQRwtOG09bXIPItqtFn0gjfnavWGMwFtjK ylDQxI9/cd2IkgdMyVXoxuzvg44gd+Kv5zM5q17T9Ve80rTf8ryljJRnXRkPlmQTmFqg 7d1XuJVm9Nr3OvtcY6h8UkAkfI2SDaDslElXsHWaGKCKVQXiWHfiQyKy/RB9zBzogGkJ EwCif8nGGYzM4zoq+nJDhgGQ4OOplTr0tNiEAZdReZA8XO/1UwVj5nhqz+GBRGCkrZvQ N0GQrwt6CB0kSSmeOGG77H3YAj5/wWmJ6H4BB8cV3KoZKtBUGT/gKreZ80sBhB85TE2S 08yw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=f7AymoDN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id j22-20020a056a00235600b006cdecb69c69si7707599pfj.87.2023.12.04.06.57.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 06:57:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=f7AymoDN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 04D3380AE561; Mon, 4 Dec 2023 06:57:04 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235641AbjLDNZ7 (ORCPT + 99 others); Mon, 4 Dec 2023 08:25:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40550 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344595AbjLDNYt (ORCPT ); Mon, 4 Dec 2023 08:24:49 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0CD2719A4; Mon, 4 Dec 2023 05:24:23 -0800 (PST) Received: from benjamin-XPS-13-9310.. (ec2-34-240-57-77.eu-west-1.compute.amazonaws.com [34.240.57.77]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: benjamin.gaignard) by madras.collabora.co.uk (Postfix) with ESMTPSA id 19C1C660711D; Mon, 4 Dec 2023 13:24:22 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1701696262; bh=Gl50yamOqxp5F3J61bdrX38ELoxqbgPRLIk274ynKbw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=f7AymoDN23peeo2rYK+6KBvHLhLevEnsznJewdctG2+XbxaZqVFAotigw//kcWyeL 0/yS9hdKsu8JlMHkZ48H6r22r5ftYMnRpd9yo6OAq02BPB8bEg4w5Eu3R1kq3g+FCX Cl2cfj8wftNOLQSM5Gk/Rknxfeg/SuoH+xUr3+0OVDpaloGrFqo0Z6oyDVA8S/Quzr /jEejnMap3aV9zOb04kFrMuMWSk9j6SwwrJ70/ZfucGS4taGygNhCYAUVm5ZKqwHBd Me8/GJU6+c2Jpgq4Whw6bxOGbcbr9ZswbeULXElhiFk+pwpJ72KU867vQIkSDbu1xf XAMJB4rlRNaiQ== From: Benjamin Gaignard To: hverkuil@xs4all.nl, mchehab@kernel.org, tfiga@chromium.org, m.szyprowski@samsung.com, matt.ranostay@konsulko.com Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, kernel@collabora.com, Benjamin Gaignard , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland Subject: [PATCH v2 29/36] media: sunxi: sun6i-csi: Fix misuse of min_buffers_needed field Date: Mon, 4 Dec 2023 14:23:16 +0100 Message-Id: <20231204132323.22811-30-benjamin.gaignard@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231204132323.22811-1-benjamin.gaignard@collabora.com> References: <20231204132323.22811-1-benjamin.gaignard@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 04 Dec 2023 06:57:04 -0800 (PST) 'min_buffers_needed' is suppose to be used to indicate the number of buffers needed by DMA engine to start streaming. sun6i-csi driver doesn't use DMA engine and just want to specify the minimum number of buffers to allocate when calling VIDIOC_REQBUFS. That 'min_reqbufs_allocation' field purpose so use it. Signed-off-by: Benjamin Gaignard CC: Chen-Yu Tsai CC: Jernej Skrabec CC: Samuel Holland --- drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_capture.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_capture.c b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_capture.c index cf6aadbc130b..73e721936d27 100644 --- a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_capture.c +++ b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_capture.c @@ -1010,7 +1010,7 @@ int sun6i_csi_capture_setup(struct sun6i_csi_device *csi_dev) queue->buf_struct_size = sizeof(struct sun6i_csi_buffer); queue->ops = &sun6i_csi_capture_queue_ops; queue->mem_ops = &vb2_dma_contig_memops; - queue->min_buffers_needed = 2; + queue->min_reqbufs_allocation = 2; queue->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC; queue->lock = &capture->lock; queue->dev = csi_dev->dev; -- 2.39.2