Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Date:   Mon, 4 Dec 2023 11:09:00 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Yan Zhao <yan.y.zhao@intel.com>
Cc:     iommu@lists.linux.dev, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, alex.williamson@redhat.com,
        pbonzini@redhat.com, seanjc@google.com, joro@8bytes.org,
        will@kernel.org, robin.murphy@arm.com, kevin.tian@intel.com,
        baolu.lu@linux.intel.com, dwmw2@infradead.org, yi.l.liu@intel.com
Subject: Re: [RFC PATCH 10/42] iommu: Add new iommu op to create domains
 managed by KVM
Message-ID: <20231204150900.GE1493156@nvidia.com>
References: <20231202091211.13376-1-yan.y.zhao@intel.com>
 <20231202092007.14026-1-yan.y.zhao@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231202092007.14026-1-yan.y.zhao@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?SU5sVgN8hDMvuVhkLnqqkXcHGzCSZ4/ECqiZbbMto5re8TAHv3OAZ8IeXO5/?=
 =?us-ascii?Q?LEfSR7qDwbhwbC4HyCqw25+1xSV9457EEL2kWbKaVPcO8cYmyt7PSMRzPXKd?=
 =?us-ascii?Q?7Oxo6mrY5+FdwH0CHgzsJqdnqZEeryeXKnt51R+eGDpFNbtssJR2yxKppOH6?=
 =?us-ascii?Q?9UFxR5by7Z0uwqkkZylR0pLI8PWX+B+KI3MLQ29y2FsPS5V9Txle4xQtQKqy?=
 =?us-ascii?Q?T3VwGwAsMnyoA5c6MclRzv2TfbZRVeEtc8OmVg0MmXzLbyAUVpIA1K5iAjFy?=
 =?us-ascii?Q?MjQs2MbwSdY9ctvOy/zlf6dkATt5nm+vYU4BtL8qAHfdEE32SWWMVt2nO990?=
 =?us-ascii?Q?nmsjb2QWJSZ5915fFp5l8IetP0qZyEimtUXrD/JI/2l92jlOJFRi8O1XApbx?=
 =?us-ascii?Q?LoXRPGwdmp0+xm/OUsFlcQYoayswDXGHmtlrBDEK9/vqJ1iXmrrE6zOdMSCw?=
 =?us-ascii?Q?C2wJk1GR30/khfsvF77+hLyuuRR38j50Nbw2FMdrUgJCyE69H3IT9wTG+CDJ?=
 =?us-ascii?Q?1tk/hNuikHNPSc2WQWRDFY0VBASc3kBsGy30kiAmcCTzsA7KSNF2U/feKT7p?=
 =?us-ascii?Q?UAzy19APQPpiVAd3LkyPaOvc37ecLzkiOATWYf2yDh8kne3C3GWLwwomzokq?=
 =?us-ascii?Q?bad27Kl7ezMjQ6uhy2OcLyAzTgAY8cUK4WQNIhvP/MXgQFjcbJcRSo59wXgJ?=
 =?us-ascii?Q?YrrqZ/H8kUPeNnWNUCAT5fSjVQ+8yyNXYjL9wCRNZ884YGh+hTHVeuQfdhrV?=
 =?us-ascii?Q?KQ6y9AhoGgOYUrsZhtablF+GQMrd3Ws9JpKmoJ28tDcMgh7cV7NsjLixm95W?=
 =?us-ascii?Q?9cdhprvc017V2dPx60L653Hr00aPgHBFGMPGZ+tcfwdd3UIyjIttLJQSDw9q?=
 =?us-ascii?Q?/24f0t0FihNrQ252Kmk9uTayvXjb57b0wpRyfM4a7AuPTYigOoxSCbyWDdv6?=
 =?us-ascii?Q?mVt2HiGy0v2XA4w3iXvx+0rS//JP6V4J3ElJPtuGI6y8Tldw5AcEmkEso4sM?=
 =?us-ascii?Q?ZraKsh/vDL5MbMUiI6TwSk4dPlm71IiIQxxto0fS6HUTTlW8aQekOfoVK7Xo?=
 =?us-ascii?Q?BposisvP2kjzl/mfhsTmpIPavAeT8lAWsZv99VTMj5wPs5DPnjKvW0SuNj9v?=
 =?us-ascii?Q?H32i+znJVO/+r2judGh11/kiCliQpqi+xeZ+flYb74jbizCX1pdgID8x2rqs?=
 =?us-ascii?Q?qTQeTyiqXd2P3/56sR3Knj+iiOAk8aeNFy2EwqNfe9BOyuBszb4uu6Mv57Oz?=
 =?us-ascii?Q?GqVK72CV87EF/2548xiro5Cj0hS3Eu3VAnEDZHrs9+tjVo491mDacYehNhNu?=
 =?us-ascii?Q?v1vKVWw1UvYo70TFo4KpZsxOvfDQHJWiiU1WGw+OVc5Rme+ghinAQ6Pbm+d2?=
 =?us-ascii?Q?0X5btTMckFljm+QkpFP9Zh9myDGfPKY9E+M9IE8b1hIIrWuKIJYlkv82Ln/I?=
 =?us-ascii?Q?9y8bhN8+gCZTLGr1ATKsnlyw3Gr1TnL5yGWMWrt2RcE9GHerJyg/u6r3VtVl?=
 =?us-ascii?Q?/3cCrzPbG8roggqWazFoH9QDjl9xrK6BuKihmRIe/9btE3n7nehy/5+bhDAl?=
 =?us-ascii?Q?5lrRn8kQIB9CrOmVtFowiBuuDTq9ohn9LTEtPJtc?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 74d57da0-c71e-46b6-57b3-08dbf4daf24d
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Dec 2023 15:09:00.9432
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rJ9CN7tmalOwHjNn8XN6JLzDKVGTzDbIPRFZ4KMWayJyUcEhQfycK1WDsLKqK9fd
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7113
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 04 Dec 2023 07:09:13 -0800 (PST)

On Sat, Dec 02, 2023 at 05:20:07PM +0800, Yan Zhao wrote:
> @@ -522,6 +522,13 @@ __iommu_copy_struct_from_user_array(void *dst_data,
>   * @domain_alloc_paging: Allocate an iommu_domain that can be used for
>   *                       UNMANAGED, DMA, and DMA_FQ domain types.
>   * @domain_alloc_sva: Allocate an iommu_domain for Shared Virtual Addressing.
> + * @domain_alloc_kvm: Allocate an iommu domain with type IOMMU_DOMAIN_KVM.
> + *                    It's called by IOMMUFD and must fully initialize the new
> + *                    domain before return.
> + *                    The @data is of type "const void *" whose format is defined
> + *                    in kvm arch specific header "asm/kvm_exported_tdp.h".
> + *                    Unpon success, domain of type IOMMU_DOMAIN_KVM is returned.
> + *                    Upon failure, ERR_PTR is returned.
>   * @probe_device: Add device to iommu driver handling
>   * @release_device: Remove device from iommu driver handling
>   * @probe_finalize: Do final setup work after the device is added to an IOMMU
> @@ -564,6 +571,8 @@ struct iommu_ops {
>  	struct iommu_domain *(*domain_alloc_paging)(struct device *dev);
>  	struct iommu_domain *(*domain_alloc_sva)(struct device *dev,
>  						 struct mm_struct *mm);
> +	struct iommu_domain *(*domain_alloc_kvm)(struct device *dev, u32 flags,
> +						 const void *data);

This should pass in some kvm related struct here, it should not be
buried in data

Jason