Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Date:   Mon, 4 Dec 2023 11:09:45 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Yan Zhao <yan.y.zhao@intel.com>
Cc:     iommu@lists.linux.dev, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, alex.williamson@redhat.com,
        pbonzini@redhat.com, seanjc@google.com, joro@8bytes.org,
        will@kernel.org, robin.murphy@arm.com, kevin.tian@intel.com,
        baolu.lu@linux.intel.com, dwmw2@infradead.org, yi.l.liu@intel.com
Subject: Re: [RFC PATCH 11/42] iommu: Add new domain op cache_invalidate_kvm
Message-ID: <20231204150945.GF1493156@nvidia.com>
References: <20231202091211.13376-1-yan.y.zhao@intel.com>
 <20231202092041.14084-1-yan.y.zhao@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231202092041.14084-1-yan.y.zhao@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4MRwM/DtMtWT0c4vh7pNitcXu7Pdl9JnIJl7e6Dl047h0WCc5JEeSqe0PaxF?=
 =?us-ascii?Q?jGrG04IeomlNA/UEDTczlKHKPiqEyhYjuF0lrrJAucaQ9vGyC5Tovv4WzZR4?=
 =?us-ascii?Q?sGpDa2VjD9H4tWMPJI9bTBrmrxrbDkzwagxcggrq3II3m6CrxH/QwUsyA1JN?=
 =?us-ascii?Q?zkZHNySyHo5BC7ws6hUuId5ONJELAdpdcJkyylFuruYB7kRRzM6LOffy+6/5?=
 =?us-ascii?Q?fdz9RmWUnCC/9Me6/R2RkUjwe5ONyeIC/t5VPP8iq4DbmAK9TobnW1mj0sB5?=
 =?us-ascii?Q?mGRB+NDEe9VTXajvw26XwUNFjllVh7M/RHGwYjafspNZGriej9qbWhFdZu96?=
 =?us-ascii?Q?boYj+i50cNdl4rsDn1LqoX5a1GVrwI7pQydzJKorIv2Dx0HmJVGSNOwbh4zt?=
 =?us-ascii?Q?8XkDYtNidDYkoZuVe0cYJXrxU2zO5AvcFr/f880V6H6QEOJutXcIWGdJv5K2?=
 =?us-ascii?Q?fwbsRp9hJR3Dc0gdTIRWO0Hgai7RrUdh4eWlzhOhWnlKbhdJePLk2+xIaokL?=
 =?us-ascii?Q?grDZk8+S9oFUZ3KO5vNsusqkhi69gHJmSbpP7DORA7p9MEUOURSB6rHqGfPL?=
 =?us-ascii?Q?RDaUV7T7W7FDDQzQMf5ZtIANBoKQoAUOO8ZE4QEDWHMWc8cTpl4odLdfeL/L?=
 =?us-ascii?Q?6311/umVA2qx8CwgSB+1jq0a/sAo/ddBtVawVNFmFgQAnvZfpvoTjwFuURtq?=
 =?us-ascii?Q?diyQmW8HgdMY+Z+sTvfbkOtxbHYa/OLh4VZUO0T8rZY6Q/70lY3ViNbdIr6X?=
 =?us-ascii?Q?uqsTJMJZdOrcdzsz/LYYoYSigtprtj0Ky9EmaXuAKKowo/nCT3zZwjW7oRRL?=
 =?us-ascii?Q?6FU0Pql3xi/w7v0hGVA+v8V6McKaxSsEu2kLH6ORqwRXP7a2YocPGpdpJjuI?=
 =?us-ascii?Q?W+2jfjjlRp+/DhXP2jCvpkufO5StAImLpcY3AJ0uCw8+q5KbVyzbe5cY3KCR?=
 =?us-ascii?Q?IbyeLbbC2a3zep90IUMuysgyvATakF7QVt0aM8sbFNt9ZnPn59GA9nbby/Ms?=
 =?us-ascii?Q?RByXhOAjtbZZHQM5whZluyQa6VgYr0/AtXCNxE5WnGFujR9pVxtoAscEHC7a?=
 =?us-ascii?Q?fFS42Xsz8lHm3IMoMdkwBMgor7se+MQdD2e/iYBAZH79CC3d3sP5nOIHpHdI?=
 =?us-ascii?Q?65vb8yEGmO6ptA8pKaPAVt+vmoMBWfmdlsXJZb/3cDkkTVaGPi/jfQ+Dpe/r?=
 =?us-ascii?Q?SlJs7xuMAhoL06tDx/b8t2AR6PDcCKq3pO0j+CaeA87hgbIL3TCounmuzRM/?=
 =?us-ascii?Q?cl3BrrFQ/zQsfQqlZALhYT3TK51rfagFsqUPfyJDJNnWQfSzBzE1icVis5Mm?=
 =?us-ascii?Q?VdWgfBj1bTC7h+n7LnVzmZMIW+ce7mq7a/8POjmSpy7tgOYRZ79rYf5D+tWh?=
 =?us-ascii?Q?6SVXHbMXcblF8CPlsePdHAjFEf7lGNU3u4BqZzHcGSa51MJU7SJ4LL3o/dkX?=
 =?us-ascii?Q?gs6MIQn7Kh1e2PuADWUseSVBwtgxLA1ro4MTVxKZb0pVbnDg/+5lN8jNfQqZ?=
 =?us-ascii?Q?Un+espzRQ533p7xnVrU4YhoxaMqCqB2Oid07IH01lkBN/2Xqormi917inyyR?=
 =?us-ascii?Q?F9uazMRjDwsW3DZr5DvpNOpdB3qqubFelPI1cQln?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5de207a8-7848-438c-24da-08dbf4db0d6c
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Dec 2023 15:09:46.4544
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: g8ttZteJsigb0HdONx/WStg/sR9Sx556zA/z6s/iTDPCLf51ZbWOdE3umsF0PYR2
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7113
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 04 Dec 2023 07:09:59 -0800 (PST)

On Sat, Dec 02, 2023 at 05:20:41PM +0800, Yan Zhao wrote:
> On KVM invalidates mappings that are shared to IOMMU stage 2 paging
> structures, IOMMU driver needs to invalidate hardware TLBs accordingly.
> 
> The new op cache_invalidate_kvm is called from IOMMUFD to invalidate
> hardware TLBs upon receiving invalidation notifications from KVM.

Why?

SVA hooks the invalidation directly to the mm, shouldn't KVM also hook
the invalidation directly from the kvm? Why do we need to call a chain
of function pointers? iommufd isn't adding any value in the chain
here.

Jason