Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
From:   Donald Robson <donald.robson@imgtec.com>
To:     <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
CC:     <frank.binns@imgtec.com>, <donald.robson@imgtec.com>,
        <matt.coster@imgtec.com>, <maarten.lankhorst@linux.intel.com>,
        <mripard@kernel.org>, <tzimmermann@suse.de>, <airlied@gmail.com>,
        <daniel@ffwll.ch>, kernel test robot <lkp@intel.com>
Subject: [PATCH v2] drm/imagination: Removed unused functions in pvr_fw_trace
Date:   Mon,  4 Dec 2023 15:13:37 +0000
Message-Id: <20231204151337.60930-1-donald.robson@imgtec.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/690LToo1Lw7vdRLDM3pwsKmAhTZhc2dQ6FFDKhaemT1L5y9MLCrWR+2gwn1?=
 =?us-ascii?Q?Z+x6T2knpznA0BYRmWMFtdRXlkdGe0KapglMdlvUC9irMWR1W+hxXeDlxdZC?=
 =?us-ascii?Q?2n1sc4NubaoSH/Xl7GiRCjARB9VlXT4+cKTKT4qx2Mlf5WdeXM6NRvmC2zA4?=
 =?us-ascii?Q?q7O0CUMWxhkcMVdK7JqvtuqxFrUYY6Mk4+0dlChN0zBTF5Qh/PiMObCvZr/b?=
 =?us-ascii?Q?FCRsukU8OqBSPVVLeA8qddqov97GZuFt3cX+wBhOeBqvfqSweVjcGashiuHN?=
 =?us-ascii?Q?V9wNEvvKUqvI7Pwh6xd2fhuUoboxEpHNFqCB8276gy7NqFvU3e8dX7b2T5yq?=
 =?us-ascii?Q?EchPBdtz9y9s8DtO6QkD6f73zZFY4frOEHUA0vSmggiW5G3N6QO9d45otF+p?=
 =?us-ascii?Q?eubq5LMslBAj9KUm8Yi24n4RxaUobqCGB5PkXryVhV6B+kfBPqXGMxLNhMv5?=
 =?us-ascii?Q?oa+evU88vOkCc3BDPkSjy7hnLYE6GqfdflcGWOHiw0XY+1+R9GmY3nywg3z4?=
 =?us-ascii?Q?35Fbd5QYPhCFvFTDrK5YeMdm7ZfMdW96/EWIQpkTqLojodGe0eIxwWFXjGij?=
 =?us-ascii?Q?CZwHLcd6ase7ROkLxvtsslLJ2vk+4bVBPvtzrtLQK2NtYKhU9kErMpp6pva2?=
 =?us-ascii?Q?M3DLFWzJvNagC5uZPQuN0YhyFGWBqxyXdAl55hWgrePyMDCiGGq9hJsu5P46?=
 =?us-ascii?Q?2pzIPw4qshFkHoa2aOGTPT11bw3MNBZV38Rdv35AoRUXvIXi5tgyyRAngFzj?=
 =?us-ascii?Q?ZYCSCNIr59BzhI7IkdIlRh/B7bpln/5GIDWHt6ILofe0qy8AK90hB5rHimmF?=
 =?us-ascii?Q?zHisVbl/UcL5gS8QfprKkZKRK+fl0SurIkVveEC9h0PdbcqqrBLLyT+LOTg0?=
 =?us-ascii?Q?5ISt5EeypYcOzxyk1McyTnJ45iifRr5xM4N+fI2MpT42S2omx9rFew7QqH2D?=
 =?us-ascii?Q?tKa5oeiCV1X8Gp23M+SZ3BrHN95+iE3J0Q729qqM8C9weyBl7NJOAD2744gQ?=
 =?us-ascii?Q?X7ux6voJs/sSkVWqzDzsNhdSO9Vn/dCvl8cBB+viT/rj0h3Jwn1HHqwZnjmw?=
 =?us-ascii?Q?9ckvHcJPhYtm9NgEgSsA6BekE2NF5pgGy5Nghn5tbBtZhVOGKZ3474yobtqW?=
 =?us-ascii?Q?nX4VOAPKI0+D6hZ03Iw6ZUZMCWEjBITRo9ZTemO+xaW1qxqdO+Xdlw8ArDxq?=
 =?us-ascii?Q?dSRPz/B7Lkg4voGTpIeAGQAd6Y0MYO+QC6zRpKzRpWj9ro5PC9ssJaa3IZ4v?=
 =?us-ascii?Q?3WbP4MSCYBIAqNp3H+9tTwffHXYHFn1MfUPZB1R/hsScWC0O2n9QXqV+QqF+?=
 =?us-ascii?Q?wDCV+WJW0rbsD8SGhkNh6VjnXiv9J5tk7O4KzClWrhPrT3PSxXJPzjowIkhJ?=
 =?us-ascii?Q?H7sjI3cNSWfGF+NUiTYhpdigCvKwzJQNu8tnzwkrlUG2enVKjaMYbWDJ1xpr?=
 =?us-ascii?Q?49/9SL9eeiX/UV4QOkEBwmon6VOAEpMeYoOYtXPwJgDeFP7aBIyW+mZGHHFV?=
 =?us-ascii?Q?3581YxaISz2IdDR910/0B3VQJ2JcUMx4XD1rgUVqW29EgImEZlwPm/ZIrIEB?=
 =?us-ascii?Q?Jx74OA4+U10lp+afZQCAER9KZLQyhiU6VG2emSYxo2ZbXmKdzYoIemFnZKyy?=
 =?us-ascii?Q?nw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a435fa6e-8af4-48fb-2489-08dbf4dba2f4
X-MS-Exchange-CrossTenant-AuthSource: CWLP265MB5770.GBRP265.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Dec 2023 15:13:57.3287
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0d5fd8bb-e8c2-4e0a-8dd5-2c264f7140fe
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: i5/07CLrGB8pULOzt7SSZ+HzMoKk5QPR4/YuLxDhbid3YZdQx2LvJ+UshD2EjHwl6sQ9j5QvaJtObWf6BCkTUbB4BmzApUnV6gun5CHdPTs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LO2P265MB2608
X-OriginatorOrg: imgtec.com
X-EXCLAIMER-MD-CONFIG: 15a78312-3e47-46eb-9010-2e54d84a9631
X-Proofpoint-GUID: 9c3CLMFPJ51CC12F8vMsdi_OFi_SJwVS
X-Proofpoint-ORIG-GUID: 9c3CLMFPJ51CC12F8vMsdi_OFi_SJwVS
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 04 Dec 2023 07:14:34 -0800 (PST)

Fixing the warning below due to an unused file level vtable. Removing
only this causes additional warnings for the now unused functions, so
I've removed those too.

>> drivers/gpu/drm/imagination/pvr_fw_trace.c:205:37: warning: 'pvr_fw_trace_group_mask_fops' defined but not used [-Wunused-const-variable=]
     205 | static const struct file_operations pvr_fw_trace_group_mask_fops = {
         |                                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~

Changes since v1:
- Corrected hash in Fixes tag.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202311302054.MVYPxFCE-lkp@intel.com/
Fixes: cb56cd610866 ("drm/imagination: Add firmware trace to debugfs")
Signed-off-by: Donald Robson <donald.robson@imgtec.com>
---
 drivers/gpu/drm/imagination/pvr_fw_trace.c | 44 ----------------------
 1 file changed, 44 deletions(-)

diff --git a/drivers/gpu/drm/imagination/pvr_fw_trace.c b/drivers/gpu/drm/imagination/pvr_fw_trace.c
index 87a42fb6ace6..30f41a10a0cf 100644
--- a/drivers/gpu/drm/imagination/pvr_fw_trace.c
+++ b/drivers/gpu/drm/imagination/pvr_fw_trace.c
@@ -167,50 +167,6 @@ update_logtype(struct pvr_device *pvr_dev, u32 group_mask)
 
 #if defined(CONFIG_DEBUG_FS)
 
-static int fw_trace_group_mask_show(struct seq_file *m, void *data)
-{
-	struct pvr_device *pvr_dev = m->private;
-
-	seq_printf(m, "%08x\n", pvr_dev->fw_dev.fw_trace.group_mask);
-
-	return 0;
-}
-
-static int fw_trace_group_mask_open(struct inode *inode, struct file *file)
-{
-	return single_open(file, fw_trace_group_mask_show, inode->i_private);
-}
-
-static ssize_t fw_trace_group_mask_write(struct file *file, const char __user *ubuf, size_t len,
-					 loff_t *offp)
-{
-	struct seq_file *m = file->private_data;
-	struct pvr_device *pvr_dev = m->private;
-	u32 new_group_mask;
-	int err;
-
-	err = kstrtouint_from_user(ubuf, len, 0, &new_group_mask);
-	if (err)
-		return err;
-
-	err = update_logtype(pvr_dev, new_group_mask);
-	if (err)
-		return err;
-
-	pvr_dev->fw_dev.fw_trace.group_mask = new_group_mask;
-
-	return (ssize_t)len;
-}
-
-static const struct file_operations pvr_fw_trace_group_mask_fops = {
-	.owner = THIS_MODULE,
-	.open = fw_trace_group_mask_open,
-	.read = seq_read,
-	.write = fw_trace_group_mask_write,
-	.llseek = default_llseek,
-	.release = single_release,
-};
-
 struct pvr_fw_trace_seq_data {
 	/** @buffer: Pointer to copy of trace data. */
 	u32 *buffer;
-- 
2.25.1