Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
From:   Jiri Kosina <jkosina@suse.com>
Date:   Mon, 4 Dec 2023 16:18:19 +0100 (CET)
To:     Mario Limonciello <mario.limonciello@amd.com>
cc:     Linus Walleij <linus.walleij@linaro.org>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        "open list:PIN CONTROL SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        Basavaraj Natikar <Basavaraj.Natikar@amd.com>,
        "open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
        stable@vger.kernel.org, Marcus Aram <marcus+oss@oxar.nl>,
        Mark Herbert <mark.herbert42@gmail.com>
Subject: Re: [PATCH 1/2] HID: i2c-hid: Add IDEA5002 to
 i2c_hid_acpi_blacklist[]
In-Reply-To: <20231203032431.30277-2-mario.limonciello@amd.com>
Message-ID: <nycvar.YFH.7.76.2312041617590.29220@cbobk.fhfr.pm>
References: <20231203032431.30277-1-mario.limonciello@amd.com> <20231203032431.30277-2-mario.limonciello@amd.com>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Sat, 2 Dec 2023, Mario Limonciello wrote:

> Users have reported problems with recent Lenovo laptops that contain
> an IDEA5002 I2C HID device. Reports include fans turning on and
> running even at idle and spurious wakeups from suspend.
> 
> Presumably in the Windows ecosystem there is an application that
> uses the HID device. Maybe that puts it into a lower power state so
> it doesn't cause spurious events.
> 
> This device doesn't serve any functional purpose in Linux as nothing
> interacts with it so blacklist it from being probed. This will
> prevent the GPIO driver from setting up the GPIO and the spurious
> interrupts and wake events will not occur.
> 
> Cc: stable@vger.kernel.org # 6.1
> Reported-and-tested-by: Marcus Aram <marcus+oss@oxar.nl>
> Reported-and-tested-by: Mark Herbert <mark.herbert42@gmail.com>
> Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/2812
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
>  drivers/hid/i2c-hid/i2c-hid-acpi.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/hid/i2c-hid/i2c-hid-acpi.c b/drivers/hid/i2c-hid/i2c-hid-acpi.c
> index ac918a9ea8d3..1b49243adb16 100644
> --- a/drivers/hid/i2c-hid/i2c-hid-acpi.c
> +++ b/drivers/hid/i2c-hid/i2c-hid-acpi.c
> @@ -40,6 +40,11 @@ static const struct acpi_device_id i2c_hid_acpi_blacklist[] = {
>  	 * ICN8505 controller, has a _CID of PNP0C50 but is not HID compatible.
>  	 */
>  	{ "CHPN0001" },
> +	/*
> +	 * The IDEA5002 ACPI device causes high interrupt usage and spurious
> +	 * wakeups from suspend.
> +	 */
> +	{ "IDEA5002" },

Applied to hid.git#for-6.7/upstream-fixes. Thanks,

-- 
Jiri Kosina
SUSE Labs