Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Jorge Ramirez-Ortiz <jorge@foundries.io>,
        "adrian.hunter@intel.com" <adrian.hunter@intel.com>,
        "ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
        "christian.loehle@arm.com" <christian.loehle@arm.com>
CC:     "jinpu.wang@ionos.com" <jinpu.wang@ionos.com>,
        "axboe@kernel.dk" <axboe@kernel.dk>,
        "beanhuo@micron.com" <beanhuo@micron.com>,
        "yibin.ding@unisoc.com" <yibin.ding@unisoc.com>,
        "victor.shih@genesyslogic.com.tw" <victor.shih@genesyslogic.com.tw>,
        "asuk4.q@gmail.com" <asuk4.q@gmail.com>,
        "hkallweit1@gmail.com" <hkallweit1@gmail.com>,
        "yangyingliang@huawei.com" <yangyingliang@huawei.com>,
        "yebin10@huawei.com" <yebin10@huawei.com>,
        "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] mmc: rpmb: do not force a retune before RPMB switch
Thread-Topic: [PATCH] mmc: rpmb: do not force a retune before RPMB switch
Thread-Index: AQHaJsLBZ2sxhOoGTkWiMOgXX6Cv0bCZTlZw
Date:   Mon, 4 Dec 2023 16:22:04 +0000
Message-ID: <DM6PR04MB6575DE834F55913A9E799ACEFC86A@DM6PR04MB6575.namprd04.prod.outlook.com>
References: <20231204150111.3320071-1-jorge@foundries.io>
In-Reply-To: <20231204150111.3320071-1-jorge@foundries.io>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?eH3t3PVuL4btjO0vowiAqmbaUDO9bvue0PZ4depT+sueUVedYEkPaj7IYEyv?=
 =?us-ascii?Q?2T4WqIugCo/Oowrapblx5tsKjCYUpMmN1wgz3Z7XHy/PQLV9qUUe0ortO3dC?=
 =?us-ascii?Q?UOKSvK1v7WLLZXAcx2WwEfxRB/nI1OvCwliO9SxyK7fkR4uumxfjzq+uHRP3?=
 =?us-ascii?Q?fCwXsaKctJ94x8a9uGkB4AON4vmzoFd4u5y8NHkcbV+CbPL0mBUreuKrVR7b?=
 =?us-ascii?Q?8SixhnppnpLB4NOStAJj8+yeQrhdB0fczcGRCyxul86f+2qFNJDO9WWPvC6C?=
 =?us-ascii?Q?X8PRPifaCcIY9/KAu+mjMq9dJeg46CNk3Hc3TWSQaGVhRLL7NfxdW0cFNCzf?=
 =?us-ascii?Q?B3ZDyHwl++gJvY9fWKo6vUIwl1QgyaQcnFh7KWTdOdeGfaSP6eWRWGDHKr8D?=
 =?us-ascii?Q?H7zVubezbDBUPtPPZMp8xXSfGNoW0UylQlh6aMD2LiN5+9kOjse+i8vycz6r?=
 =?us-ascii?Q?4Q5uZaGnYryub6GoRxKdHPUnepDf1PgWjkwcV7l+MxTm3KJtv36EtB3uHGI3?=
 =?us-ascii?Q?VN5XjG7QDn2H7yPubzTsWcvAx9SOPot928dzypt2ZkOQJpfXMXU4T1x/mCUU?=
 =?us-ascii?Q?X6qow+XVT/Ksy+OKp/rVJLAs0+GaUAJUWXLrFxgshldM+tplzihShNhLyF++?=
 =?us-ascii?Q?HY8Ef/yrgJFQCJ6HZbz0epVeRj1D1XZNKC42a8Y9tmEWL9X10lS4gaBGLVD2?=
 =?us-ascii?Q?1YfuygLYJPt8EM8Yn/Ds24FdABgnH6Ml8Snmj+fCAgmSmhm0/wRkKVf21xxG?=
 =?us-ascii?Q?m6fVn5YLvaGIxrxeu0tlJWnDCADE9t56eMXBdSOc4AC9rDmj9uGnttGPIU7R?=
 =?us-ascii?Q?AQg/NILrUjjI+bcDG1O5oHW6S8hzDfmSCSsdj4Aoq98pa+a6Szqk4DS3JISz?=
 =?us-ascii?Q?Ej+IvYBP9C6Tu1BzorNnTLsnMfJxtx1e4p2olIbGQJV9QIesJDOVuX+Md6JM?=
 =?us-ascii?Q?1be15r8HNv2JMNepT+tVDdyAXKEYXePNIrvQEfo1OIn+UEmTt8ECzvpgNw7B?=
 =?us-ascii?Q?E4xgV2TBCMo3JXImZvWiG+A6WggcXA2+MwNkzxnU/haK9BijwNj40ODTZqZh?=
 =?us-ascii?Q?By4vXPEh0qCG7fxfnqEiQOJn4qp2JnUj+Ww8Xbd1pXc8/thWf2Ib2zbEmAOv?=
 =?us-ascii?Q?iJP3xelEHDWnrM2WzRBu0AxyzIWwOzs7NJA1wQbfhZRREDLSObixFs92XWR3?=
 =?us-ascii?Q?KoA2rAflJRm/NaeN+p6lWdMix4vz1SjN+Ca0EBoGhvpvu3+OO11qM2kp+c53?=
 =?us-ascii?Q?HpoKk0ZEOuv2heO4pKzqCMC6eZHA7UYxkfRqzsK3yIMZyJhYMMctiRp036VL?=
 =?us-ascii?Q?JJZ8LivHvNgSLB6gX/Q6nA6UHiq54yWaYi796mveY/5dqk2o5pAu6yY+NXq4?=
 =?us-ascii?Q?2WQLFu7WTinWuSjzDb+k7GCdRliFpc/GTwFBDW5MnzUnmjVW2NRXhCK5s6YY?=
 =?us-ascii?Q?YOZtJhhoIRxSSsaX9Fml7DGOPwwvWKwpPpg6lxad7TW1WmkatuLy40A+gIhY?=
 =?us-ascii?Q?I2Swo8IoQC4eQkRQjcK+B7svsA8GyUC23589PKeQeFJOPbrvszjI3EJx7Idf?=
 =?us-ascii?Q?yB1J1UmZXmyfK1nZXVm9HGer69r0BE1dVPz1fizL?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?BmLsXEdWQxXdPfG90rJVPLCquWVF+VWO/EAlnWeI+mdyKsEu8JjzkQaoo5Di?=
 =?us-ascii?Q?y0cXsMJXodL/u9N4NzlYAK91dSS+p5Cz5+uepBydmrPsz5T336MJp8IwmXTP?=
 =?us-ascii?Q?sz99lmikhV9C5uNy031HbXXEj1R3xn2yoUSDaymWS3BVzv4L27KMsV999cGr?=
 =?us-ascii?Q?KFLpTyu+Zjekfq7h8p2xzKOsOjhqxZAv292Pur03taiUnc+bTDQSdDGBLcWr?=
 =?us-ascii?Q?H2I70/mA3HpxRj7leqTBW6PyhCcnB+4rLs5eRG2iOnd+1BfN1JXxKDgQOQVC?=
 =?us-ascii?Q?MA2uhMrhe+C2y+jUI64+6mYhuya6GmO5pDZPdTPNaENYxmIzdTLz+kTVzSFm?=
 =?us-ascii?Q?cRaaDnCIuWfpfRMjjsQjEzmoaoRRLnpDJrhCZX3xaDvS6EyJfuue1oYSf5/B?=
 =?us-ascii?Q?pL2RJBECjaBMWLMr/ije05YjXIyG1In+Iq/gEpnXVrhQT2i999KrwxY3Qaxp?=
 =?us-ascii?Q?49rYv4B+uTmmbBy3j3gOwMk3lx1dtsZoOl+3r9syAVYHntJScl0837LiM2uB?=
 =?us-ascii?Q?UJFecMcPQTz2g20vd0KIYAI6DLiiqChz8cVEtE9ZAHGb7jyInpYGN8q8J/xZ?=
 =?us-ascii?Q?/7oks6O5QzVhbHsegKlDe7zWjD0XWA3+WcHblAQhwVboYQv/kkSxzfw8X1O6?=
 =?us-ascii?Q?IUcXF7lgPTSEiHsYNYYdWzvfMQYY+6uQ05ZBP9++cRaF0ujFeotaFOdjmgY6?=
 =?us-ascii?Q?6RBissb/Ly22z5eLG22NEuaoxJTqlGBIgokBrFFoGK05YsbpjvzFdlyXN9XA?=
 =?us-ascii?Q?NjH3/P14VTD1HzsOtoBbx9Gu1fmPNgURfiQjPa6sjn3BXrT0sPBMFR7Z8joN?=
 =?us-ascii?Q?6GHWKuiipPymWh6i3kDeQlzTQvLplqBdoxzrBal/tYxYnbM8YcGNeXt/1W99?=
 =?us-ascii?Q?AvKN+Bj/AdvGs5p/9BQTKEP+Sob+bhVBWMFwpsHL4Ito8F7GmVFRlDmzlmKg?=
 =?us-ascii?Q?0GhpvWssFJS5crprdtMQxnhCw9TybCRLT6TfVWvkgyezhcBwifJxfgtYs5cx?=
 =?us-ascii?Q?bBoD3kVaNbQ/4G+FX8kvFm8O7t6D7KmhAtOvcjHvLKZF6TQng4ZiBaI41hkv?=
 =?us-ascii?Q?o4vBclY+NKGgvEg4ii2T7DUUbPtPFmR0zr7ve/8Oem3VYksRVUA=3D?=
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR04MB6575.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 220f6653-ffc9-4c34-ed4d-08dbf4e5273e
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Dec 2023 16:22:04.5993
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: S1D64vdTYx7s+ti7je9UJKvDcpsH6f0OsaxbrrfJWOBXwzEsJCA2Z21ks4XNuw62wJ8vTwl26O9YvA7fD5UM0A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR04MB9050
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 04 Dec 2023 08:22:20 -0800 (PST)

=20
> Requesting a retune before switching to the RPMB partition has been
> observed to cause CRC errors on the RPMB reads (-EILSEQ).
>=20
> Since RPMB reads can not be retried, the clients would be directly affect=
ed by
> the errors.
>=20
> This commit disables the request prior to RPMB switching while allowing t=
he
> pause interface to still request a retune before the pause for other use =
cases.
>=20
> This was verified with the sdhci-of-arasan driver (ZynqMP) configured for
> HS200 using two separate eMMC cards (DG4064 and 064GB2). In both cases,
> the error was easy to reproduce triggering every few tenths of reads.
>=20
> Signed-off-by: Jorge Ramirez-Ortiz <jorge@foundries.io>
Acked-by: Avri Altman <avri.altman@wdc.com>

> ---
>  drivers/mmc/core/block.c | 2 +-
>  drivers/mmc/core/host.c  | 7 ++++---
>  drivers/mmc/core/host.h  | 2 +-
>  3 files changed, 6 insertions(+), 5 deletions(-)
>=20
> diff --git a/drivers/mmc/core/block.c b/drivers/mmc/core/block.c index
> f9a5cffa64b1..1d69078ad9b2 100644
> --- a/drivers/mmc/core/block.c
> +++ b/drivers/mmc/core/block.c
> @@ -859,7 +859,7 @@ static int mmc_blk_part_switch_pre(struct mmc_card
> *card,
>                         if (ret)
>                                 return ret;
>                 }
> -               mmc_retune_pause(card->host);
> +               mmc_retune_pause(card->host, false);
>         }
>=20
>         return ret;
> diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c index
> 096093f7be00..a9b95aaa2235 100644
> --- a/drivers/mmc/core/host.c
> +++ b/drivers/mmc/core/host.c
> @@ -119,13 +119,14 @@ void mmc_retune_enable(struct mmc_host *host)
>=20
>  /*
>   * Pause re-tuning for a small set of operations.  The pause begins afte=
r the
> - * next command and after first doing re-tuning.
> + * next command and, if retune is set, after first doing re-tuning.
>   */
> -void mmc_retune_pause(struct mmc_host *host)
> +void mmc_retune_pause(struct mmc_host *host, bool retune)
>  {
>         if (!host->retune_paused) {
>                 host->retune_paused =3D 1;
> -               mmc_retune_needed(host);
> +               if (retune)
> +                       mmc_retune_needed(host);
>                 mmc_retune_hold(host);
>         }
>  }
> diff --git a/drivers/mmc/core/host.h b/drivers/mmc/core/host.h index
> 48c4952512a5..321776b52270 100644
> --- a/drivers/mmc/core/host.h
> +++ b/drivers/mmc/core/host.h
> @@ -18,7 +18,7 @@ void mmc_retune_disable(struct mmc_host *host);
> void mmc_retune_hold(struct mmc_host *host);  void
> mmc_retune_release(struct mmc_host *host);  int mmc_retune(struct
> mmc_host *host); -void mmc_retune_pause(struct mmc_host *host);
> +void mmc_retune_pause(struct mmc_host *host, bool retune);
>  void mmc_retune_unpause(struct mmc_host *host);
>=20
>  static inline void mmc_retune_clear(struct mmc_host *host)
> --
> 2.34.1