Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp2826066rdb; Mon, 4 Dec 2023 08:29:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IHODcSduZ2IPoFL/C2J5otiAtbRZZTA2vfDHKfemgy1DsAWrkggiCVsCLtatSdq+pKY+w/x X-Received: by 2002:a17:902:db07:b0:1d0:b1a0:8a0e with SMTP id m7-20020a170902db0700b001d0b1a08a0emr1416202plx.40.1701707382744; Mon, 04 Dec 2023 08:29:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701707382; cv=none; d=google.com; s=arc-20160816; b=KcJmpFSlUsIfIpoJK5zNq6XB59ONiq0a0jksM7/3yOWKNX9ZyHvfYkCElr3rDUDrhW 9aPmm4R+A+IDM1My774gPOXcp1OsoR2iTNMpS/GmvOQDCWDyKkux2kPP8bPSqyOMYsDl AzMLIRf9eH+U8U2+csXSQnYsHUxQzHvoOAyeXdXnQ/dapTCQ2LrgnLUQ2bsRRFNF+ZE4 C8CeHhxwULWV9WEweE1cjXCi5Au3jsHaVmkPQvXlZEz7x4Zuo3Qqh0wZeqxAA+JSbstR ZD72PPpKcgQQiZ+iaFNaeBCHOWRtiBHOY1QGmXvMZXnuDTxlN1ZTquJrn1C0d5sHCMOX L83Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=C0K47I8qTJaugwHJM7cAcmguI3Wxp8pPm0ieYycejeQ=; fh=GkCsY/0caSQLuYmD66aaQg61c05n2lKFxCCQ9VNnfmg=; b=imnhC/e/Z+FRNO/WwRRAHPGAR60qGYPSHLZ5ZQmY3e94Vy0t090Iw9Jl4YZCPGjohg fo4q3hIsEMRE7SmdxfM/04CEYXNEbhbsEklR5KdSoyCwA591jIEzcmZiMzVOXsndqiAN /7Rr8cJJH+cBLmvc0uG5jYm87/tDH4Juq8J7FozC2upfBetfQAzpm/kEEfBXEWpEibnp tPibHxpgf0qk+8Z/aCWTGGAv/UIlz9ttuG/YqOtad2lxmIUIgbG4uNbUmZNZNj6x6n7M 3u8OJE/sGtGNKVIutu2L3IzSAkv6TqKUywwVj8INEe/z9jNbNRQRbDXKS1JntiD7Cu/a pYlg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nlfqs1xK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id p6-20020a170902b08600b001cfda41729esi7918490plr.364.2023.12.04.08.29.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 08:29:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nlfqs1xK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 8E150804E2F9; Mon, 4 Dec 2023 08:29:41 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344824AbjLDQ30 (ORCPT + 99 others); Mon, 4 Dec 2023 11:29:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344930AbjLDQ3W (ORCPT ); Mon, 4 Dec 2023 11:29:22 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 53A8399 for ; Mon, 4 Dec 2023 08:29:24 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 97740C433C7; Mon, 4 Dec 2023 16:29:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701707364; bh=vhrxUvsCwsaGYvyyei5h55J9yp+nmIcuFyO/lJGVsJM=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=nlfqs1xKZp32xjV/6EKDBJ2qWN4k1GrusvYA6y+pDG1Nj3WAKnOLkUcGrPOZ0OGXz G3GpcOBo/LbTOymRzzN87kHGm/k9MEmu2KVNhy+o0ANyGkKUPya2AQF1H4vW3ZOJqJ hWr/bdZvrddYY7MeY6IAo/X9/v7xnSTZ9vj6VfispDV3rz3aQUHdFTYPjwuXB6KzoZ RMslHsfXUZZL/2rLamNH2sudBW3P7VJyae7PSnKlRrawgvr6wNMZRFf9tRu3rjxX6S ygYFPc/AcGJOf5wewz6kWRLZs4+R39dje2xLi6wgmnMF/f+XA68ImNDZmAOIdINyn5 shTvUc2qSCt+A== From: Mark Brown To: Dinghao Liu Cc: Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Richard Fitzgerald , Simon Trimmer , Kuninori Morimoto , Claudiu Beznea , Charles Keepax , patches@opensource.cirrus.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20231204074158.12026-1-dinghao.liu@zju.edu.cn> References: <20231204074158.12026-1-dinghao.liu@zju.edu.cn> Subject: Re: [PATCH] ASoC: wm_adsp: fix memleak in wm_adsp_buffer_populate Message-Id: <170170736133.96782.15219793902912289690.b4-ty@kernel.org> Date: Mon, 04 Dec 2023 16:29:21 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.13-dev-5c066 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 04 Dec 2023 08:29:41 -0800 (PST) On Mon, 04 Dec 2023 15:41:56 +0800, Dinghao Liu wrote: > When wm_adsp_buffer_read() fails, we should free buf->regions. > Otherwise, the callers of wm_adsp_buffer_populate() will > directly free buf on failure, which makes buf->regions a leaked > memory. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: wm_adsp: fix memleak in wm_adsp_buffer_populate commit: 29046a78a3c0a1f8fa0427f164caa222f003cf5b All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark