Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Date:   Mon, 4 Dec 2023 11:55:54 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Ankit Agrawal <ankita@nvidia.com>
Cc:     Borislav Petkov <bp@alien8.de>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        "naoya.horiguchi@nec.com" <naoya.horiguchi@nec.com>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "tony.luck@intel.com" <tony.luck@intel.com>,
        "linmiaohe@huawei.com" <linmiaohe@huawei.com>,
        "rafael@kernel.org" <rafael@kernel.org>,
        "lenb@kernel.org" <lenb@kernel.org>,
        "james.morse@arm.com" <james.morse@arm.com>,
        "shiju.jose@huawei.com" <shiju.jose@huawei.com>,
        "bhelgaas@google.com" <bhelgaas@google.com>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        Yishai Hadas <yishaih@nvidia.com>,
        "shameerali.kolothum.thodi@huawei.com" 
        <shameerali.kolothum.thodi@huawei.com>,
        "kevin.tian@intel.com" <kevin.tian@intel.com>,
        Aniket Agashe <aniketa@nvidia.com>, Neo Jia <cjia@nvidia.com>,
        Kirti Wankhede <kwankhede@nvidia.com>,
        "Tarun Gupta (SW-GPU)" <targupta@nvidia.com>,
        Vikram Sethi <vsethi@nvidia.com>,
        Andy Currid <acurrid@nvidia.com>,
        Alistair Popple <apopple@nvidia.com>,
        "Anuj Aggarwal (SW-GPU)" <anuaggarwal@nvidia.com>,
        John Hubbard <jhubbard@nvidia.com>,
        Dan Williams <danw@nvidia.com>, Matt Ochs <mochs@nvidia.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
        "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH v2 3/4] mm: Change ghes code to allow poison of
 non-struct pfn
Message-ID: <20231204155554.GG1493156@nvidia.com>
References: <20231123003513.24292-1-ankita@nvidia.com>
 <20231123003513.24292-4-ankita@nvidia.com>
 <20231202232319.GAZWu8Z6gsLp1kI5Dw@fat_crate.local>
 <20231204143650.GB1493156@nvidia.com>
 <20231204153646.GCZW3yDgal3gztpDRY@fat_crate.local>
 <BY5PR12MB3763A85483534C7FD50529C8B086A@BY5PR12MB3763.namprd12.prod.outlook.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <BY5PR12MB3763A85483534C7FD50529C8B086A@BY5PR12MB3763.namprd12.prod.outlook.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?eAQ9SsW8FRgGNa1V1JocLYek47KJQCqLVGM9Mp/WyeIbNRXBSaK1A9/23JJL?=
 =?us-ascii?Q?APNQQ7kcaC6Tcd9SGS8hnumO3TFob6PmxGKp5XKsKu6LgsdvJrobFdl/VO7q?=
 =?us-ascii?Q?duBx8zk+hEG/hYHMYGFR/60mxLmaVQfDTMf0J+bdL508NzRNZh0JnbixIIjt?=
 =?us-ascii?Q?RKOOKGp/0rp+FkdLrnpFcc75IS+/LQNz6Elf/8v+GhT0acovB6GXfKPiH7Zx?=
 =?us-ascii?Q?RzkIvNW6+Y+ypOh52zROIq2XwR+sChaqE8kfBrGsdHtw03KFrvAaA28Fj2wA?=
 =?us-ascii?Q?v6FqHLHYBYMde8MFdAYMi1qd+0S84tEtU7pcNcO0uOLd3ieZxsZQSpO28/so?=
 =?us-ascii?Q?6JWobDGpbs6R5g1UZoIs0b0+3Vz5q8kZhEZJLq5fV/Cjj4ANcwkBjhQdjyW4?=
 =?us-ascii?Q?/YslVi6Wh6Uo+dPuj4fi2U+wmAx+wsGPqM5SLrR53GbFSLNfv3kl1ovvpmQA?=
 =?us-ascii?Q?T4U3NP7rnTuS9vOx7mk88KUSHc0khq+tD4BB4rQIs7GOgeGCQN6/kZh2dkpq?=
 =?us-ascii?Q?o4cuZv7lhSL6Ivp8kFUPGqaZW1NuWDL3aiTgcpJCfR96HQi5vfb2hIuAfkl/?=
 =?us-ascii?Q?ty9MNzbc8RYT7Oqy9hOUBCxwxpvLaNBRD8cU0U3spe2w5ed3Ey0hmhXcFu37?=
 =?us-ascii?Q?nQ7HS6oWRTat+DfEpr+i4fUJnL+n8udfSvDBdefpLQBlKr6U+TonQgQC4WGp?=
 =?us-ascii?Q?Tgf8VEVWOqjCXsdyhDkpYJLLlQDayDA36JgWIByfwyheY6S8gVKPGohQ+l+U?=
 =?us-ascii?Q?VV4z1i9DhYchP9EXPraGryYpehV+CkcZrSnYBMdsDgHTC0FJBermumTUd7mX?=
 =?us-ascii?Q?IL8lRpmN0AKDQpyd0rcwspCLVVdOaM4Bn2urIcy71R6vrLTnsvSo7jXL6AL4?=
 =?us-ascii?Q?PIqzHFObrF6vxbS7s4Elyk9/YcxaOao6tF6T5MB1sAvVf+nGxIKU8wXlk6Zt?=
 =?us-ascii?Q?KmlZvTANCZreHSWbRN2vhPLgyqIJj2virCqbdh9EosSKphthbi/dY5+j7vaH?=
 =?us-ascii?Q?zp9EMAn+CB/eLl6nhAMVvbxwTS8E5QxN1rBVQPp+pZ8qXsD/rrRF7ghiP7sS?=
 =?us-ascii?Q?lQCZ42snSu/nPJODqym7zE+dkorrVM6TyYgYxHLYnRadAwg7J9MtjDOPm9Kg?=
 =?us-ascii?Q?FuKrKxbSIW7OrKMocuq1IANyvOClZ//lgb+qi42t53VUcaGRg5agyMQ52mHp?=
 =?us-ascii?Q?amjUN3a7IqPd62HqSIBP4Rr3OjeYBq4a6VrXzN5dVluBWN1PNS+xlylyWFlY?=
 =?us-ascii?Q?dcjEbYbALVKjx4y0QUlcMnq2yCdZa939MKi/CyG701+6Dk9xa3Re5O16K6el?=
 =?us-ascii?Q?j1oPso+5GsipbXxDsj9D5lJWX9br7/NvIPxWUUXsCtW8h0YBoMgZP1c7hiZ2?=
 =?us-ascii?Q?GFGfUW3tDQXgYu+TPIDV6GrQLf2DuMTcbfG2oZjz1PqrUcuRoW40FNgRoxsP?=
 =?us-ascii?Q?zx6LesOcXz+uFsd8xjTOue2TnTBCtCuZuaSjSSWw80hfdD5fDD1eZVdUZII2?=
 =?us-ascii?Q?QkzRXD1ILbJCC3xeN+XErPUUtzcz7TOC6fsjrDI9hPsG+fkOXEsPhbXBRA+5?=
 =?us-ascii?Q?HBtHuHuSwlZThVoF62NWlsXBph2kvHmEcChClQLr?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0368f6b9-772c-4698-d8a3-08dbf4e17fba
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Dec 2023 15:55:55.2317
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HbWd9L8gIF7IwoNt4iBRBoB/lXVdbxErXZsD8sDoVk7gmJhKbCuCwi+tpMzBStKF
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4284
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 04 Dec 2023 08:46:55 -0800 (PST)

On Mon, Dec 04, 2023 at 03:54:52PM +0000, Ankit Agrawal wrote:
> >> It wasn't removed. patch 1 moved it to memory_failure() where it makes
> >> a lot more sense.
> >
> > Why is this a separate patch then?
> 
> This was done to keep ghes code separate from the memory failure code.
> I can merge them if that is preferable.

A single patch to move just this code could be a good idea

Jason