Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
MIME-Version: 1.0
References: <20231201-x1e80100-drm-panel-edp-v2-1-b0173484631a@linaro.org>
In-Reply-To: <20231201-x1e80100-drm-panel-edp-v2-1-b0173484631a@linaro.org>
From:   Doug Anderson <dianders@chromium.org>
Date:   Mon, 4 Dec 2023 08:46:44 -0800
Message-ID: <CAD=FV=Wx_W-Jspx4S4k-Jze8eBm5zGanzqt0-fWjYZhHB_=1qQ@mail.gmail.com>
Subject: Re: [PATCH v2] drm/panel-edp: Add SDC ATNA45AF01
To:     Abel Vesa <abel.vesa@linaro.org>
Cc:     Neil Armstrong <neil.armstrong@linaro.org>,
        Jessica Zhang <quic_jesszhan@quicinc.com>,
        Sam Ravnborg <sam@ravnborg.org>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi,

On Mon, Dec 4, 2023 at 12:54=E2=80=AFAM Abel Vesa <abel.vesa@linaro.org> wr=
ote:
>
> Add support for the SDC ATNA45AF01 panel.
>
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
> Changes in v2:
> - moved the panel entry in the proper place, as suggested by Doug
> - Link to v1: https://lore.kernel.org/r/20231201-x1e80100-drm-panel-edp-v=
1-1-ef9def711d8a@linaro.org
> ---
>  drivers/gpu/drm/panel/panel-edp.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/pa=
nel-edp.c
> index 825fa2a0d8a5..78565c99b54d 100644
> --- a/drivers/gpu/drm/panel/panel-edp.c
> +++ b/drivers/gpu/drm/panel/panel-edp.c
> @@ -1983,6 +1983,8 @@ static const struct edp_panel_entry edp_panels[] =
=3D {
>         EDP_PANEL_ENTRY('K', 'D', 'C', 0x0809, &delay_200_500_e50, "KD116=
N2930A15"),
>         EDP_PANEL_ENTRY('K', 'D', 'B', 0x1120, &delay_200_500_e80_d50, "1=
16N29-30NK-C007"),
>
> +       EDP_PANEL_ENTRY('S', 'D', 'C', 0x416d, &delay_100_500_e200, "ATNA=
45AF01"),
> +

Looks fine to me now. I will note that e200 is pretty long and I
wonder if you've got this because of a requirement of T3+T4+T5+T6+T8
being more than 200ms. If so, I wonder if Pin-yen's patch [1] would
help you optimize things?

In any case, this looks fine to me.

Reviewed-by: Douglas Anderson <dianders@chromium.org>

...I'll wait a day in case you say this would be better atop Pin-yen's
patch and want me to wait, but I also have no objections to landing
this now and later optimizing the delays.

[1] https://crrev.com/c/5052150