Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
Message-ID: <fa208013-7bf8-80fc-2732-814f380cebf9@amd.com>
Date:   Mon, 4 Dec 2023 08:48:00 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v2 0/2] Attach DT nodes to existing PCI devices
Content-Language: en-US
To:     Bjorn Helgaas <helgaas@kernel.org>, Rob Herring <robh@kernel.org>
CC:     Herve Codina <herve.codina@bootlin.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        "Bjorn Helgaas" <bhelgaas@google.com>, Max Zhen <max.zhen@amd.com>,
        Sonal Santan <sonal.santan@amd.com>,
        Stefano Stabellini <stefano.stabellini@xilinx.com>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        PCI <linux-pci@vger.kernel.org>,
        Allan Nielsen <allan.nielsen@microchip.com>,
        Horatiu Vultur <horatiu.vultur@microchip.com>,
        Steen Hegelund <steen.hegelund@microchip.com>,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>
References: <20231201224556.GA534342@bhelgaas>
From:   Lizhi Hou <lizhi.hou@amd.com>
In-Reply-To: <20231201224556.GA534342@bhelgaas>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Dec 2023 16:48:07.2877
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 77944529-0d4b-4470-5329-08dbf4e8cab7
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource: DS3PEPF000099D8.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4404
X-Spam-Status: No, score=-5.0 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 04 Dec 2023 08:48:22 -0800 (PST)

Here is the link I put in patch set cover letter

https://github.com/houlz0507/xoclv2/blob/pci-dt-0329/pci-dt-patch-0329/README

It has the steps I used to create and start qemu with pci bridges. 
Hopefully this helps.


Lizhi

On 12/1/23 14:45, Bjorn Helgaas wrote:
> On Fri, Dec 01, 2023 at 04:26:45PM -0600, Rob Herring wrote:
>> On Thu, Nov 30, 2023 at 10:57 AM Herve Codina <herve.codina@bootlin.com> wrote:
>> ...
>> Also, no idea if the bridge part works because my qemu setup doesn't
>> create bridges (anyone got a magic cmdline to create them?).
> I probably copied this from somewhere and certainly couldn't construct
> it from scratch, but it did create a hierarchy like this:
>
>    00:04.0 bridge to [bus 01-04] (Root Port)
>    01:00.0 bridge to [bus 02-04] (Switch Upstream Port)
>    02:00.0 bridge to [bus 03] (Switch Downstream Port)
>    02:01.0 bridge to [bus 04] (Switch Downstream Port)
>    03:00.0 endpoint
>    04:00.0 endpoint
>
>    IMAGE=ubuntu.img
>    KERNEL=~/linux/arch/x86/boot/bzImage
>    IMGDIR=~/virt/img/
>
>    qemu-system-x86_64 -enable-kvm -s -m 2048 $IMAGE \
>        -device pcie-root-port,id=root_port1,chassis=1,slot=1 \
>        -device x3130-upstream,id=upstream_port1,bus=root_port1 \
>        -device xio3130-downstream,id=downstream_port1,bus=upstream_port1,chassis=2,slot=1 \
>        -device xio3130-downstream,id=downstream_port2,bus=upstream_port1,chassis=2,slot=2 \
>        -drive file=${IMGDIR}/nvme.qcow2,if=none,id=nvme1,snapshot=on \
>        -device nvme,drive=nvme1,serial=nvme1,cmb_size_mb=2048,bus=downstream_port1 \
>        -drive file=${IMGDIR}/nvme2.qcow2,if=none,id=nvme2,snapshot=on \
>        -device nvme,drive=nvme2,serial=nvme1,bus=downstream_port2 \
>        -virtfs local,id=home,path=/home/,security_model=mapped,mount_tag=home \
>        -nographic \
>        -kernel $KERNEL \
>        -append "root=/dev/sda2 rootfstype=ext4 console=ttyS0,38400n8"