Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Jorge Ramirez-Ortiz <jorge@foundries.io>,
        "adrian.hunter@intel.com" <adrian.hunter@intel.com>,
        "ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
        "christian.loehle@arm.com" <christian.loehle@arm.com>
CC:     "jinpu.wang@ionos.com" <jinpu.wang@ionos.com>,
        "axboe@kernel.dk" <axboe@kernel.dk>,
        "beanhuo@micron.com" <beanhuo@micron.com>,
        "yibin.ding@unisoc.com" <yibin.ding@unisoc.com>,
        "victor.shih@genesyslogic.com.tw" <victor.shih@genesyslogic.com.tw>,
        "asuk4.q@gmail.com" <asuk4.q@gmail.com>,
        "hkallweit1@gmail.com" <hkallweit1@gmail.com>,
        "yangyingliang@huawei.com" <yangyingliang@huawei.com>,
        "yebin10@huawei.com" <yebin10@huawei.com>,
        "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] mmc: rpmb: do not force a retune before RPMB switch
Thread-Topic: [PATCH] mmc: rpmb: do not force a retune before RPMB switch
Thread-Index: AQHaJsLBZ2sxhOoGTkWiMOgXX6Cv0bCZaLEA
Date:   Mon, 4 Dec 2023 17:58:45 +0000
Message-ID: <DM6PR04MB657532850510D64BA7D62297FC86A@DM6PR04MB6575.namprd04.prod.outlook.com>
References: <20231204150111.3320071-1-jorge@foundries.io>
In-Reply-To: <20231204150111.3320071-1-jorge@foundries.io>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?kMYtAzUWArM41AuwhIpu0A5xx2/+P4rRGUuKwxNQlB66U2/Gq/NtFZDXNZ1P?=
 =?us-ascii?Q?z4utovpa9c35RXornFcanI7coXSSDNVcrtV+DxWQpXSBdl2GW39UfK7n+vI6?=
 =?us-ascii?Q?mmbvYOr85iyCzRhiZVj2pt7xUOK3Far+GFPY1FDtzK6ZqdJFnV8YayQfFCZR?=
 =?us-ascii?Q?uXjTYruxYcfTPq4n2gHvoImSExfwMTN/nLFaFutbzzfGOvTislwM/3XDs1bX?=
 =?us-ascii?Q?CC0uiS/90L8nffDdHbUtyALbcyGlB2J/Jh3Wxz5SB7LzOQjim88ttLMTC9SH?=
 =?us-ascii?Q?zx/66c9h0Uhy9pbvv7Ca7YBBlwMkXdNaflFcUvEoIfXcxR3EdZ/YkXshda7O?=
 =?us-ascii?Q?JhpFIFSG0NCEFFXftXPpBT2Vp1MgPX4yGiEBpsaGdA0UbveeNJ4JkmFli4Bf?=
 =?us-ascii?Q?BMRSCjib+ZWpJyj7V5hLlD61u03OGiz8sj3KnsjrIn14k32Nr3l3ZBHqiz82?=
 =?us-ascii?Q?+t1XXV8kttslzZ2YHW1A+H8Cf7mSXxLnfPtG7LHeUAtCnYW8XWYDxeIthYG8?=
 =?us-ascii?Q?JT3y69CDjAb3M8AXwsgZ+ySD5tCJHoj1DyFO77WuDmwh8V/hz1CqgMOES1JA?=
 =?us-ascii?Q?Ok88CDSq8rYfjnYwN1h6kY2Xv8itwoGEy6R69w7MhsDEDEmUiNCq6h7AjHsO?=
 =?us-ascii?Q?lRLhK2SdjBV+2EpJJ77r7yVNVEerb+evmJwiGaTMvpHVOLfuPKVMGqoxiEnc?=
 =?us-ascii?Q?7QhUpTVcikvi89MLu7czRoGivOOH85zDOMLJkiezOyDKox/Y4qVog1xCCs4+?=
 =?us-ascii?Q?gxf8QvctWGURu8sW1Zt9oOsIhUDBS0X0GXOFCPfFxSvlDj8rO/79jIiJOgUi?=
 =?us-ascii?Q?AGnW+3vrr/YS+lqnyFv0CWNA1Mf64qbWCA3GZdUZ6IhYr1UECwmMxeCElqL1?=
 =?us-ascii?Q?p99uzuDMk8lXb9FiMVJZMsnXs6fQQ6UsJOf66ob9/qLlAS6NWxcHo92Pvqhx?=
 =?us-ascii?Q?p4PFZh+JNuz4y/NpWYs6E+85I0ViY+o/534RB+bQzjnuKWLNUhtvHBiuE9cI?=
 =?us-ascii?Q?mNz3oyWXj67SmnP36Gw/cDBFibbDnlhtW9aOR9F0Pw3Rt8oZngvQaFpJJeV8?=
 =?us-ascii?Q?knGso/eZzDm6wtA7bD0Mum35UCp3zaQ2sqc26cKha6Y3lnmbvVboKdkMJtlX?=
 =?us-ascii?Q?xO0+ALY1TN3QM2cSFb9LYUuL7YiYAqHe+WvL4c4m4ZCTJ5euElkDxIkHgdGn?=
 =?us-ascii?Q?lDZoYbBiqTdZixwZ1j6AfoevVEMky2k4JEP6qaBY1rIrG2JK21TMCiSuOk+H?=
 =?us-ascii?Q?17nPm5oJbBWwMcS+KmVjukYyaFLk+IVu+sQmOVnone/ysjh8DiwpCabgStTr?=
 =?us-ascii?Q?MnOAHKfckV3cOxruIpKbihs7IeOjfHgTnHPyBNbMyi8TSY59Wjal0Bi/AqT0?=
 =?us-ascii?Q?C2yOmwSKIL+dx46bYE6c8LVX/7RB4qDS/FOcmC3A496tdqCE+OmQfF6ZazPU?=
 =?us-ascii?Q?Uae+hOmpCOvbdGlPVwZZlAQii+nKDNv4omV8KD3PKuBPjqUFzQkuoD5vI/9p?=
 =?us-ascii?Q?fEgQPrzBmJaZ/d6WHZmUsndLS8cNPpjHUqfIIJBNmA1yEO1zzKCvdjGTdB2j?=
 =?us-ascii?Q?ufw5LUv9e42dTeYrjRzQVmnCKxeeEH9RmDohsnlp?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?eYLec3vf+Jn7uGOm71C/wUFiM8G5iCyAq6zbrJyyJug6u331RBol7nYoe26y?=
 =?us-ascii?Q?70yqRQSmpflSF999syrF1TflgKa+tTP6IgYSYwm0R0GXkJBOmP58Lq8lIt4H?=
 =?us-ascii?Q?1mYWUe3QqvIf3Iz1fqsmthkf0jbLU/xPq+OKR8+5Rns5akzOWtApLaHFJg9W?=
 =?us-ascii?Q?S51Yq8yifJroDfbGzzELwXqPiKwhd8THOKX2dfzFznHQ68+dmP2fffkYoeRU?=
 =?us-ascii?Q?mW3eK8jy1Sil2Vs3OmpcmNVVJE0xQLevELRtX3yWnR0F2FekltITsCbmsD9N?=
 =?us-ascii?Q?HN6Lo5IsqRU4ShbVRBn0RY70HnSoo6atFx1sLbYWHKxqY0pA/Do4ttmAQ3e0?=
 =?us-ascii?Q?gBy/iKE8L9yDSS5FFpBhPIzIAWFo1QczPOwYvlYASv3udKf5DQJfN/4G7Rwl?=
 =?us-ascii?Q?Cgi4mbpgXj6HCMbLKI8bxCG3+VazZYpVzxwjVrnLbMXPn1HsVZ/MwQdUTCaT?=
 =?us-ascii?Q?iiXY0rf8wcrgm9nZ7z/b7zzwtV+GCz4/4H0e5N1PQ0GIKG8OBpKWxMRMbgeO?=
 =?us-ascii?Q?IBeTDRf3j3xaN5LKK3q3PBF9b7F7qsd++OZ2AR0AuCCJO80fGSKa1YVWOzFJ?=
 =?us-ascii?Q?KTVvE8LLq+UjBRITwzYlaVovmr81PXTDUVXKXXsSc70lcfp7JBGSxbMs7qqH?=
 =?us-ascii?Q?0Mmc+TQutTrzeyOkbQ4hfJGZeb9MF5yIzEJD4pW/ApDgmiVRojeVKdQ3ZYdc?=
 =?us-ascii?Q?q0DHCl7AKHigAcoyNmQMj83ZHHHUMuzxGdtjk6CVBuo0FhzlZWgeYoKsu55H?=
 =?us-ascii?Q?HhRJP+OsCzyaPG2TjL/XSek7nmAHEwIevk/N1f40jEl56nuiYPg0KmSJqaHy?=
 =?us-ascii?Q?mTNupJm3xncLpSAZJQNYwUvce9OMBM2x4GsD+P+n5eXuzf6Ffp2sOUfyTpGm?=
 =?us-ascii?Q?SXUzPyzruRdFOMlnSjO2mwOVwGY9Pl793T0wUQzFtivbp17E19XMgZuWnoY+?=
 =?us-ascii?Q?ZO/zK0w43bLyDTRFfU+A8SPYyHYSlCrsEJGdpiKrWkGWbCBPfaJZOisqIRn4?=
 =?us-ascii?Q?G4DFsoQ+Dyih2CRVBALIoHh4/kq5+kB/si4cFJ3URP16YrwV9wZv0uqb6mtl?=
 =?us-ascii?Q?CLBj+JbnVnaMzf9JGZeYu0XZyOBE+nVARSC613KO64pXiSANTMk=3D?=
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR04MB6575.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c9972b57-3de4-4b41-0fd9-08dbf4f2a8fe
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Dec 2023 17:58:45.7036
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: M+z9BWgnXjZZYsHmszzCMq0dPrkCXiuZjtCmEuh72DnKUz8V4AYI+Mhp0ZvKLBAA334z3FzBB7XfiP1gxo9+gw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR04MB8936
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 04 Dec 2023 09:59:10 -0800 (PST)

>=20
> Requesting a retune before switching to the RPMB partition has been
> observed to cause CRC errors on the RPMB reads (-EILSEQ).
>=20
> Since RPMB reads can not be retried, the clients would be directly affect=
ed by
> the errors.
>=20
> This commit disables the request prior to RPMB switching while allowing t=
he
> pause interface to still request a retune before the pause for other use =
cases.
>=20
> This was verified with the sdhci-of-arasan driver (ZynqMP) configured for
> HS200 using two separate eMMC cards (DG4064 and 064GB2). In both cases,
> the error was easy to reproduce triggering every few tenths of reads.
>=20
> Signed-off-by: Jorge Ramirez-Ortiz <jorge@foundries.io>
> ---
>  drivers/mmc/core/block.c | 2 +-
>  drivers/mmc/core/host.c  | 7 ++++---
>  drivers/mmc/core/host.h  | 2 +-
>  3 files changed, 6 insertions(+), 5 deletions(-)
>=20
> diff --git a/drivers/mmc/core/block.c b/drivers/mmc/core/block.c index
> f9a5cffa64b1..1d69078ad9b2 100644
> --- a/drivers/mmc/core/block.c
> +++ b/drivers/mmc/core/block.c
> @@ -859,7 +859,7 @@ static int mmc_blk_part_switch_pre(struct mmc_card
> *card,
>                         if (ret)
>                                 return ret;
>                 }
> -               mmc_retune_pause(card->host);
> +               mmc_retune_pause(card->host, false);
>         }
>=20
>         return ret;
> diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c index
> 096093f7be00..a9b95aaa2235 100644
> --- a/drivers/mmc/core/host.c
> +++ b/drivers/mmc/core/host.c
> @@ -119,13 +119,14 @@ void mmc_retune_enable(struct mmc_host *host)
>=20
>  /*
>   * Pause re-tuning for a small set of operations.  The pause begins afte=
r the
> - * next command and after first doing re-tuning.
> + * next command and, if retune is set, after first doing re-tuning.
>   */
> -void mmc_retune_pause(struct mmc_host *host)
> +void mmc_retune_pause(struct mmc_host *host, bool retune)
>  {
Since mmc_blk_part_switch_pre is the only caller of mmc_retune_pause,
How about just move those lines into it?

Thanks,
Avri

>         if (!host->retune_paused) {
>                 host->retune_paused =3D 1;
> -               mmc_retune_needed(host);
> +               if (retune)
> +                       mmc_retune_needed(host);
>                 mmc_retune_hold(host);
>         }
>  }
> diff --git a/drivers/mmc/core/host.h b/drivers/mmc/core/host.h index
> 48c4952512a5..321776b52270 100644
> --- a/drivers/mmc/core/host.h
> +++ b/drivers/mmc/core/host.h
> @@ -18,7 +18,7 @@ void mmc_retune_disable(struct mmc_host *host);
> void mmc_retune_hold(struct mmc_host *host);  void
> mmc_retune_release(struct mmc_host *host);  int mmc_retune(struct
> mmc_host *host); -void mmc_retune_pause(struct mmc_host *host);
> +void mmc_retune_pause(struct mmc_host *host, bool retune);
>  void mmc_retune_unpause(struct mmc_host *host);
>=20
>  static inline void mmc_retune_clear(struct mmc_host *host)
> --
> 2.34.1