Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Date:   Mon, 4 Dec 2023 14:29:28 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Yan Zhao <yan.y.zhao@intel.com>
Cc:     iommu@lists.linux.dev, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, alex.williamson@redhat.com,
        pbonzini@redhat.com, seanjc@google.com, joro@8bytes.org,
        will@kernel.org, robin.murphy@arm.com, kevin.tian@intel.com,
        baolu.lu@linux.intel.com, dwmw2@infradead.org, yi.l.liu@intel.com
Subject: Re: [RFC PATCH 12/42] iommufd: Introduce allocation data info and
 flag for KVM managed HWPT
Message-ID: <20231204182928.GL1493156@nvidia.com>
References: <20231202091211.13376-1-yan.y.zhao@intel.com>
 <20231202092113.14141-1-yan.y.zhao@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231202092113.14141-1-yan.y.zhao@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?EuvlWEih/bP9HMj4Cm1IzfPcmZVe7E6vnOS12CM0OnAqpNPMcZ3RXnMyqU3K?=
 =?us-ascii?Q?o6ZJJwkEkhQAKTSlW1DJ0cP/jI+5rb9oEYBGYJKInfdI9w2+Q9iF8/vIWZCW?=
 =?us-ascii?Q?8hOgfAe1AU6o/0e9Yr0kkFLmz476L3EPT2qh+urSvWyBECsWpMI/wWI1gStX?=
 =?us-ascii?Q?Kej2unlSbzNZ7nfCP+t8yxOcpv8/kH4LIZM9QRUlvNtYAZACJXcRrCaxs9UR?=
 =?us-ascii?Q?ziUlQGxj8OsjuiAW2BeRfvALIO7dvNtYnF4a5Ju3MLONW+CWYhRvjQ9qOrVY?=
 =?us-ascii?Q?0iYWDL0SwRhe1uAt9qTjezdMZ9N7Aoqa3EcS28WYlE8UyyNn2HtZa1Mj4xxH?=
 =?us-ascii?Q?DPvNABJZRoYmrvcOG3L+o8+afPVuYO2AxiYtfbjl3MOtafpDg15QjWyCbBiK?=
 =?us-ascii?Q?T5u+tmPKT9zcVZAlm6qAjrqDfttT0OnQqC5UhU9r3VmV9/B/fkDPMH2up2pw?=
 =?us-ascii?Q?MeDK+eweQivPYjDDDA8DuEUE6q6m0PT3HyJx/QyDunDRjsw/90adFUA6wJ7F?=
 =?us-ascii?Q?oymH7PpqARw+JoaTund7mKqFhONYotHD76CaI9jIV4GdLBbGGN0wtZX2sgCr?=
 =?us-ascii?Q?RH68U8i90QmMcZpOhHhfQjPPhIdTCQn6AiVOcHNH7pqC1F5JaPGRAShrEVZk?=
 =?us-ascii?Q?V2Vi/Kkc/z43vfLmWlnnO3z6xF16+HbRnQnCBT6b+OOq0pZLn7cC0mdCqAjD?=
 =?us-ascii?Q?D6K5t3MYkkLjFOzTpaFcLYO63YkXUTLpu9BEJgCT5x0WU6bSDahtduTdIEhD?=
 =?us-ascii?Q?pNPIVj+TVIHNzN+b10aX/LwzzCx9nPTsSqvLvJnBWQLhOt2WxLLI74YbHGrs?=
 =?us-ascii?Q?2EW1OBuJUHm/OXFNk4Tnv1sZZyRtYkBNC51fNkhLS/7sWw0+8W8n+BOlTCg0?=
 =?us-ascii?Q?Wly9F+5S77BSEN9R47xLPW2BeMbYiArsT43jYnTDpIZl3m5HOlnTU5k5TYoQ?=
 =?us-ascii?Q?8rw7W3rCD1WInCoixeO3/rCiDuSgY0bhNpB8RLdhdcw0uejA0+M+xBzEBDG2?=
 =?us-ascii?Q?WvF7Vkzlqt/qZiF0pivZmzzSZGlQGGf762/Fs3TpHKsb2Ef7jWy0oXLWg2ME?=
 =?us-ascii?Q?9acR+guIwXQCNby8Qarsa+lFtGZJ5uVdfcBgSQ2gofuqbBs8L0B+Hg/v8Wpy?=
 =?us-ascii?Q?srt6yuIcZqNJzsXK/TgQoYwrDsApPNnjOAR0DecR6cezJmCgmOfjkGrodyLY?=
 =?us-ascii?Q?fAhcE1yPXZWZ9axgTio0UcblKK9Wq2mhjmC6YF4hodMBUlH4O7EWo5Iijsv1?=
 =?us-ascii?Q?Ilymy4a11/7lGencvvI5OcoARFAWjiiAxD34j5JAu2YcsufXYpxTPDEhk2He?=
 =?us-ascii?Q?dwZuZFP3qePvwLb0vDt7vfMtlRWn+w4tkJ4N+jlK+rrT4fty11g5PhbTtFpx?=
 =?us-ascii?Q?Qazfb3nw2mnmXAYXRrYAtLMRjjGvsVUcxuLIH1UBax4wG5MOINAyLUYHgYK6?=
 =?us-ascii?Q?rAgmJeJKKbYHfkZLbLIIO2MFEAoMXTD7QDSCA7fYzQUg1qaLDO+QzhhtNa5F?=
 =?us-ascii?Q?AOy3w/0djkzOGRHXT3aKtl29XLHTnjNGMdO0yWsqta5kPYsMXb1TCpA4nPTL?=
 =?us-ascii?Q?9ho8oUO5YfttHIGriobJ56OFSQuiYTlg0DpPtSP0?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4999aedc-1ad9-4e8b-020d-08dbf4f6f3f8
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Dec 2023 18:29:29.6392
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4f0TNdN/QT4tOOho5IQfwBIkemQRAKuU0cB/oyWX5iXq9EtHvTE5rFSn10Qg1hdD
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6489
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 04 Dec 2023 10:29:41 -0800 (PST)

On Sat, Dec 02, 2023 at 05:21:13PM +0800, Yan Zhao wrote:

> @@ -413,11 +422,13 @@ struct iommu_hwpt_arm_smmuv3 {
>   * @IOMMU_HWPT_DATA_NONE: no data
>   * @IOMMU_HWPT_DATA_VTD_S1: Intel VT-d stage-1 page table
>   * @IOMMU_HWPT_DATA_ARM_SMMUV3: ARM SMMUv3 Context Descriptor Table
> + * @IOMMU_HWPT_DATA_KVM: KVM managed stage-2 page table
>   */
>  enum iommu_hwpt_data_type {
>  	IOMMU_HWPT_DATA_NONE,
>  	IOMMU_HWPT_DATA_VTD_S1,
>  	IOMMU_HWPT_DATA_ARM_SMMUV3,
> +	IOMMU_HWPT_DATA_KVM,
>  };

Definately no, the HWPT_DATA is for the *driver* - it should not be
"kvm".

Add the kvm fd to the main structure

Jason