Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp2905587rdb; Mon, 4 Dec 2023 10:37:00 -0800 (PST) X-Google-Smtp-Source: AGHT+IF/5ZQlY7EWAcRyv283tYhw6Z4wk+zr+TEOkq5+bhnf92UbRg9XLrAYHgeqj20Z+AToBUoT X-Received: by 2002:a17:902:e5c3:b0:1d0:7165:3fa0 with SMTP id u3-20020a170902e5c300b001d071653fa0mr2099154plf.1.1701715020066; Mon, 04 Dec 2023 10:37:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701715020; cv=none; d=google.com; s=arc-20160816; b=U18I7nkwBjETCKUWWHzVkrmxeVA/jH6PjgJ7echtELy8jAcYnrv05/nx5KfBrWnWvZ rQrzgZmlTIOarbJ+94u85PsN2cic4+nPs0Jk+r+CdznVHRKl6J2yz/YRu2jPClyfPZLc e+zrBDTktOtvPeHZFkDrurWMG0VVdOq4EQMvokER2qwqRWzcCyuk33fawxCTtCyvFu0s yVsmotsYHy4RaNMikXaKsLp0Dc01Zgc9kblyniTqromJctz3qDQYIb54ubd2CKEIchRf Wl9GR+NufgX8EOL8qgKOoLY2NpSgw/W60WTyN4QF7GBf5MdZr2bJ7UT/+KXqj3Urx4AX bIYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=M5LHBuAa6FWzcHkZVs57gyTemsJt091/7qmYU/qEKTo=; fh=NLPEO50t7TpacebmUaWI6HE+zsRq7crqTuiCMg91mPo=; b=STNp1PRgA9DuGfCf7tagUWRr0ZiSe3mU77z2TKR3LfoUPZmbcrSQCHyFKKOpyds5U6 CIQL1pjfFD98D2/PoDehngwm2JT1x3MFPF05ssnKrDy9QTGjPvupGxTM76EMTLVdHkDU ZLBXaXretJMWj23PE9vAta3xhlX3UOUP9q4GK/nDGUQizEZZeUUqKREpttaWjVNkaaGP +JDrQG3DVQe6rRwNxqAq/Ob7lum6Vz1MLtpTqYfRyW3yWYQ6O0a7mVoQN6/XExDb6G3u nZkarinJwNLJe6khbkZyuRRonQo1jJ2M6xh5c/ZhaW8a5qClKsHgnLBGhhURPjnb0Wng 5ZOg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id t5-20020a170902b20500b001d08d307f89si2858450plr.496.2023.12.04.10.36.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 10:37:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 886EA809B777; Mon, 4 Dec 2023 10:36:57 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231435AbjLDSgn (ORCPT + 99 others); Mon, 4 Dec 2023 13:36:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60024 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230479AbjLDSgm (ORCPT ); Mon, 4 Dec 2023 13:36:42 -0500 Received: from mail11.truemail.it (mail11.truemail.it [217.194.8.81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A73ADFF; Mon, 4 Dec 2023 10:36:45 -0800 (PST) Received: from francesco-nb.int.toradex.com (31-10-206-125.static.upc.ch [31.10.206.125]) by mail11.truemail.it (Postfix) with ESMTPA id 10075207C9; Mon, 4 Dec 2023 19:36:42 +0100 (CET) Date: Mon, 4 Dec 2023 19:36:40 +0100 From: Francesco Dolcini To: Nishanth Menon , Rob Herring Cc: Francesco Dolcini , Vignesh Raghavendra , Tero Kristo , Krzysztof Kozlowski , Conor Dooley , Joao Paulo Goncalves , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Francesco Dolcini Subject: Re: [PATCH v2 3/3] arm64: dts: ti: add verdin am62 mallow board Message-ID: References: <20231201145551.23337-1-francesco@dolcini.it> <20231201145551.23337-4-francesco@dolcini.it> <20231204181336.scm2fgfyyzpr2u7t@dimmer> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231204181336.scm2fgfyyzpr2u7t@dimmer> X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 04 Dec 2023 10:36:57 -0800 (PST) Hello Nishanth, On Mon, Dec 04, 2023 at 12:13:36PM -0600, Nishanth Menon wrote: > On 15:55-20231201, Francesco Dolcini wrote: > > From: Joao Paulo Goncalves > > [...] > > > + > > + tpm@1 { > > + compatible = "infineon,slb9670", "tcg,tpm_tis-spi"; > > arch/arm64/boot/dts/ti/k3-am625-verdin-nonwifi-mallow.dtb: /bus@f0000/spi@20110000/tpm@1: failed to match any schema with compatible: ['infineon,slb9670', 'tcg,tpm_tis-spi'] > arch/arm64/boot/dts/ti/k3-am625-verdin-wifi-mallow.dtb: /bus@f0000/spi@20110000/tpm@1: failed to match any schema with compatible: ['infineon,slb9670', 'tcg,tpm_tis-spi'] > > We should either drop this node OR introduce bindings and later > introduce this series. > > Yes, I know there are other places where the compatible is already used > arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dts > arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dts1G > etc.. But, unfortunately, I'd rather see the binding > Documentation/devicetree/bindings/security/tpm/tpm_tis_spi.txt > transition over to yaml prior to picking things up. (NOTE: the same > rules apply to TI devs as well..) I disagree (and I also know that in the end is your call to take patches or not and I will just accept your decision whatever it is). What you are asking here is to not use any binding that was not already converted from txt to yaml, I do not think it is fair to force this decision just for TI DT files. I'd like also to add that a conversion to yaml of this binding is in the work [1] and this DT is compliant with it. What's DT maintainers opinion on this matter? Rob recently provided feedback on TPM bindings txt to yaml conversion so it should be fresh on his mind. Francesco [1] https://lore.kernel.org/all/cover.1701093036.git.lukas@wunner.de/