Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Message-ID: <590ade27-b4da-49be-933b-e9959aa0cd4c@acm.org>
Date:   Mon, 4 Dec 2023 11:00:36 -0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH V2 1/3] ufs: core: Add CPU latency QoS support for ufs
 driver
Content-Language: en-US
To:     Maramaina Naresh <quic_mnaresh@quicinc.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Peter Wang <peter.wang@mediatek.com>,
        Manivannan Sadhasivam <mani@kernel.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>, chu.stanley@gmail.com
Cc:     Alim Akhtar <alim.akhtar@samsung.com>,
        Avri Altman <avri.altman@wdc.com>, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
        linux-arm-msm@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, quic_cang@quicinc.com,
        quic_nguyenb@quicinc.com, Nitin Rawat <quic_nitirawa@quicinc.com>
References: <20231204143101.64163-1-quic_mnaresh@quicinc.com>
 <20231204143101.64163-2-quic_mnaresh@quicinc.com>
From:   Bart Van Assche <bvanassche@acm.org>
In-Reply-To: <20231204143101.64163-2-quic_mnaresh@quicinc.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/4/23 06:30, Maramaina Naresh wrote:
> +	u32	(*config_qos_vote)(struct ufs_hba *hba);

Please remove the above callback since this patch series does not
introduce any instances of this callback.

> +
> +	/* This capability allows the host controller driver to use the PM QoS
> +	 * feature.
> +	 */
> +	UFSHCD_CAP_PM_QOS				= 1 << 13,
>   };

Why does it depend on the host driver whether or not PM QoS is
enabled? Why isn't it enabled unconditionally?

> + * @pm_qos_req: PM QoS request handle
> + * @pm_qos_init: flag to check if pm qos init completed
>    */

Documentation for pm_qos_init is missing.

>   struct ufs_hba {
>   	void __iomem *mmio_base;
> @@ -1076,6 +1089,9 @@ struct ufs_hba {
>   	struct ufs_hw_queue *uhq;
>   	struct ufs_hw_queue *dev_cmd_queue;
>   	struct ufshcd_mcq_opr_info_t mcq_opr[OPR_MAX];
> +	struct pm_qos_request pm_qos_req;
> +	bool pm_qos_init;
> +	u32 qos_vote;

Please rename "pm_qos_init" into "pm_qos_initialized".

Thanks,

Bart.