Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
MIME-Version: 1.0
References: <20231204180428.925779-1-jaegeuk@kernel.org> <20231204180428.925779-3-jaegeuk@kernel.org>
In-Reply-To: <20231204180428.925779-3-jaegeuk@kernel.org>
From:   Daeho Jeong <daeho43@gmail.com>
Date:   Mon, 4 Dec 2023 11:03:06 -0800
Message-ID: <CACOAw_xo_73xxqUty_2e6mvPA8A45MXEefOe8gr7f7owU1XuXQ@mail.gmail.com>
Subject: Re: [f2fs-dev] [PATCH 3/4] f2fs: check write pointers when checkpoint=disable
To:     Jaegeuk Kim <jaegeuk@kernel.org>
Cc:     linux-kernel@vger.kernel.org,
        linux-f2fs-devel@lists.sourceforge.net
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

LGTM

On Mon, Dec 4, 2023 at 10:06=E2=80=AFAM Jaegeuk Kim <jaegeuk@kernel.org> wr=
ote:
>
> Even if f2fs was rebooted as staying checkpoint=3Ddisable, let's match th=
e write
> pointers all the time.
>
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
>  fs/f2fs/super.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index 617340e9ea7f..9a874b4d1501 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -4741,7 +4741,7 @@ static int f2fs_fill_super(struct super_block *sb, =
void *data, int silent)
>  #ifdef CONFIG_QUOTA
>         f2fs_recover_quota_end(sbi, quota_enabled);
>  #endif
> -
> +reset_checkpoint:
>         /*
>          * If the f2fs is not readonly and fsync data recovery succeeds,
>          * check zoned block devices' write pointer consistency.
> @@ -4752,7 +4752,6 @@ static int f2fs_fill_super(struct super_block *sb, =
void *data, int silent)
>                         goto free_meta;
>         }
>
> -reset_checkpoint:
>         f2fs_init_inmem_curseg(sbi);
>
>         /* f2fs_recover_fsync_data() cleared this already */
> --
> 2.43.0.rc2.451.g8631bc7472-goog
>
>
>
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel