Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp2943556rdb; Mon, 4 Dec 2023 11:45:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IF6kezOH0JgJJcoV9KPjOFQ24Ga6kOhCtWLNMU4sM5EzyxdjH2woR7OMRoRkJq9xB++Et1m X-Received: by 2002:a05:6a21:99a6:b0:187:449d:a4cd with SMTP id ve38-20020a056a2199a600b00187449da4cdmr320739pzb.27.1701719153050; Mon, 04 Dec 2023 11:45:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701719153; cv=none; d=google.com; s=arc-20160816; b=EwxTbp63XUB+35mCerm5A6T3EEVmHJt/0zxgPhKiy3BLt6LY8D8dkgNdb9ph2BarN7 8yJ2WWydR1F/0LauKwTlMHuvgHkdh7nMC65R76VexCwnQUwEr46kmVX25103nThFfJuH cLd/MnW6M3saV6WiAMOquo4RJsoYfMKijSGnZeef0HtTnfcI6wunaGxL5kzSBjUVterj NESMlQP36KUsIoK5RdYS0v0bJ4RW/lO618ZUY0e5CYlBKBSSY14OzqV9bpT/Gu5woR6a XIgQlqcR0FtrVDgynjiT/t4d7HN1d2wQFpx5GV0tClwVvU9CA15rzYGAcqJKnbTcbNKv dXYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=YFRltyOlPrtK2/nzyDSKbMxhl1Sh0Gq+FgnFo2iAXeU=; fh=eeO0VUhvo+p4nPWV4TmmNwZgZO7Uq2dYTV8TFZfi3KI=; b=poyrFpOonacAeKg6s6iSGC2Ld/ADetp/+3acrLXadHscjc92VtZNUpF/W02tHvX3ly r8NBYI83wM20Znvi6Hwjz7Y9rJruit7ZNoNtjBM5jg6oM4YiY6MwAKHh4Gs0Cq/3Ft+a 9ZiqMKJZsrz03Il96QBETmJSytRoS8V3iL5wU0D6yPD2Q2SQpNnHSuwyIU+Ls6errtM3 P75ayPh4q+ra+naUwn/7iX7O9biaMKDHSXb2y/6MvVTb0fbjrayv6kS9E6b3YeQVmPT1 eJ09C6AOEpnDhSmPKy4OjT8R/2s45EWwzCsb3XxiDksHGMVrT1XobGjjue3ZwQpCTJy1 V73A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gGXRVCA0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id fj32-20020a056a003a2000b006cde1b8b490si8289803pfb.168.2023.12.04.11.45.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 11:45:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gGXRVCA0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 95826807C859; Mon, 4 Dec 2023 11:45:32 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344404AbjLDTpJ (ORCPT + 99 others); Mon, 4 Dec 2023 14:45:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234070AbjLDTpF (ORCPT ); Mon, 4 Dec 2023 14:45:05 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54EE3111 for ; Mon, 4 Dec 2023 11:45:12 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B37DAC433C7; Mon, 4 Dec 2023 19:45:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701719112; bh=cmGhT0rNZ8LRt6ST5YFsV1NE54yYUY00lCLWNdQsFgo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gGXRVCA0+iQuobeTpTbatvmMNWDlV2ejifzBvETIsWwdTTjvnmZNpjC5Omy4HGaC7 lDCafimFWTXVKXtt94KdMYS8y5mw1VZIpPtS5vYwhBs6ccqVZQwuBoZXbIhfQdd5TB 11+Jj9jvM9675zlKJYG4w2NZrsHQKSx5qzBqOOauJEKZKS0yRkkLR3w3fjhgSc3J0F SvhJAnmrX3n2o1cL5jEb8vnbgDtTvFJnCQvKub/KIibBdAq2b7/ziqu8x08M0zPM6S ypkKdF78WRzolsLYaYGZe7ZdFX8JfGO4rZcluZOD9cLJ2aYTZq8ICyWaqEbgeZSSgR 1ulzzNB5V7U+g== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 1567A40094; Mon, 4 Dec 2023 16:45:09 -0300 (-03) Date: Mon, 4 Dec 2023 16:45:08 -0300 From: Arnaldo Carvalho de Melo To: Athira Rajeev Cc: Ian Rogers , Namhyung Kim , James Clark , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Adrian Hunter , Kan Liang , LKML , linux-perf-users Subject: Re: [PATCH v2 1/4] perf build: Shellcheck support for OUTPUT directory Message-ID: References: <20231129213428.2227448-1-irogers@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Url: http://acmel.wordpress.com X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 04 Dec 2023 11:45:32 -0800 (PST) Em Fri, Dec 01, 2023 at 11:49:59AM +0530, Athira Rajeev escreveu: > > > > On 30-Nov-2023, at 3:04 AM, Ian Rogers wrote: > > > > Migrate Makefile.tests to Build so that variables like rule_mkdir are > > defined via Makefile.build (needed so the output directory can be > > created). This requires SHELLCHECK being exported and the clean rule > > tweaking to remove the files in find. > > > > Change find "-perm -o=x" as it was failing on my Debian based Linux > > kernel tree, switch to using "-executable". > > > > Adding a filename prefix of "." to the shellcheck log files is a pain > > and error prone in make, remove this prefix and just add the > > shellcheck log files to .gitignore. > > > > Fix the command echo so that running the test is displayed. > > > > Fixes: 1638b11ef815 ("perf tools: Add perf binary dependent rule for shellcheck log in Makefile.perf") > > Signed-off-by: Ian Rogers > > Hi Ian, > > Changes looks good to me. > Tested with make, make clean, make with shellcheck error, make with NO_SHELLCHECK > > Reviewed-by: Athira Rajeev Next time please reply with your Reviewed-by to the cover letter, so that b4 stamps your reviewed-by to all the patches and not just to the patch that you replied to. This time I'll take the plural in "Changes look good to me" to signify that you reviewed the whole series, ok? - Arnaldo