Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp2947778rdb; Mon, 4 Dec 2023 11:54:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IGCwLwZ7525CLhTCFK/x4Kkh+qSLXoDSW+x33F7qVdDkcLjnmcniHr5qCFfLXHNGMBFMPbI X-Received: by 2002:a05:6a21:3293:b0:18b:3c54:e6d8 with SMTP id yt19-20020a056a21329300b0018b3c54e6d8mr2707646pzb.39.1701719683021; Mon, 04 Dec 2023 11:54:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701719683; cv=none; d=google.com; s=arc-20160816; b=Ab+RSgRLIcEdkoaqKnr0nP96DjOA44T2NedseOptRM9UxPhZ3HN0QFuDl+BrsstoeG vxC67J7dZz1dSe1HLOtgGVJtMfQtlt2Xa8nv2zbYbQY8v9BnS9dm8O99dTmjcoQaPGYh 6sc4mVOHLSwTafMCIgorYPXznh7uLsV5lxbZK9bX0Cf6mLgHflw5BXNtbKkqLBxPshVS WX9phpkeqhBfkWWfHkmPrjv8TH9KvXGrvqeervVg97oGjSkhi8ClIU9UNJraq3CIGQEg f55yO7GcKCvxX019Cim/obVziuIMoSnokcBNXz2qDYAdTxwxLWBBoNoc6DtgdyIGPua2 2Eyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=xSDyHZbgfMpfmtjpu3gf1dpo6B/sHbuEuqoPklbpWFU=; fh=ynaqbgsJYrCYlVSQQTAr7qd1CHeaorTM5heafnUHBfg=; b=LiLajIqMXFytFyUQ/jC86SYHRvBPTrNXhtZdjAIMoF7/Km7brqFcVF59QpFp7RwUt4 P72oO9RCcmv7v86T4y6m0hSeElOhV0wVPhS0dI1RUQS34BoP9avBsMydMlvhrYHov97U Ao7Q4puVdBwMsrFtns1hECxAqL0YJr12ly0NTEX6bMZEut/H3wFRpc3l0Fj545XJ29pc Iy+TL6IH17u8rVmADLeiYv2Y4eCn+XGzPXfJy/giJnhi/CSAdkjK2nLiqQdkzWBN8C2u GGQ6XQ3of87ONXh2Tfzb1aE2rCyxjaiC6dJSRFadqNnLGW5WgrU0zRZxOPW6i7M0CDji hBRQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b="C+Jkfrq/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id a1-20020a056a001d0100b006cdd1aed274si8372697pfx.349.2023.12.04.11.54.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 11:54:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b="C+Jkfrq/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 6A0FD809E215; Mon, 4 Dec 2023 11:54:39 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232848AbjLDTy1 (ORCPT + 99 others); Mon, 4 Dec 2023 14:54:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229983AbjLDTy0 (ORCPT ); Mon, 4 Dec 2023 14:54:26 -0500 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B2E7E6 for ; Mon, 4 Dec 2023 11:54:32 -0800 (PST) Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-40b35199f94so12745e9.0 for ; Mon, 04 Dec 2023 11:54:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1701719671; x=1702324471; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=xSDyHZbgfMpfmtjpu3gf1dpo6B/sHbuEuqoPklbpWFU=; b=C+Jkfrq/NVra1BpqJgXDn626lGxFATBY10SfwGx+TZXs6ycCjL0FZFx88Cfa+ogfoY qc/Bz42nnYTEeoZRC0DHTRFUWGt6yBU6RNzkF21GTvjp36lWheRja8Y+E4fy6qnJkABn cd8c2KyqMZuKDITIwgW5Fn6NWHJ9v1VMS4QcCV5oFbn5VVodcEN5D8sDb9PLDEisx+ct ZvBYwLH1s4dN5w5+yfFZCFL+OdwBkUGZTYpq0G4mgAYX02LN+WBan5kg4DG+zgNXMCtj QAYqHxuh295Wmf7lxU3luEGB8v3b3KxfGuJFEGpGkh5uvNTUsXzEUTcj8CtWseR6o8G7 +5UA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701719671; x=1702324471; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xSDyHZbgfMpfmtjpu3gf1dpo6B/sHbuEuqoPklbpWFU=; b=iSJZSdh9R8Sa6E0V3PJS1Sv+ZLCdFMnP8JLkFu3XIwMUopGcrjog3T6adKBN3KWHrQ Posm8psHcWQQe3bt9do1cly8zc0/q61JzHoRRHxFnVeDU1U7mSQO6v2CW0yIXkSrjFCv STUXI5/uZn2SjHWlkdtq3sRC+F5Pp5rGbG2t2xS8mtgiVLAIQDJa0W34feXbnxkG1hq1 rbvLSDPl0lUXcfw9oWAJSIft3ua2JqtifjKhtrFNBiPVqZVdIP9+JkHVIAiZEpq2Wgr+ RXConxF1x6c7uIeqoYcRXMuJqIzkHp91uxg7acZBUS4XLOvFiznyPPLxY7lk1nBgu1gc 3oFw== X-Gm-Message-State: AOJu0Yy8htUXRNT/rM63Rqq4VM6rxO41W7QUEcJ1RcvlNVL6bY/0U/iU OT8iqkZaedGY/cYfaht39lSzLoNwCX4EuVhCC8WK3Q== X-Received: by 2002:a05:600c:6014:b0:40b:33aa:a2b9 with SMTP id az20-20020a05600c601400b0040b33aaa2b9mr466051wmb.4.1701719670907; Mon, 04 Dec 2023 11:54:30 -0800 (PST) MIME-Version: 1.0 References: <20231204185943.68-1-yx.0xffff@gmail.com> In-Reply-To: <20231204185943.68-1-yx.0xffff@gmail.com> From: Eric Dumazet Date: Mon, 4 Dec 2023 20:54:19 +0100 Message-ID: Subject: Re: [PATCH] net: ___neigh_lookup_noref(): remove redundant parameters To: YangXin Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-8.4 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 04 Dec 2023 11:54:39 -0800 (PST) On Mon, Dec 4, 2023 at 7:59=E2=80=AFPM YangXin wrote: > > key_eq() and hash() are functions of struct neigh_table, so we just need = to call tbl->key_eq() and tbl->hash(), instead of passing them in as parame= ters. > > Signed-off-by: YangXin Not sure, this might defeat inlining.