Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp2964638rdb; Mon, 4 Dec 2023 12:26:01 -0800 (PST) X-Google-Smtp-Source: AGHT+IEd+KLBdO1OH0ziaL36M+/LzL8bOSU2TMHr9moToKYXwQe09AyZDgBwpYcBFVJfAYBGmSe9 X-Received: by 2002:a17:90b:4b01:b0:286:cd05:fd78 with SMTP id lx1-20020a17090b4b0100b00286cd05fd78mr139095pjb.65.1701721561292; Mon, 04 Dec 2023 12:26:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701721561; cv=none; d=google.com; s=arc-20160816; b=waS+RopGPu1BasuIGEr16g0DzhR3u7UGNacmij3AehbDTkjTYA7lcgtjgwAa1zBI8l co46krA4l0wvNHwzMuZy653pql7vf1kOBQqQGLDjMr9C9Tz4myn/P2zIyJodzF5Tfrmd 6+jsRr5n5Fsxh3zatNx5O7iX4SSHWNAO4Kzr9+VctR0SG0N1Kn1U1YDlhDXZC9SSerH0 lMaabnqn1VfeuxIqaYDllHxc1QkWynE7jPjc75yYEQLK5U8unqdzYvRqHbrV3OMe7Wsx nGwgqR/AoPiokZmgySKjXXZgE96JyITxS9SnLlHCnbHVNmQ9mFwifcyO1cScuBVTSG85 d92A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=VoyLD+BBBgnkOe7m+0wyGjQqsPNxrHuUW5al5xZbTeg=; fh=pmccXjaZZepSuTIfl/oOwNxIKwXAf3f6Bcw6Yi0HENU=; b=v/UtpySH1MY535Ccf5hryrw0tiypSWcDyCH+oq3PZEYBpxz6JbKe740Ys3gPxYzHo+ WwohS7nid0tIT387PTiqttiCgtO/TsxQJYJkjmEoudBGJCYEDzRDxP9klg3oNZKABL9b SYkA6ywNNeChVeGqLTohDCNYIwFHHBWbN2t8p2XQAa5rVklp5KDiBw3H8kSMwqpxzAr5 RZ0CrwCELp2SRS0+xxONTooQ/wr7UjIbNKh8uQHi4OU83LT0c3Cj+aB/z+4Z1K2kDLeY 3ARHo3mZC0J4Ndn3sNd1a3nWp+fpx67HKt2/oD3C16N80pWiuJBCbI/PAqgGBs9ODMOe qfCg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=m9woum7u; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id k29-20020a63561d000000b005c24211ca87si7954693pgb.243.2023.12.04.12.26.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 12:26:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=m9woum7u; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id DD374806990A; Mon, 4 Dec 2023 12:25:50 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345531AbjLDUZg (ORCPT + 99 others); Mon, 4 Dec 2023 15:25:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235350AbjLDUZd (ORCPT ); Mon, 4 Dec 2023 15:25:33 -0500 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1DD9CCB; Mon, 4 Dec 2023 12:25:39 -0800 (PST) Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3B4JxZT6028697; Mon, 4 Dec 2023 20:25:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=VoyLD+BBBgnkOe7m+0wyGjQqsPNxrHuUW5al5xZbTeg=; b=m9woum7ukhrKgy2DlbVkq2m+pO/zRkSoTjp2rBy2klcmFL8JYacLW70LiypX0MjSaxe+ ORDAuC/8DKWmhkalXAUKTu2SA47IkuEPd0mc2rwoUdUrVJiGJSGBUkg1oTFYtbKqPEIN VeCLf4ejhodQk8ZLMYW0T1ezbKVXmSCvRqt9kP5OY+dCvBXtuMeP7JGAXvzaPst1BNY4 h19w4vMysFfhbAPHPvH2pMs7L63NGP6OgbkK1xVAYvmqozBrhYJtBI6RIcxk1ZFSix4O N0dENhlm2jcdlu8D5N6nMqlXYevBZWAmEIi7GJPf/nvhHL0WwrM8T9hDS29ca1QPPZEF mQ== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3usjnqgfdc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 04 Dec 2023 20:25:18 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3B4KPHqF006340 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 4 Dec 2023 20:25:17 GMT Received: from [10.71.109.77] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Mon, 4 Dec 2023 12:25:17 -0800 Message-ID: <230fd6a4-c1d6-64af-1073-2effd5d44d8c@quicinc.com> Date: Mon, 4 Dec 2023 12:25:16 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [Freedreno] [PATCH next] drm/msm/dp: add a missing unlock in dp_hpd_plug_handle() Content-Language: en-US To: Harshit Mogalapalli , Rob Clark , Dmitry Baryshkov , "Sean Paul" , Marijn Suijten , "David Airlie" , Daniel Vetter , Bjorn Andersson , Kuogee Hsieh , "Vinod Polimera" , Stephen Boyd , , , , CC: , , References: <20231204171317.192427-1-harshit.m.mogalapalli@oracle.com> From: Abhinav Kumar In-Reply-To: <20231204171317.192427-1-harshit.m.mogalapalli@oracle.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: f2EGCVjZ2PkGJvnv8FbQ_bzpg_EP3lOK X-Proofpoint-GUID: f2EGCVjZ2PkGJvnv8FbQ_bzpg_EP3lOK X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-12-04_18,2023-12-04_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 lowpriorityscore=0 clxscore=1011 mlxscore=0 suspectscore=0 priorityscore=1501 spamscore=0 impostorscore=0 mlxlogscore=999 phishscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2312040159 X-Spam-Status: No, score=-5.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 04 Dec 2023 12:25:51 -0800 (PST) On 12/4/2023 9:13 AM, Harshit Mogalapalli wrote: > When pm_runtime_resume_and_get() fails, unlock before returning. > > Fixes: 5814b8bf086a ("drm/msm/dp: incorporate pm_runtime framework into DP driver") > Signed-off-by: Harshit Mogalapalli > --- > This is based on static analysis with Smatch. Only compile tested. > --- > drivers/gpu/drm/msm/dp/dp_display.c | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Abhinav Kumar