Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp2985785rdb; Mon, 4 Dec 2023 13:09:33 -0800 (PST) X-Google-Smtp-Source: AGHT+IF9zMha+bcOjTmBfUI0YcQr16rHEufqSLw3wXOsLAJ5KikzOHtI/dvKKQq5pn27e3KYdDcc X-Received: by 2002:a05:6a00:1256:b0:6ce:53f6:1ee1 with SMTP id u22-20020a056a00125600b006ce53f61ee1mr216467pfi.15.1701724173443; Mon, 04 Dec 2023 13:09:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701724173; cv=none; d=google.com; s=arc-20160816; b=ZO5c2+LRKWN+thgF4xuhjck6bVaJ0GqQqa1Zycz9Dh1MsqdRnrYPx6RSP3e3hR8j+h 6jRKhbj4U0ZYjXxDjyxcTGSBoCBRnuIA2HJlYpgK/cjEqOpfa+VDLKTukUXWf21stVjh Ptq6rlgbXLOE9M/qkLjVLYbFyOZ7d7PqZO5HKwYg1nvBdjnmLdO54jTWwCMcnciw+NdQ zNv4GpJz4GeFKe4ACf+ZGn6D16yeKbWaHyotv4W3pL9oGRTiMdR/HgdtYFQB5ZGPbDrH 2qexe18z77QX7CTfsm5WJorNvwXDbAAfjsewKMN6f85flfx9ewXCPcxDSEF9grFHcfQU 1Uyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=ZJ07lndy76d9gS4R7X0S8rAF7kHSG+PjJVCZOnj+lsY=; fh=NLsHMCkW9oUPGVAUwi4YjxY06qY4Y90bV6UHFXN6ohE=; b=ecIlLQAJZlqQzITJAcDX0GqH8V2UfHhy/QF2cNHOebEqeqMSawGaT2Raz+/WFIoFG6 JxAxhsrnBYQfetEWZORPWGGbNYatFIHCbvhVqHNVJrcCZLlF+VLwah0eowZdQOxXkOUg z/+DHkVCEy63Fzc+zmbEweOJ1rD4hNvdzh6QDmUkOvxLecAd3WJ8+ZEx6Xou+F7XnqKk z9QjuxL4Cu25hgLiKsctaFEH3VPdx9c7GA/jTQRBlv+C/iUEaJKkPHN9d/oaeXGe5Fy0 95m0BqWcw6MJQtkAehQgq0vdVXOn5/jsEZFbtjmp/zinjFoMJf8FpaDny5LM9zNkB+Z4 lKpw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=GPRHEWTH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id bq10-20020a056a02044a00b005bdfd3a26a0si2907777pgb.584.2023.12.04.13.09.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 13:09:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=GPRHEWTH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id AC9D1805B060; Mon, 4 Dec 2023 13:09:30 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231549AbjLDVJR (ORCPT + 99 others); Mon, 4 Dec 2023 16:09:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229741AbjLDVJQ (ORCPT ); Mon, 4 Dec 2023 16:09:16 -0500 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C196090; Mon, 4 Dec 2023 13:09:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701724163; x=1733260163; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=g6e51FNxp+1EJ+cdgD2Lf4wIB+ZA4EpMDcO10MdBrfg=; b=GPRHEWTHFN4sV7h4PFc9DPWRKennUQO3dBUJDgcprfIvsaM1J3oKqH3i BBAZSul3jaqFUtEwDdp9ipoLlt89RUz/dLzEjNs/Llv3tVwtPDiL8/kMU 4oqis3HUonyNJTrgtHGzbiwYNyEFnwT0dxigJMHB+KJPAjneBlAff0IlD +Z2Vedtj71YKbT60Jjb0a7tMwpqkWC3b40kQqAMDCThF8csvuMSQ51e9F ZU12hlNM34FD0C5TxNHndozEhkhOzYgXvncVTWQ3gskPq86CB8ZC6lfwR jF0dt/brdiGlrUJ7xT5K9MX9EWGfkEJ6Wtn5T0SvZwuC9FBGb2sa2t+KM Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10914"; a="7125771" X-IronPort-AV: E=Sophos;i="6.04,250,1695711600"; d="scan'208";a="7125771" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Dec 2023 13:09:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10914"; a="764097433" X-IronPort-AV: E=Sophos;i="6.04,250,1695711600"; d="scan'208";a="764097433" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga007.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Dec 2023 13:09:19 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rAGBo-00000001swh-2DtU; Mon, 04 Dec 2023 23:09:16 +0200 Date: Mon, 4 Dec 2023 23:09:16 +0200 From: Andy Shevchenko To: Petre Rodan Cc: linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Jonathan Cameron , Lars-Peter Clausen , Angel Iglesias , Matti Vaittinen , Andreas Klinger , Rob Herring , Krzysztof Kozlowski Subject: Re: [PATCH v7 2/2] iio: pressure: driver for Honeywell HSC/SSC series Message-ID: References: <20231204194401.20891-1-petre.rodan@subdimension.ro> <20231204194401.20891-2-petre.rodan@subdimension.ro> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 04 Dec 2023 13:09:30 -0800 (PST) On Mon, Dec 04, 2023 at 11:06:03PM +0200, Andy Shevchenko wrote: > On Mon, Dec 04, 2023 at 09:43:59PM +0200, Petre Rodan wrote: ... > > + ret = match_string(hsc_triplet_variants, HSC_VARIANTS_MAX, > > + triplet); > > + if (ret < 0) > > + return dev_err_probe(dev, -EINVAL, > > + "honeywell,pressure-triplet is invalid\n"); > > Still you can use mentioned device property API. Repeating here from v7 thread: I think that deduplicating code, esp. when APIs are available, is a good to have before merging. -- With Best Regards, Andy Shevchenko