Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Date:   Mon, 4 Dec 2023 13:39:43 -0800
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Muchun Song <songmuchun@bytedance.com>
Cc:     Steven Price <steven.price@arm.com>, Jann Horn <jannh@google.com>,
        muchun.song@linux.dev, akpm@linux-foundation.org,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] mm: pagewalk: assert write mmap lock only for
 walking the user page tables
Message-ID: <20231204213943.GB4129@monkey>
References: <20231127084645.27017-1-songmuchun@bytedance.com>
 <20231127084645.27017-2-songmuchun@bytedance.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231127084645.27017-2-songmuchun@bytedance.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PkUQ6s9oqLH+bMXIYSoTPzSx5384fNycKL/NogrTgFMmCyHPbEncBUH0S8W+?=
 =?us-ascii?Q?dR9FNKfE0eLEYeuMaiP+gjQepO8RnP07M4TgAvn5F2i1FZhzfaMVW3G0Ingg?=
 =?us-ascii?Q?RtXm2OOv3mUZpsAASwrZpuSBNTwI5s7cUuu4cvYrNHI3jqmJu8l8HZdmWM88?=
 =?us-ascii?Q?Q33E+nmk/j952G4b8YcLqI40/smOS/qx+NLil9rwpFp8yzUpR9e9BtMqidew?=
 =?us-ascii?Q?iGwlKiDYWtF1rR/TtVFxrynRyfhURGbvEgC/T0IFqvrnp07JnqqJT9UUuRMG?=
 =?us-ascii?Q?otoKYEGqhhoitDMyKhWoKL7BGWtoDz8a30SRF5Lz89m8ux5/9OvRRJfdxI2Z?=
 =?us-ascii?Q?b/Ae0VB0ba52ujygiFFi84UCILgf/oCrg6sWtZ5D2qq2XNa0dBcQYzEWq259?=
 =?us-ascii?Q?KESvd90muNHjO5zHgoscDCZTcwTMiDFQ5Ijpg1CytblizkIyBtu3AI8Om66B?=
 =?us-ascii?Q?aSWW5OMPa43pgOeON+Mh+UtDvcpiLv0kF9MbT+OM4bSaRwb6V8jRlcVrpDf4?=
 =?us-ascii?Q?g3QcTqi7ZZeoxBhgFIEiQFzXnDo8MxvEtagG8PgQgqiJaUjSfdiUekiJqc5W?=
 =?us-ascii?Q?KEaILceBiWDpT+Yxm7H57ob+6ljjtQLd0JFw89XvLXKSIoMBOFfDdPR5eiVA?=
 =?us-ascii?Q?T6Z9XNbLNCndnuLQYcsQsjba0PGR64XWwqOTLBkg2wWHck0seDuQrwJmwZly?=
 =?us-ascii?Q?J5pPacDzd4Rc0QM8IjLcGV46VSZoyZyVyGmJOdoxz+5gZFKaqHKMDCmz1jRp?=
 =?us-ascii?Q?/B+SNHVwY7QRno7kIakLgNK0EJAgGz4WvffU40ucIKKOcKgzuY0miwFLBdCh?=
 =?us-ascii?Q?vCAAWWg0lInpRx9HTojAUdevCFIMEuMeTgqlldzQargzmR/eiyVb40Jaya68?=
 =?us-ascii?Q?dKo2SBoke6CDbYEeVSEPgGuCI+tGtEm7zS+ryb4RYFBhQc+RCg9BjUQGU6No?=
 =?us-ascii?Q?wq96vjBs2TRCjydBHxl69G1AhXRtckGXXTqsz9051Rzb8jvJx1Bz5jnyARSD?=
 =?us-ascii?Q?aOvg6HVnKRh8dV1z1xxo8Ex7alCZhoDvdaH2DKxecT5dD6Te5T9VbHQ/aFx5?=
 =?us-ascii?Q?7Joo6sMK2spG5JoD68hwGP6SXm2HE6wkIQcRBsNw/jrzGEdRUNtEVgIy6YE5?=
 =?us-ascii?Q?014dPJpoYvJca8DrwN4BvSyk477juzEV6aUDzlYBTIbo92UX7qzy8foA/5Ss?=
 =?us-ascii?Q?wkZqSPjcVlh53ZMTNQF8g77aaRW6ZeEunmiuMRQYRzzflB4HkuiGvocPrV93?=
 =?us-ascii?Q?G2LheLD04ysMCNnE6D9IGlREtKVBBvr3xWPEj7jY+Jw5vxtKvk7549aBulZk?=
 =?us-ascii?Q?uQZ88Kpg9JxEdgOAKeAmkON+gOMmCVwk62vZCRyitHJPNoG3x74+5DYWvzU6?=
 =?us-ascii?Q?YeeS792N4gdTtOjDgnMEypZWCudZZg/7Z5rNVdnqUE+HlyEIW/C71hb9rvlZ?=
 =?us-ascii?Q?YxjRCtDS89yVEwV4McPeiTmxVhvLHwSKZohexUzxHc8iL5gCwSKpBGj9l58+?=
 =?us-ascii?Q?X78maYwawVIUvAB7PWO597auPR7fduQiSLakLts1t+kZiTJ2CSzSAUmYINHc?=
 =?us-ascii?Q?WCdSApqgfPVDYRgUPhbyGShelRFw1DCiZiAM0aswHTzXIjujaETS39Z6ljAn?=
 =?us-ascii?Q?Ig=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?cKkARuHPcCUWk5dPyd5rYE/fMWUWk+byCGR1P39jcz+g9au/DWqX5QZZlVII?=
 =?us-ascii?Q?cgDfcOGm94983jaIFAXlugW9RbZh51cHy2Nio6aO+vvTCOzfTx7YdH3zDXQh?=
 =?us-ascii?Q?5cdlDWt2mNXoneI+7VB7ngTE+DkT7y6T+PlRTQEj+EA0cudcRQifsQVMSk5R?=
 =?us-ascii?Q?42zTm3M49d8z8ua5SeB0WB8Tx0+wGSs2z3H2bF821ZoarZd/wv3ZUZ+cstSJ?=
 =?us-ascii?Q?mHlzNCFAslqapYCqmKclWhWiy7uTg5WoFrmx7K2GrdBRkeghuog3CiV04jRp?=
 =?us-ascii?Q?TD1OCZvDWwUOJE/rsS7+A/5ZBB5B9fN3/MC678HSZV6CVypMKWObRZTSu0Lz?=
 =?us-ascii?Q?UqHIj9DZd9PMK/orDIcBZ6tJNoMlN8aemaOivJ7tybKH0oltN6RdCZBJQ+Gr?=
 =?us-ascii?Q?Jd+zqbNRMlWDxik8mX9aRUL0027YpsUU7wKPW5EJe6JP30OefhZzTUAKxdmx?=
 =?us-ascii?Q?rJqSNLpKpX0slx8eTtJRALM74jsqzw23Y43IQzL1CDul/8G01cUXugHce7hu?=
 =?us-ascii?Q?3hVRnScyXaXXs1eHe/185GP89JkH78KtUsgE7t/iBIk2drnIl0799zzf12HS?=
 =?us-ascii?Q?37YRmk/4rGwx+g8n0PIq5nB3CkeirdwQozr6WHOXcc+fXlz51vah8aAtEr3a?=
 =?us-ascii?Q?4Y4WGKPLvQzK/Befo/jU7d28QGTCL/AUm0xZFUAlNH58x26v14SaCSDt8s15?=
 =?us-ascii?Q?eabPujkytUQOdMU3eHMyN8USTiWlcq/vOHJORilVJwZ1jWLLy6DYUqAfLVTy?=
 =?us-ascii?Q?nds+A4BhBbg1379A393uVE3Q++WF/vCEZYUbcu/em5K89ANoYVLCnI3Ay+3z?=
 =?us-ascii?Q?BDw4greAjNYMrZJTylmOfQbYFvLQuN6HUaBku/bTwU2gJLLiUFIo9BSdYKsq?=
 =?us-ascii?Q?I+1dUg/4WIVhR6ljVmjbAYyZvtLXNnIFK56VHxaOC3Y1jMWfljOA5lT2efXl?=
 =?us-ascii?Q?R5mCE0O9zTI7hGkIwx7Gyg=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 07c34da2-8ae3-4842-7da3-08dbf5118881
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Dec 2023 21:39:45.8364
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NdwZ23Q5EhMhYzbh+Q17sE92BZU9aqPFMU2TLvrLj9Yj7yC4dGr5Ha5pPP8XlrIXAZMPtmwDnHukAVVI4o4C9w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR10MB7383
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-12-04_19,2023-12-04_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxlogscore=999
 adultscore=0 suspectscore=0 phishscore=0 spamscore=0 mlxscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311060000 definitions=main-2312040168
X-Proofpoint-ORIG-GUID: YP1wygTI02R8Lx8IUe4rdbS7cIuZUyt0
X-Proofpoint-GUID: YP1wygTI02R8Lx8IUe4rdbS7cIuZUyt0
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 04 Dec 2023 13:42:03 -0800 (PST)

On 11/27/23 16:46, Muchun Song wrote:
> The 8782fb61cc848 ("mm: pagewalk: Fix race between unmap and page walker")
> introduces an assertion to walk_page_range_novma() to make all the users
> of page table walker is safe. However, the race only exists for walking the
> user page tables. And it is ridiculous to hold a particular user mmap write
> lock against the changes of the kernel page tables. So only assert at least
> mmap read lock when walking the kernel page tables. And some users matching
> this case could downgrade to a mmap read lock to relief the contention of
> mmap lock of init_mm, it will be nicer in hugetlb (only holding mmap read
> lock) in the next patch.

At first, I did not understand your motivation for this patch.  But, it
makes sense as your next patch will replace hugetlb vmemmap specific walk
routines with walk_page_range_novma.

Directly Cc'ing Steven and Jann in case they have comments.  

> 
> Signed-off-by: Muchun Song <songmuchun@bytedance.com>
> ---
>  mm/pagewalk.c | 29 ++++++++++++++++++++++++++++-
>  1 file changed, 28 insertions(+), 1 deletion(-)

Looks fine to me,
Acked-by: Mike Kravetz <mike.kravetz@oracle.com>
-- 
Mike Kravetz