Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp3011601rdb; Mon, 4 Dec 2023 14:05:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IEV8/+IKI6BA0MQi7g4FTv3uBF53Pqu0RIjF97iaVGzYU6G+uXtcnRS+2tdBUuz9NTyeRq0 X-Received: by 2002:a17:903:41cc:b0:1d0:8383:7433 with SMTP id u12-20020a17090341cc00b001d083837433mr2029681ple.36.1701727516954; Mon, 04 Dec 2023 14:05:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701727516; cv=none; d=google.com; s=arc-20160816; b=oXmW7CRrzRmkK+rQkjya1UBzETcvmuR+TiiWWQbqnU+dmjAxYUACMygQUM69S3vZPx lYlrLyiVKBA0W84ElAVpLdFNjY1+9YpGx8dIIXtUOgJS/Ty3o86Uv3isiiXA8pMC6VS3 v2F5R9PFQ5+FjWiRDEFx857HBQM6Jv2eizQL/0nlRG4TPaLCtcg0L4xHphsu2wicBBLF ihBC1mfKG9Tkxu4wm8f4ERC+hABa3EEDRxwwacULBdW1IKgwvWmULQqT/Rrf74EPa25Q ULNUmqZhgkoRYjLACO9vJ1GIJc9xFHG+IX1U0IO+5VFwaTgrHQaBEteziwuZZ2YzG1xc tB5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:autocrypt :from:references:cc:to:content-language:subject:user-agent :mime-version:date:message-id:dkim-signature; bh=bSLQDLDBsq6CSRResV6b+RWEWxc8ODYsE7vX6CdZaZc=; fh=BbwGTI8xIhlOAe3GC+/crN/OJA3CJSa5Ckq9LutMA1k=; b=bgAWyV1D3clSh4zDMUoOBCrGmJwIYJa16EW69j1IH8IbLj1zkW6XHAvlhPAjc+e9Xf Br/LvnRHYU1QAhEE2kAxv055yJi84P1DXAb2WoNpb6yfx07AtCimQrFoBTJoXm+b7zqD aW2Nt5SPRz4gl442c0bUd/fHddFuPhLPQNJzRzCh/Px7xMsoidMXKGOVcvB8qlPvRjPF W9QOn2i400KCdzubNrT6iHm+uybavykH2aWziaOlLAKxR0zVSr6stMcDV8WyK5tVdm6Y g+Xa4AsqjBObTukJP6/kme4g5XRsqhiOrpMqJx9HPDMhvMdgNyi/rwOQsQ80vYxpxhCZ NabQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=JH+vjFaL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id h2-20020a170902f54200b001cf54c7adb7si6865679plf.20.2023.12.04.14.05.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 14:05:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=JH+vjFaL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id B93A880560D3; Mon, 4 Dec 2023 14:05:07 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229967AbjLDWEx (ORCPT + 99 others); Mon, 4 Dec 2023 17:04:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229556AbjLDWEw (ORCPT ); Mon, 4 Dec 2023 17:04:52 -0500 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF630CB; Mon, 4 Dec 2023 14:04:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701727498; x=1733263498; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=4hdFpwxoWy6g4uIjhOcxul5k6qD6bNS8h15Ws3gqgH0=; b=JH+vjFaLVnZz/4JMSXx/2KeqCaK9k02+rEmd1956KPUzd6gkadDtxOYN Y6HuhjUvteVnpx/4TONiApvoxdODe7Tnk6e8iCS2YhFksBlPqxgJxiVbI /IsGj19BXPlQZzq6aEbiTwMo6IB6B/09oaoXqfX41npmFVKdcDt7Po5kS KXJMRjqwluY+1tP1Umf7IgkGmxjiuz7QoD/yq4RP8Sy/5Bi7t/vdX2tap /kQlwVLZ4lxBzfV6dKRrXmIyFexxj7DDZ/NtezsKy0ncKregveiHyhCw5 zq1S0igAzkbLbl7m4KPpDr4SBC/ouH4mef371QQTV7GVCWMMKClGJbvOT g==; X-IronPort-AV: E=McAfee;i="6600,9927,10914"; a="378831952" X-IronPort-AV: E=Sophos;i="6.04,250,1695711600"; d="scan'208";a="378831952" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Dec 2023 14:04:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.04,250,1695711600"; d="scan'208";a="17325751" Received: from gauravs1-mobl.amr.corp.intel.com (HELO [10.209.53.199]) ([10.209.53.199]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Dec 2023 14:04:57 -0800 Message-ID: <9b221937-42df-4381-b79f-05fb41155f7a@intel.com> Date: Mon, 4 Dec 2023 14:04:56 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v15 22/23] x86/mce: Improve error log of kernel space TDX #MC due to erratum Content-Language: en-US To: "Huang, Kai" , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Cc: "Williams, Dan J" , "x86@kernel.org" , "Luck, Tony" , "david@redhat.com" , "bagasdotme@gmail.com" , "ak@linux.intel.com" , "kirill.shutemov@linux.intel.com" , "mingo@redhat.com" , "seanjc@google.com" , "pbonzini@redhat.com" , "tglx@linutronix.de" , "Yamahata, Isaku" , "nik.borisov@suse.com" , "hpa@zytor.com" , "sagis@google.com" , "imammedo@redhat.com" , "peterz@infradead.org" , "bp@alien8.de" , "Brown, Len" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "Huang, Ying" , "rafael@kernel.org" , "Gao, Chao" References: <9e80873fac878aa5d697cbcd4d456d01e1009d1f.1699527082.git.kai.huang@intel.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 04 Dec 2023 14:05:07 -0800 (PST) On 12/4/23 13:00, Huang, Kai wrote: >> tl;dr: I think even looking a #MC on the PAMT after the kvm module is >> removed is a fool's errand. > Sorry I wasn't clear enough. KVM actually turns off VMX when it destroys the > last VM, so the KVM module doesn't need to be removed to turn off VMX. I used > "KVM can be unloaded" as an example to explain the PAMT can be working when VMX > is off. Can't we just fix this by having KVM do an "extra" hardware_enable_all() before initializing the TDX module? It's not wrong to say that TDX is a KVM user. If KVm wants 'kvm_usage_count' to go back to 0, it can shut down the TDX module. Then there's no PAMT to worry about. The shutdown would be something like: 1. TDX module shutdown 2. Deallocate/Convert PAMT 3. vmxoff Then, no SEAMCALL failure because of vmxoff can cause a PAMT-induced #MC to be missed.