Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp3017670rdb; Mon, 4 Dec 2023 14:17:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IFawxdpccdHy5QXaivF0Dl9LJfdbBCGDRUWVtb09hG+st0V2WW5EcQ/IyZKt5f50i9rwmK9 X-Received: by 2002:a17:90a:f2d0:b0:286:6cc1:5fcf with SMTP id gt16-20020a17090af2d000b002866cc15fcfmr267032pjb.82.1701728238796; Mon, 04 Dec 2023 14:17:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701728238; cv=none; d=google.com; s=arc-20160816; b=ywaJQcFdS6cGAF0lH61fbtaNDkr/H7yH/N0L85QVTPNwkv1HxvSPCOqcU1rIFIqi6U 4UP46xCw5g6+KHj6aC/HF62K00VIk7PgO4xT0+hT3mbNu1AOrBVrKWeJbshzauvnEKka Syp6ZoilNoOhKOvT4FqKy3+AwwBHtMScFECBVWP2Esp8vderIaJ0EyE8wnSkWQfUgblY 3l3Ba24J4hjRRCFZK9C2WK7m+hGiyJsiOX5aHNruip/4ZD4YJlXNbW9mo6Twf6wN62O9 qmbBJZeEF7kPhqhGgbmxcC7OMatjmQq6DI8Ii3GgK6zj2A16yHZU3F0TYQ1GgXxPVO9b 33hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:dkim-signature; bh=NS4jS69KLOJnxFovqZv/8vQ3n77jCj0+KLo8w0Mmcsg=; fh=XnXo3MvdkwAjXVjLy5RwLjmc1BTIJ6se7KvES1bFZHc=; b=cJUwYLvz/nUGsDnup/pBf0SSfNRdXDUNEKl4DmJv1aSKAozTlCPdHFhZ5PVFzdzLZT Jo8ci1Aj/z5PbuwntBJGw9a11vseS2ECimz2/8N1a+SrJFI5qcbe1wDLBuAWwE03FURA FJ+TThc2rx2RsMhZBcm6fAvvxOGBLRz56ZY4+LXas9PtW/+shOfAb52jZa1LTvspMcYw 0zoJeYVSs1IpVF4I1X0WkAKkPTmj5I2sSTSWeFnrm2biKYK85GfK5DlzABXVPD0LVo5w 20NrSzAsLYMrPt3s86fABL8COaqtQWjnCsdT1PmrutIjUFdHVIYkG2mqyxsRS/kIL4V1 MkmQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=lofcBWGe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id jg3-20020a17090326c300b001cfc9c9f736si6326817plb.93.2023.12.04.14.17.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 14:17:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=lofcBWGe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 965F18054EFC; Mon, 4 Dec 2023 14:17:14 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231317AbjLDWQ5 (ORCPT + 99 others); Mon, 4 Dec 2023 17:16:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43658 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229847AbjLDWQ4 (ORCPT ); Mon, 4 Dec 2023 17:16:56 -0500 Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::222]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE415CD; Mon, 4 Dec 2023 14:17:01 -0800 (PST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 1F71240002; Mon, 4 Dec 2023 22:16:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1701728219; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NS4jS69KLOJnxFovqZv/8vQ3n77jCj0+KLo8w0Mmcsg=; b=lofcBWGepeW/OU/1n6lJ8R6GE91nJTN2RoVmxDzB15pF9kdEiP7bO0iK0X1sv/XtlsDrIh MnOZIWUSeJRGkli7LMGZAW3C27vp22wofxiW098Qnv8KdgMxEieov+WNEGoBHjUe5LGRVY nMIbM0Qc9jsW5R+7C+7nLQLYREMNFbocLbWSmC8E8V+LlcDmlDslF+43uhjYIVVnUSOm4A YXnuPlsxnA00gaHZyQXStqWEYInVGusAIN9CpaDQk1HQYaCRYS3jBQ4FT0lsyIeP/nwgMg 83XERe3VDQtNi4zxYQytFRtKtBs79vu2MVvSgYndNJ/pjq8a4Xb+BXqQVAdPsA== Date: Mon, 4 Dec 2023 23:16:55 +0100 From: =?UTF-8?B?S8O2cnk=?= Maincent To: Christophe JAILLET Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jonathan Corbet , Luis Chamberlain , Russ Weight , Greg Kroah-Hartman , "Rafael J. Wysocki" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Oleksij Rempel , Thomas Petazzoni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, devicetree@vger.kernel.org, Dent Project Subject: Re: [PATCH net-next v2 8/8] net: pse-pd: Add PD692x0 PSE controller driver Message-ID: <20231204231655.19baa1a4@kmaincent-XPS-13-7390> In-Reply-To: <6eeead27-e1b1-48e4-8a3b-857e1c33496b@wanadoo.fr> References: <20231201-feature_poe-v2-0-56d8cac607fa@bootlin.com> <20231201-feature_poe-v2-8-56d8cac607fa@bootlin.com> <6eeead27-e1b1-48e4-8a3b-857e1c33496b@wanadoo.fr> Organization: bootlin X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: kory.maincent@bootlin.com X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 04 Dec 2023 14:17:14 -0800 (PST) Thanks for your review! On Sun, 3 Dec 2023 22:11:46 +0100 Christophe JAILLET wrote: > > + > > + fwl =3D firmware_upload_register(THIS_MODULE, dev, dev_name(dev), > > + &pd692x0_fw_ops, priv); > > + if (IS_ERR(fwl)) { > > + dev_err(dev, "Failed to register to the Firmware Upload > > API\n"); > > + ret =3D PTR_ERR(fwl); > > + return ret; =20 >=20 > Nit: return dev_err_probe()? No EPROBE_DEFER error can be catch from firmware_upload_register() function= , so it's not needed. Regards, --=20 K=C3=B6ry Maincent, Bootlin Embedded Linux and kernel engineering https://bootlin.com