Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp3019230rdb; Mon, 4 Dec 2023 14:21:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IG4oxdrb5a1H7RR0U1wbTBgQaSb8CNDUlrYekVO5yzxOjOUS/jXiDX2qMkyJTwtGE1BZHZr X-Received: by 2002:a05:6e02:1d8f:b0:35d:6fee:19a7 with SMTP id h15-20020a056e021d8f00b0035d6fee19a7mr2866704ila.26.1701728463854; Mon, 04 Dec 2023 14:21:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701728463; cv=none; d=google.com; s=arc-20160816; b=hN9RCcJ4DJwWHQCi0TgtAwHK3qr3Bqa8obawauOmWmgkxRKuzH3JylQGFJ0JmIOKB7 ozIQbWhc/di5Z1RvQl3PaHKopAb1KanZUlsCf/6zyvsrDwLI9PTsYDLQIt475Gr7S2a8 hTOQAbrMEoZoiTBza074IASbwxJg/86HAs5shHvNFbbaWytdkrHK3jpI15W76Kz0pdUw NrsFSPo1eLH2pCKEAwZiLJOJnhdLqPW0hwn4m7Y2CwBJ/DFxOpugYNxm4IdcG4wRwxcQ enL4WBD8ATNB8IDtFzkbWK5qg45CnY/3uKV8LabDnS7KMlfqQ3xtWagb4Jq04fMf2qhH Chig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=c+WzlKb2MQSHfnGqBE/e5O7OA37FmS5jYCRCA/LLsH0=; fh=UFAPvVcINCOjdQySakCjdQ+H9umeW6uKWj8WFMmTz/8=; b=wLYmHof5ndmCvmqmR1w62FJtCFvSsPu3iA2Uur0SYZdOM4oBRFLGqv/DUbp45mcMhj zNGS5NE107YnsPTwCfhyYTvTtbpXwQuycP7hVrr2HwXjygW3ibitM8DyAg6zopB4pL3s x8gb7cifjobZU2oAuL6Ax4dnbLXgmdhaL9rwstW1zAcbZbRJlanL00VXndG7kQnIRaN8 fmgrBHO9gzVXPXNbvN1MW6d93OhCFR6N1j1Gwv6Eu5p+mLV2NTWqiPK0+fO+gOSKK8th vvehVkn3eoDEGli5jxdaN4GxuetQcZXW0hICFi/v6AWYz8Sz/wKM4T9ai0ZdoDwURBAJ oHxQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=lf0Tbx4p; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id f25-20020a631019000000b005c692162984si2007026pgl.666.2023.12.04.14.21.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 14:21:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=lf0Tbx4p; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 801A4809F3A3; Mon, 4 Dec 2023 14:21:01 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235544AbjLDWUb (ORCPT + 99 others); Mon, 4 Dec 2023 17:20:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58538 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235562AbjLDWUN (ORCPT ); Mon, 4 Dec 2023 17:20:13 -0500 Received: from mail-oo1-xc35.google.com (mail-oo1-xc35.google.com [IPv6:2607:f8b0:4864:20::c35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 33D7D170F for ; Mon, 4 Dec 2023 14:20:06 -0800 (PST) Received: by mail-oo1-xc35.google.com with SMTP id 006d021491bc7-58e256505f7so1590153eaf.3 for ; Mon, 04 Dec 2023 14:20:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1701728405; x=1702333205; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=c+WzlKb2MQSHfnGqBE/e5O7OA37FmS5jYCRCA/LLsH0=; b=lf0Tbx4pZSpplXVE+zqYxKYOIwCE2xAIUgcZiK3fCq6WNOA8asMjsl+yN0MHxt2eDn rbaiZLPUY41HHiP3/HfHTDEMuBNSsqFAfOwLCszTWL335Aat5ZHiNUr8kTLUlWLeMVgK Ko4WxPKFTphxd51BX4j69weJgwWn21SSL2GP0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701728405; x=1702333205; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=c+WzlKb2MQSHfnGqBE/e5O7OA37FmS5jYCRCA/LLsH0=; b=LDZtT9L1fAczOVqXUqcPYBJidB2CQomVbe3y9wwb2xDiuqOWgVcXQaq3IwxPB7klZ0 SQBsCHYYl7GJHNNBW/ADMV2X+eDyvWvnr8YkJSHQ0/9eQoE2QzwP9Ho1f/TtqfngKChN csVtDCMU+gN3fV88y6aGliyKx660DRauXeTnJTnC3ol5N2WqIE3X0AuRm28IhGCXNJRP QD6O2G7MYZU1viu8KrZEEhHf1cIQeiy1p/F+wavsxMcICnu1PMRcWiEhtCldhRzp9I1b KF7e13KeMtZJzFEfmtojIe1UAhU73dVHibndoSeRFnLnVYU/Da3hP3nIxUWn40Oagdph bWmw== X-Gm-Message-State: AOJu0Yxh7NDz+zRUpZj25jp86T4expOUBhTPNtm7+tYbw8jPJQ6m2wMf H1MLFt5+Us3S3sVLqdtjZ2tZYZdKm4ukjuvt0no= X-Received: by 2002:a05:6358:9106:b0:170:302b:545f with SMTP id q6-20020a056358910600b00170302b545fmr2543842rwq.56.1701728405319; Mon, 04 Dec 2023 14:20:05 -0800 (PST) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id ey5-20020a056a0038c500b006cde75646d3sm4718759pfb.179.2023.12.04.14.20.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 14:20:04 -0800 (PST) Date: Mon, 4 Dec 2023 14:20:04 -0800 From: Kees Cook To: Christophe JAILLET Cc: Song Liu , "Gustavo A. R. Silva" , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-raid@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH] md/md-multipath: Convert "struct mpconf" to flexible array Message-ID: <202312041419.81EF03F7B7@keescook> References: <03dd7de1cecdb7084814f2fab300c9bc716aff3e.1701632867.git.christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <03dd7de1cecdb7084814f2fab300c9bc716aff3e.1701632867.git.christophe.jaillet@wanadoo.fr> X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 04 Dec 2023 14:21:01 -0800 (PST) On Sun, Dec 03, 2023 at 08:48:06PM +0100, Christophe JAILLET wrote: > The 'multipaths' field of 'struct mpconf' can be declared as a flexible > array. > > The advantages are: > - 1 less indirection when accessing to the 'multipaths' array > - save 1 pointer in the structure > - improve memory usage > - give the opportunity to use __counted_by() for additional safety > > Signed-off-by: Christophe JAILLET This looks like a really nice conversion. I haven't run-tested this, but it reads correct to me. Reviewed-by: Kees Cook -- Kees Cook