Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Message-ID: <52df445f-c2cf-44da-aa6b-995a6beeffc6@intel.com>
Date:   Mon, 4 Dec 2023 14:51:55 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v5] x86/resctrl: Add event choices for mba_MBps
Content-Language: en-US
From:   Reinette Chatre <reinette.chatre@intel.com>
To:     Tony Luck <tony.luck@intel.com>
CC:     "babu.moger@amd.com" <babu.moger@amd.com>,
        "Yu, Fenghua" <fenghua.yu@intel.com>,
        Peter Newman <peternewman@google.com>,
        "Jonathan Corbet" <corbet@lwn.net>,
        Shuah Khan <skhan@linuxfoundation.org>,
        "x86@kernel.org" <x86@kernel.org>,
        Shaopeng Tan <tan.shaopeng@fujitsu.com>,
        James Morse <james.morse@arm.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        "Randy Dunlap" <rdunlap@infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "patches@lists.linux.dev" <patches@lists.linux.dev>
References: <20231128231439.81691-1-tony.luck@intel.com>
 <20231201214737.104444-1-tony.luck@intel.com>
 <fd8a44a1-9001-4e3e-a1a9-63e7f737e6e1@amd.com>
 <ZW4XjqxfYBFZId6H@agluck-desk3>
 <660935b2-93bf-4ca0-836a-7aba46009c5c@amd.com>
 <SJ1PR11MB60839F92B1C15A659CD32478FC86A@SJ1PR11MB6083.namprd11.prod.outlook.com>
 <0285bbec-7152-4f54-94a3-45ce265a3ebe@intel.com>
 <ZW4/sE4Af0p3jl07@agluck-desk3>
 <0c2beb97-437c-4315-9aff-14c650297565@intel.com>
In-Reply-To: <0c2beb97-437c-4315-9aff-14c650297565@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aUNDQnRaU3poTmI0ZVkwL1htTk9HUHpRT1BSeU53V2hSYkRIemJHSVN4a21K?=
 =?utf-8?B?eUtIMkdzdVB0OU5vWVc5Ly9teER2b3Fhd0lISm9XRU95NlJScmhOUTUvRXdH?=
 =?utf-8?B?ZHBsZkNiekxCYU1QNmJTUjhVRlRCYThlY0NMdE9hdHI1WlpGSSsyTXlJcW1H?=
 =?utf-8?B?THdabENGMk9qWVdHWit2aXFVU0c5S0RDUVYvY0xMUkwwY2Jpd28rVVI4Y0Fp?=
 =?utf-8?B?N1pqMkNzMjhFU1pTRE4rSGd5TmdNOWpMRE5NY0p1bFR6Vmg0YS9MTFpCUzM4?=
 =?utf-8?B?dlhyVFErVmUrdi9SMnFGKzNZa0hNcHJESkE1anVyKzZlUTgxRVRLRHFnUEJR?=
 =?utf-8?B?WHFyQVJqMjRBU1gyc1Q2ek9zR3lLYnQzMVo4TStTRGRPdld2WWxoVmZ5TWV2?=
 =?utf-8?B?enRUWkR2M3lFZjVFb2tPRVoxeVlDbXlNMnlQNlUzM2s4enlHbzRteFhqbWlD?=
 =?utf-8?B?dEkrU3FVMTVIMDJUUWlnZlk0b1lycU5nUzZ1d2NLT1BDL0hqSjFuRHpNOGpX?=
 =?utf-8?B?ZmpWeUNXRG5iaFZnMVQ5czliQ1FHaVdtV0RpbVpIc2NBbW9TQzZCcUZYUHhZ?=
 =?utf-8?B?Z0hKMHAyK3NYQTJsSXhQNlpRZlZid0F3M2R5d2hrc1luMTREazNZRG9BTUxP?=
 =?utf-8?B?OExuNURkc0RsVkwxQ2JSck5uQk1MQmdIYkxZYWhIY1ZSTSs1OUhnV2p0OFIy?=
 =?utf-8?B?d204ZGVqMUJ6MmdKVWtYZ3A2bGpaVmRaaTkxMy83QkFRd2VDbE92TGdyd0RB?=
 =?utf-8?B?ejd6alZuYTdrdFkvcUNleEsydnZxaythMnZaL0NVZTgvNGJNdW9IZlJhenl0?=
 =?utf-8?B?d2lNVENiZFJYLy9ub1lhbzRpcnU3SktFTVg5OFY1WklYMGp6aUhsaVBBQ0Zl?=
 =?utf-8?B?ODF6QVhlZGk4blpDM0dlbzlKY0xWTzd6VGhBdzRmQm0wRCswMEdFeDhxS05N?=
 =?utf-8?B?L0dMZ2hlRVd6WmgwUUZLSll1TS9yTUR0cWdIWDQxUGgrb1ZzaG9DQTJjeGhB?=
 =?utf-8?B?SWtodmxNd3Bjd0RhSGEvbVZ1K1FnMUFsa21uSThWeXJleGlQamJTdUtSWXh4?=
 =?utf-8?B?UjVVRHVPRnVzZk1GaFVUMHVrREI4emxEekZITU45RnJCUWpmVk1YWnJjU1I4?=
 =?utf-8?B?N0ljU0xjT3V5STVBTG5rcTJFd3Q4eWcwamViUGRqWW1nYkMyMW9XUWFuaGV3?=
 =?utf-8?B?T2tBWEU1cFlVa0k0eXMvd2U5elBUY3FRYStyZ1FqVENMTVhSb3c0Zkx2eWp2?=
 =?utf-8?B?OE9hMFo2SDRTSUlBSGtiRUdDU0IrY29mNE41NUZab1VncDVjTVhzczVXN25O?=
 =?utf-8?B?a0VDOUQ3cyt2dzRvWlkycm5tVmk2dnNxK2dYaEZUczhFQzhqemoxc1hxOWV6?=
 =?utf-8?B?d0E4UERUY0Jwd1pxWDRoalNUeC9vSUwrYjZnZDZ6QVhNRCtXTGpuKzlMRFNh?=
 =?utf-8?B?SlBiYlFTOEtxUTdaTDJ6Y2h0T2VteURBR0h0ZldMaDYwWUh0Q05CVmpJc1FU?=
 =?utf-8?B?ZnRFU1h0Ri9OczQxZXdpL1hvRkgzMklncjI3enFlYmgyVVdIQ3d1Zm1IS2Vv?=
 =?utf-8?B?RlJLOWN6OE9XUlNlN000cmw5OGlua3dnanhpbkNGNms0MnM4Nkg0Z1pmNzd3?=
 =?utf-8?B?cUJzUkFkWjNzRXpFdDg4cDRZamhrNFRpZ2JCd3hvL3VXTURpeW9FZnQ2R0Mr?=
 =?utf-8?B?L05FYnhsU004K1FVc2pMbFdGLzBscmJ6TWp4NnkvUy9MQWNwYUZGRFI5Zmo2?=
 =?utf-8?B?WFBvY3JhcWhnQjBFNFRXQWdBMFEzbWFxRFgvQ2luRitsek81Ui9zY1A0TGov?=
 =?utf-8?B?aUhINFZWUnBBZmtXYWJub0Z3aXMzYjBRN3FpRzBpR3dWL0RHZ3dEOWZiL2hU?=
 =?utf-8?B?blRRREZNUW5aczgxd0RUcmZCcUlFNGdUVEZYUHY3V1RGREU1UmZDWVpUd2Vq?=
 =?utf-8?B?OE9NWlh6SlpiR3NsVDI5Z2gxMVZzeW5Xc3JEaEo3ZDNZb3NKMnNBSmlMWXlL?=
 =?utf-8?B?UkJPWVNEblR1aW1ySTBzbzdrNWlndzkvMDBVTDVJZmpTaTl5WTMwQjA1WEtG?=
 =?utf-8?B?MXNhTDFoOEhRaVVPYnJmc1ZHM2txOVVpdmlNWUVnV3hEQ3FGYUwrWDJ6RW4x?=
 =?utf-8?B?VGFDaEI2bW1ndGxsVlFYNy81M3VFYUF5aW5TUzV6RzcxYXBWYno0WlBEa3JZ?=
 =?utf-8?B?T0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f769d2fb-f4d7-4f01-0a01-08dbf51b9eed
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Dec 2023 22:51:58.3878
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: v4QB5KSeFDnF4TPkMt2IpLfoGqXRT7HjwtEj63/Ip8LDVF/uYSVaTkxgDr21NTmZXizh8ZDyLSIKj04NORDHF49v/WlWKpSWiHQBKb70XKY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB8278
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 04 Dec 2023 14:52:14 -0800 (PST)


On 12/4/2023 2:15 PM, Reinette Chatre wrote:
> On 12/4/2023 1:08 PM, Tony Luck wrote:

>>
>> B) "mba_MBps={local|total)" forces use of chosen event, fails if event
>> is unavailable.
> 
> I assume you mean "mba_MBps_event={local|total}". This is my preference but
> I would like to learn more about Babu's "overkill" argument. I do believe that
> (B) is well motivated in [1] and has no impact on AMD.
> My uncertainty here (considering one motivation is to future proof it against
> adding more events) is the generic "local" and "total" names. Even so, all
> I could come up with are "local_bw" and "total_bw", which I do not think are
> improvements.

Thinking about this more the existing names in resctrl may help here
... "mbm_total_bytes" and "mbm_local_bytes"? Any new event would need to
integrate with these names.

Reinette