Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Date:   Mon, 4 Dec 2023 14:53:57 -0800
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Muchun Song <songmuchun@bytedance.com>
Cc:     muchun.song@linux.dev, akpm@linux-foundation.org,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] mm: hugetlb_vmemmap: use walk_page_range_novma() to
 simplify the code
Message-ID: <20231204225357.GC4129@monkey>
References: <20231127084645.27017-1-songmuchun@bytedance.com>
 <20231127084645.27017-3-songmuchun@bytedance.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231127084645.27017-3-songmuchun@bytedance.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?smPdB1tGfrAOYRHLURUUIOB7aTFt/968+GlTa7PEX6tyfaunKCjuM+O/Bp8B?=
 =?us-ascii?Q?HZv4PG2ZxH1P4UDKZItc/fBmqLrrbjA1eCLKP90t3x05gR1VS0F6pQybZLj7?=
 =?us-ascii?Q?zq9ZqAt7PQ+kJsxoj4iyj7n36GN4NvvHRjSi087ioV4h4OQ+tHT7woAPuUAy?=
 =?us-ascii?Q?E2IU5oC+zdPGu818IV2idPs1h5S6I/vH3uW6uFHIGThl32l9Mi451k9myzM9?=
 =?us-ascii?Q?0jBw2RH8uy0o/7JsARKYowHwTF3gAAoLz1jKJp5YiLOxw54NeSdDKzgBcOEq?=
 =?us-ascii?Q?5fHHPo4WPXIw+3oz+NsSLP3mOiNCKv/5vmD3ImIw9AeGZGE0VwabmaVKne4G?=
 =?us-ascii?Q?nJA2/JJwKuMNZl7i7Fbn69v2sXipohoUJKXjU4XOY8gXd4xlRfnOpg6oO5CS?=
 =?us-ascii?Q?R7F+lCQaQVC+0rP0eshsALZLeMJDlBZb7kTsS/CPCN+qskBUfK3Fq89avqsS?=
 =?us-ascii?Q?sYdSR6dqH2wERbHRmJNsqeeQ7UufDEw7HV67ahV2xEg2E0rggzsTUz7+q4X3?=
 =?us-ascii?Q?Lkrgxc+R0ghgYoV2Vj3bAF2hYhHBNqYu5MwdUJ5rLButs7+26XqfGnuqBTEF?=
 =?us-ascii?Q?8G4SO30uT6A4+IpGMBW42lMhMOEpwfPqhU34XwCD/e7PYnhhEPHLVoIusjIc?=
 =?us-ascii?Q?0RlONPvMZMe9TmwTOPvyMmnx9ZD32VIT+0/S32vzdWq7PtQ2fweGZ+kAJCjU?=
 =?us-ascii?Q?nuHWl2dofJS5+qvPmIDD74ZQSmQBzl1Nc2/WZeBg5PRm6jNto/9UofDcFtIn?=
 =?us-ascii?Q?F2ChxZN6RR4e4+JoHW72JuKd5oRif4qGElZF9bqdnpY3QXbrGwIdNI5LFzPl?=
 =?us-ascii?Q?PvLIZm2Gj/MH0emR6+9ZRbNRENMsqHH6h182dAAYepaXxH27wKEf8niKdcoL?=
 =?us-ascii?Q?hdOA7jtd9shBKhzZZ/uzWe9M99eQYLA+DzHMIbviAEUD65mF1KJvlw7sK8ch?=
 =?us-ascii?Q?Vakf5T9T7ddzsb9UbDxP1uV7oLsDx1rBzR7A45S+PnUeL7WQVaeNWPTJAT6W?=
 =?us-ascii?Q?10KVjAFlUi0wTxRTsFfbzVh//veoTZml4hT3KcYROjY4uMGUU5UATexDRzYT?=
 =?us-ascii?Q?/4vseS0rHhApCggowOXAFN0uPxGqbZrSF5XGGH1a0h+k0y0+DaWeFY1Kw93+?=
 =?us-ascii?Q?JoqfAKAhBD4zg0qBc+q5cx+1wyt4RVPKqxdM0kRcU+e8yd2PhoC/vCMtPo/8?=
 =?us-ascii?Q?mf8MAK7zLYNsTMedWv3usAmXcStoyTs4suzDVjRknNVhvBViNQRcL7xS1Mgg?=
 =?us-ascii?Q?rRAL/hLf2X5P6O1LpqWLY6TMgIQh8v1Z/BrwMa+3XAYeECly+ecunnO85eAz?=
 =?us-ascii?Q?6k0T53tD+XxwxRz05TQRBzKjj4t9t12wYjOvShsta4qCJK33AdCBTV1J5VMr?=
 =?us-ascii?Q?GUif0pyoryaRePtVKGOajH1hLBLNT9PEF7/sbVs17rnaLRVluPBXYFMZgELl?=
 =?us-ascii?Q?V0RumTzLei9zkTvXzdJVfY9Tdc/JdgckJk/brWEJelHdjpjJPn3EZ3xZ55W5?=
 =?us-ascii?Q?j12H0ws+l8uY/yNo2bMjl3GC0S5beNOcA9hYDC5MWfiRyyn1HOHhC642HLC2?=
 =?us-ascii?Q?4ukWbKKRxn7P7+Oawnmcvw8WAs6HJOVJpIL/xdMxqpdcSzTo0kYq5mtcjtgw?=
 =?us-ascii?Q?5A=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: EWqVOD8ZsXklKmgVkrg8Y+Q+Kpx2SJGms8FeCl4NX3BKOGUDmPTD/VZUb/khDrsNUuZgaia0jmnSB6L6o03vmph/1CZeW24YLUbQvDncc7Snfe5jGkOOtkRKAu3qXkJWwXnKJMx0yKIUAOpUl+dZ5p6bvyNcteoIbBt2gTWQvhqx8yi0qi5CZOGv2MifrCysVrJQpji7Yjc3Z4Qh8/YNtnxvjIkZifEyfhonIdaGjTXmbuhmwGVEVSJK16HsYXO5WDB8oM0ZUT8nYAADbofzvtN7R6yxYfu8c7z3orSouHAERiYQcROLQeXLbilWoQA0TrQI8Hw+jJWQHRsnEoekmvsn5XmTnF9chOme6EyLDLr4i/DZ5YbB9aJ4VbZ/9184AJNHVvrC9N+3plZTaxjUoyAtSIIchpKPTdvSbNTzgjPdvTRMsvyTAszem8pg/ZLXVF16yd0z3JnLiQC5QMlwt6pSx3GWsQXwX34vHVPgm12rgfuVhscw8rjZh+DVdOb6uLtQ8mqz0EKZAshDFiFQvR0z7VTI7u/uG5OBoXaaZ1lM86i5hNhccsppnHi3KJ2hSkpydquTND2a52t2+vEKAvc8TyteZxYo967WGVFyrXnOnm8JAwhzQRRnhp71OKu+VUh6SJ6nkzNsD7JYi1i+csfpNVCyomWyG9o11yMALM01ADp3yfvRaMRYGC7mb3jShZo5RBLGqDlopJuXTXDAOhkxPwaRM7SrOSO/TElZzsa02Rkz7lkHsRyi84Md/2Xt7aTA+smaOc3SbLjOgkjKWhZtztCFDZZFNKwpLZbpVp8bA0ft+bmsY0B3R/SQ0/PW/JMl3sUi/VynvHlmSfm/Id8CjhR7iD/1BmO2cUrF/hBBNjY82WaCS7POyhy6qdvw2d0sDstyblPNxJ3/FmKSlH/OrPd4NxugP49Sopy9hB4=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 829a4daf-8227-4bf5-825c-08dbf51be78e
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Dec 2023 22:54:00.3402
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: T3julh0lr5YXDbxoZBnwwUDt0t/KZD8AOtjOd54ETvJmIF5KMWiQJL3BHX1Fwa8fA3KG9zKXz+oSTXW7K0OJ0g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB4930
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-12-04_21,2023-12-04_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0
 mlxlogscore=999 mlxscore=0 suspectscore=0 adultscore=0 spamscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311060000 definitions=main-2312040180
X-Proofpoint-GUID: gYAfawvRRsqJauXM62HWKrrBu7zpmsN-
X-Proofpoint-ORIG-GUID: gYAfawvRRsqJauXM62HWKrrBu7zpmsN-
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 04 Dec 2023 14:54:39 -0800 (PST)

On 11/27/23 16:46, Muchun Song wrote:
> It is unnecessary to implement a series of dedicated page table walking
> helpers since there is already a general one walk_page_range_novma().
> So use it to simplify the code.

That is a very nice cleanup!
Much code is removed, but I could not find any issues.

> Signed-off-by: Muchun Song <songmuchun@bytedance.com>
> ---
>  mm/hugetlb_vmemmap.c | 148 ++++++++++++-------------------------------
>  1 file changed, 39 insertions(+), 109 deletions(-)

Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
-- 
Mike Kravetz