Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Message-ID: <9ac718af-7d67-a179-6e38-d51e2d7506b0@amd.com>
Date:   Mon, 4 Dec 2023 17:04:11 -0600
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
From:   "Moger, Babu" <bmoger@amd.com>
Subject: Re: [PATCH v13 5/8] x86/resctrl: Add node-scope to the options for
 feature scope
Reply-To: babu.moger@amd.com
To:     Tony Luck <tony.luck@intel.com>, Fenghua Yu <fenghua.yu@intel.com>,
        Reinette Chatre <reinette.chatre@intel.com>,
        Peter Newman <peternewman@google.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Shuah Khan <skhan@linuxfoundation.org>, x86@kernel.org
Cc:     Shaopeng Tan <tan.shaopeng@fujitsu.com>,
        James Morse <james.morse@arm.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        Babu Moger <babu.moger@amd.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
        patches@lists.linux.dev, Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
References: <20231130003418.89964-1-tony.luck@intel.com>
 <20231204185357.120501-1-tony.luck@intel.com>
 <20231204185357.120501-6-tony.luck@intel.com>
Content-Language: en-US
In-Reply-To: <20231204185357.120501-6-tony.luck@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZlFMc2o4L2NTTWt3VzB5aEJJbWwvT1JWUmg2ZFIyUUZSS2ExaHBiNFFieWNm?=
 =?utf-8?B?KzhBcGRNbkh4Wi9WUGp2cHNidXJjMm42Z2ZXbmNnS3d1a2VLQVpQc1dIUDFE?=
 =?utf-8?B?NjE4QURKbFhiOWxORHJNRlQzWG1IeklPY3lEaG1SLytRWXU5SXBwRW9xbXg5?=
 =?utf-8?B?K3VNdXE1TVVyUXkySWZuTnlrczBpWk1RME1jV0RNeVVyWEM5NWFCOFlPVnZ0?=
 =?utf-8?B?NzRQR0xwYVpLWWJxMlRGKzlZN1ozYjEwdHI5RUpFbUE0ajZuaytvWE1NRkk2?=
 =?utf-8?B?RHNHOExQby9BTE9TVnVxQXl0Y29GRWpWcldwS1RhdTlsZEdZd1gwM21uQ3RU?=
 =?utf-8?B?NDBRZjQ3UGFocmFrLy9OZmEzMjh3S1dWaEhMSkphcUNaVGFjUUExL3R6dzky?=
 =?utf-8?B?UndIWEZ5RVNOSC8rK2MvamdCVDk5a1FSbWgrcTJjNWJ3YXNjaXkxWTVMdDJy?=
 =?utf-8?B?UEJ2ZU5yWFVvb0d0SEVpWmlHQVhvOVFjaUhDaEpwQkxwWW5yUktYVkpDdDh4?=
 =?utf-8?B?RGQxZGtBU0NaMi9VKzVhQnFvKzFiY2YzM0gxU3Z4VzM3SWlWeFpMWUkxa3dw?=
 =?utf-8?B?N1FHS0ZHTzJud1hnaG1rVk5rOUJEV21SQWlkcmJ4OXJLckxNZEp2Z3V6MWYx?=
 =?utf-8?B?aG9jeHZIQXRWSy9pMytPVlRTZmptQ0xic21CRXJ1dXlVaWgrVU5IcTlmL09I?=
 =?utf-8?B?N3FkQnc1eWlqRlo5ZHhrR1JyVFY1WUs3dkdrbjAxYzNMN3oxN28waXVkTndi?=
 =?utf-8?B?Sk9PYTNYNk9tbmJHakgxTG5HeGJsYzBPNWk1WUFOY2p1Skh4NjBEalVkMlNt?=
 =?utf-8?B?Z0o4NGN2c2JraDBTSEpXc09Fazh6aU0vUllVNWdXUlJLOEJIMmxIYVVzTm1R?=
 =?utf-8?B?V1NNVWxzL1I0eGxyZktiblJ3YVR5NTVhU3dKZFU5dkxDY2xGV0ZVUHNMSW1p?=
 =?utf-8?B?cFR5Q2ozL0plaDhHVWRBWTVyQTBtTm14S2Y2KzBuYzJJZmhCWktGR25ZZTVm?=
 =?utf-8?B?OHg4UXZBVmk0K3hwa0FsaFREQUtoZ2dZcUkwaEZGS3NINVdabEtaVmxCUGpE?=
 =?utf-8?B?aEZJd2tiakNoTVQvWUU0Z1RtRlQwRDJHOUFPR2FjZUwvekFuQmlDV2pGL1I5?=
 =?utf-8?B?bHRuT1NyeHhPdkFVakZ3OEFhNS9hck14YjUxcWEvWjBXcExuOE1BSXRkUk42?=
 =?utf-8?B?ZTlFNHQ0Wkx1VS8wWGp2cEpuL2VMOVoycmN2KzFVRWpicTZzbWJUTitUTUln?=
 =?utf-8?B?Q2hNRW5lTm52aTRjVThvb1lHeDZ6U0JKSWh5VUQyNU54bXd2cFJURzdNR3NM?=
 =?utf-8?B?N29BQklHZWNyN29IMXhnbzRzYy9QTkJ3TlJWNzJZcXlOci95cUc0SGVlQ0Zh?=
 =?utf-8?B?aDBNQzdoalBGZmZOVUdjU1ZicmdkcVV0NDlQZXYvRHQvWWtGallMTXdhc1Fm?=
 =?utf-8?B?alZVZFFNSEd0UlJzRk5mcnNacTZRa3V6R1JybDFmZXdOdXNBQm9VOTFWWUor?=
 =?utf-8?B?dmlUM0FxMVFqSG9NQ1BlSmZBM0VHdFlNcElmMFppWmwzQzhBdnFWSEpRMDRz?=
 =?utf-8?B?NTc0RjZFaUdKSVo0RERZb0dHL2p1czRXVkVNNTY4QmtGbDc3WmsxTStIQkNj?=
 =?utf-8?B?aXJlTkhFK1BrT3ZObjA4YllvdHhjN29aZzFHZ3NNcmxITTRaSFVSbklIaFQ0?=
 =?utf-8?B?ZXRGMGNQSHhINWNNWXhnR2hTMWxMaXA0OVVqRnNvcVhyWlk5b3RvQUUzSTd2?=
 =?utf-8?B?WTgvQ2MwYkM3WmNBL1pFZFRGQkR5L25oMTQxOFhXc05XN0dPcnRnUVI1Nktz?=
 =?utf-8?B?VTFmcFUwdWRsM0RRVUZFcHJhMkh1WlVyY3pVb2g1SDczenVvYnZQdWdxaEh5?=
 =?utf-8?B?V1lRNmpZOVJ5WElMYzh4UzlLRlBnbWN5djdEeHh6R3FKY1YyeHV6N25DaEV6?=
 =?utf-8?B?UHQvSDdzYkVQMXFxL1VGU1JMOEk5RDdxYmpId2ZYZjRHZjdRWTA2SzNFYXIy?=
 =?utf-8?B?NlJWVFhMVEhObFFYOW9NTURWZUlIc3RXL3Vaa09EUWc0WWltWGtzLzV4ZVN6?=
 =?utf-8?B?REIzWjFKS2lmL2JSa1NzWCtQZzdnakY4NTdtT2M3T294WHhjNUxXdytUV0dz?=
 =?utf-8?Q?6bAs=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ffb3ce24-a1c8-4b0e-a5c5-08dbf51d5545
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Dec 2023 23:04:13.7667
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pwhnWjzpKRLTCHDhZIhhk66LwfR2kJ+CyovHp+TZzbeChWbl4HfNniZc8W5bKPeQ
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB8348
X-Spam-Status: No, score=-5.0 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 04 Dec 2023 15:05:44 -0800 (PST)


On 12/4/2023 12:53 PM, Tony Luck wrote:
> Currently supported resctrl features are all domain scoped the same as the
> scope of the L2 or L3 caches.
>
> Add RESCTRL_NODE as a new option for features that are scoped at the
> same granularity as NUMA nodes. This is needed for Intel's Sub-NUMA
> Cluster (SNC) feature where monitoring features are node scoped.
>
> Signed-off-by: Tony Luck<tony.luck@intel.com>
> Tested-by: Shaopeng Tan<tan.shaopeng@jp.fujitsu.com>
> Reviewed-by: Peter Newman<peternewman@google.com>
> Reviewed-by: Reinette Chatre<reinette.chatre@intel.com>
> Reviewed-by: Shaopeng Tan<tan.shaopeng@jp.fujitsu.com>
Reviewed-by: Babu Moger <babu.moger@amd.com>
> ---
>   include/linux/resctrl.h            | 1 +
>   arch/x86/kernel/cpu/resctrl/core.c | 2 ++
>   2 files changed, 3 insertions(+)
>
> diff --git a/include/linux/resctrl.h b/include/linux/resctrl.h
> index 058a940c3239..b8a3a11b970d 100644
> --- a/include/linux/resctrl.h
> +++ b/include/linux/resctrl.h
> @@ -170,6 +170,7 @@ struct resctrl_schema;
>   enum resctrl_scope {
>   	RESCTRL_L2_CACHE = 2,
>   	RESCTRL_L3_CACHE = 3,
> +	RESCTRL_NODE,
>   };
>   
>   /**
> diff --git a/arch/x86/kernel/cpu/resctrl/core.c b/arch/x86/kernel/cpu/resctrl/core.c
> index 797cb3bf417a..c9315ce8f7bd 100644
> --- a/arch/x86/kernel/cpu/resctrl/core.c
> +++ b/arch/x86/kernel/cpu/resctrl/core.c
> @@ -502,6 +502,8 @@ static int get_domain_id_from_scope(int cpu, enum resctrl_scope scope)
>   	case RESCTRL_L2_CACHE:
>   	case RESCTRL_L3_CACHE:
>   		return get_cpu_cacheinfo_id(cpu, scope);
> +	case RESCTRL_NODE:
> +		return cpu_to_node(cpu);
>   	default:
>   		break;
>   	}