Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Date:   Mon, 4 Dec 2023 23:23:59 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Naresh Solanki <naresh.solanki@9elements.com>
Cc:     Liam Girdwood <lgirdwood@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] regulator: event: Add regulator netlink event support
Message-ID: <e0953578-1c61-4461-af07-8cf1e3d1837e@sirena.org.uk>
References: <20231128140718.3866978-1-naresh.solanki@9elements.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="dLDDRDLeT7WFwlB+"
Content-Disposition: inline
In-Reply-To: <20231128140718.3866978-1-naresh.solanki@9elements.com>
Precedence: bulk


--dLDDRDLeT7WFwlB+
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Nov 28, 2023 at 02:07:16PM +0000, Naresh Solanki wrote:
> This commit introduces netlink event support to the regulator subsystem.
>=20
> Changes:
> - Introduce event.c and regnl.h for netlink event handling.
> - Implement reg_generate_netlink_event to broadcast regulator events.
> - Update Makefile to include the new event.c file.

This looks good however it breaks an allmodconfig build:

   ERROR: modpost: missing MODULE_LICENSE() in drivers/regulator/event.o

> +config REGULATOR_NETLINK_EVENTS
> +	tristate "Enable support for receiving regulator events via netlink"
> +	depends on NET

I think this needs to be a bool (NET is a bool so there's no dependency
issues there hopefully).

Thanks for pushing this forwards.

--dLDDRDLeT7WFwlB+
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmVuX44ACgkQJNaLcl1U
h9CDJQf8Dyd3T94FTchgvNZ6rHiwsm65xU3CDUg44uYXtizU6F9FmkgKDRUSLl66
R+Xo0FKTcgx6ktQ6GQreSAp6VGLfcySeBdaN/O73oDxbEaYW+h/pjwYe6GYJT02c
Fcwuj1tjS760B2IgCSOsecs3S/eH3J5x5oBEudrpgGZob6/ky61jyefJwWHwzJ6u
2zjnUO4UD112mpI6EW3z1GJxXHM/qPzGgeafAORvOGVKO9H9sMe4LXjy4gs7qQDZ
ns2Xx1oUkdLzf0UGVoX9I9+3BCx8r0PNvEJ+nmUKsZUlcMZiHp6FhR8NM1xj0p5b
vLcmV9k/IcIcJIfYkFregux2wJAtTQ==
=hx94
-----END PGP SIGNATURE-----

--dLDDRDLeT7WFwlB+--