Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Date:   Mon, 4 Dec 2023 15:27:28 -0800
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Muchun Song <songmuchun@bytedance.com>
Cc:     muchun.song@linux.dev, akpm@linux-foundation.org,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] mm: hugetlb_vmemmap: move PageVmemmapSelfHosted()
 check to split_vmemmap_huge_pmd()
Message-ID: <20231204232728.GD4129@monkey>
References: <20231127084645.27017-1-songmuchun@bytedance.com>
 <20231127084645.27017-4-songmuchun@bytedance.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231127084645.27017-4-songmuchun@bytedance.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?CS2U/nUbHcXFXiuUL4FzDfcxNAn/3isMlNe/gu4ytqjN8XvAHUN7pwE7OKMq?=
 =?us-ascii?Q?fv9DMzCeIJnWVAAhEjpBR57NBzO9a21YnkklGgqlgao34QPK/0JAjzmLeGJr?=
 =?us-ascii?Q?kwgRLn6S0jNyaHOpeGPGnOdKVqw0moYhhOpULyoeGA8yG72uOuV+j4ufgzmL?=
 =?us-ascii?Q?MVeY0kIXaYBVFnOHr8kw0k79YWEzc8EOyzP9Fr1vM/3NZ+MyMZ3hvzo1yNYT?=
 =?us-ascii?Q?ydmuywVhq0FR8NxFDrmC+13tC+7/GrtPWe/76td8u6ndEpalZpLcpjklCMTW?=
 =?us-ascii?Q?zDMeXGeQpSZv39xI1CnFK+a09uN9PS72aUyQks9yeB7dpqcW/I0QAk9HdoMy?=
 =?us-ascii?Q?A01exPw5SbpTqkBc/qA/LsQ46yjho6oWPOsKCP1HtWDHq4EclhkyUMMHEx3x?=
 =?us-ascii?Q?Wi5IpkVwtbdL7fYfZIJvO61O6NjB5+hB3wsZGrfy6800R7ceH06WBm2fsCl6?=
 =?us-ascii?Q?9fhQNqzOkfYzJ2l2fzU5h2OADUKDSx66Z8Qbh6JF94sPv94macbEk1PAGg16?=
 =?us-ascii?Q?eSHhJqFuwcXUM28+wevVq67rF3oty7kWzw2OEi6++QDHJgk/2rm+/+VczWi3?=
 =?us-ascii?Q?CJY1OyYbtuMVBS6kz//p080TYeWX82kPwhWp53pYWX0RpvQ1vhtv9ZvLtj+C?=
 =?us-ascii?Q?/ZbnU4LAeRcGu+6cmiOYsxIGpas0CTacWMatgBzMzbYcCkIeWG+1HS07BpGd?=
 =?us-ascii?Q?O09U4o4KznZ6bOGdF7D63PHOM6sL/gbFeVqLsQJ9jSh8zP+oij1fySFcQXJb?=
 =?us-ascii?Q?sFHuf1Hq9Imd8Vfuj4mzKfjVmhL7XsGZqNVPLDJqSIHVqqKBzf+WuPt6cyDq?=
 =?us-ascii?Q?tbJkXAlYQe6Bd1+UbvTVOFmyhX8/V8TjCgFj+4Z6Ng2eEfaNqimQdL6dkLSU?=
 =?us-ascii?Q?DmYmD/jyLKRXyWqvk/RVcVq8I5OXo83f3++DIyB0fwlQNMaaaKEc4nNE4JEe?=
 =?us-ascii?Q?p+JYGKJU3p2pVeh79+tmne3/HPmGvJcVg5qxd1EyOQUPH8Etrqgh2Phj4Sj/?=
 =?us-ascii?Q?3+O4j+XZlQsxMxIBGDFq5a4cQcxVAxb07fx/mDpsbnK/OIBfLJrb8+Tcn4Y0?=
 =?us-ascii?Q?dv8y1G2b1R2PT8r+E0kA4Y+yCHQBnjXs+y1XW8XfRYFipgYMBWzYNRDX9uZc?=
 =?us-ascii?Q?pCqP7RR6eaf8dp7+QAuna29jLaQXkwe2YLJZaYrBREnaM5vRA5met3k+GQMO?=
 =?us-ascii?Q?EPrRVTlNtCx4/NbVOzKDdRiEgHbohECxYqrQNSuXs5EFl4HF3OQ8qxNcT9ur?=
 =?us-ascii?Q?YP8NgWrBrlyHONXU/BUXe1LQdi/EMdI5TCBE9XBamqCzjq/FmGh079vFlkLU?=
 =?us-ascii?Q?ziRvmo9w7FLfv6ncc7uereht4b5UDB5WJkuDkWG8sagj7iZAA5uDCXl2w141?=
 =?us-ascii?Q?Lcvx3HAi53FRc2rurXnBM7qZA8XphdDIWsdff3/tUs6XM0mxC59EBb/Qyh9q?=
 =?us-ascii?Q?w5oZsxgLHsnFviyRAF3EN9CmYaF25YijhDsz4wPuEdx4NROi5lz0g3UpJkvk?=
 =?us-ascii?Q?au59SG71vtt1dL859kBao4+M9Pwq4fAuFCYrQCSEcMtKh8o/8Fyi41nCx4H9?=
 =?us-ascii?Q?19IYKhOr7SLlySfI/TYsqe8tFvrOxifFq78JHeT+bTvKaX6jRn895ahc7PAJ?=
 =?us-ascii?Q?yg=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: goNC+A/QiAI1K3HRCvfhm6Q3NqeweRzotLY0ejWKjlmmyfd4hZR1fOgMX28mgJ/J6alWPhpS9nk/s7KdBEz4NB7yGfgPE0y8uCL4BUI3irtL19sUYWYwvAVCLTXUxh8bjYIG2mj3ptD9Q5eVttgFKEGyt35/7z1mWHeaeOb7rhpVi3kG2NeANOKLrdILa9V6uPv6Yu3NIYPxgyKWEm1TuDt1fKmth538XkZrJaX04XlJAKfnbov6idXeHp8+srwERNx/ZL1sI2RGyLvMlFb5XYZ2sHthHTi0tSo2OTBwunGGhPn5Q67PNHRSu8lU4FWMNcQfWFfasXNKk8zk6cy/9uM5IiylQe8qUa4QtEvGqXKA28JOIMCp258g0jlpB2bCNmGN1cJ1P/b50kH8VHBLTh3N48EmF2szh9qhjFPi2uU94xzfKOjs3YzAoALTp4FbKo0+CrFWgZeM42F1joDJ8qMZuzB3poncab3W9Y0cJm1W4MlRFCYg2wDZfpa99dIPwFuBcVyWZRo7QhkNfkHgtvEYwcQYo3M5joSe9VyZPJTlQgK1Qr6STGzw6hOgvIjlCvMVxaVSt20ajC22nM83lLA3+D4N2oKHIgAJ4zHYDucFW0xFM7R0XU1AYwChLFQ3cnEjO2TlE1gh4l2K16Rcmm10i39ddmoUm/fC8PndA1Z2Yy7YxwHSHDwoedM+98hC992opnwqyO2mOdUawqdPA/VG/Eh0aw1OLfp8pfoN+J/A4sHjVE+D5NEQVUhmsZ2h1RIdKli5W42OikOnTuqsOcJrFwis7g+9uXmXJMAaFY4rjPFy8/YRdKNPUrDK0TCyfOMGIhRO1NyXDQhCfwsrOh4N3LbUBAY9aZSMhDPFOJ9gfd4Fo6ERRE2luWu/0vx/Q7fG7YqCXGKTr/chGPQ2GbivH5BlHbosKZ0luzIeNs4=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bf9eee4c-5624-4ff3-fe9c-08dbf52095e4
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Dec 2023 23:27:30.7181
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1A9w92jOfLq9q7uSs9E3iTEX4y8/Dk3ShXzzPArTEr1ND9ysh5iKiLIy4yQ/u6HYAq8TPgzavMHFzlfV5NmJGQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB6284
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-12-04_21,2023-12-04_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=999 mlxscore=0
 bulkscore=0 malwarescore=0 phishscore=0 suspectscore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000
 definitions=main-2312040184
X-Proofpoint-GUID: 8wPFlSGbfw0mIfq7xmXifONhnQRbr1is
X-Proofpoint-ORIG-GUID: 8wPFlSGbfw0mIfq7xmXifONhnQRbr1is
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 04 Dec 2023 15:28:38 -0800 (PST)

On 11/27/23 16:46, Muchun Song wrote:
> To check a page whether it is self-hosted needs to traverse the page table (e.g.
> pmd_off_k()), however, we already have done this in the next calling of
> vmemmap_remap_range().  Moving PageVmemmapSelfHosted() check to vmemmap_pmd_entry()
> could simplify the code a bit.
> 
> Signed-off-by: Muchun Song <songmuchun@bytedance.com>
> ---
>  mm/hugetlb_vmemmap.c | 70 +++++++++++++++-----------------------------
>  1 file changed, 24 insertions(+), 46 deletions(-)
> 
> diff --git a/mm/hugetlb_vmemmap.c b/mm/hugetlb_vmemmap.c
> index ef14356855d13..ce920ca6c90ee 100644
> --- a/mm/hugetlb_vmemmap.c
> +++ b/mm/hugetlb_vmemmap.c
> @@ -95,6 +95,7 @@ static int vmemmap_split_pmd(pmd_t *pmd, struct page *head, unsigned long start,
>  static int vmemmap_pmd_entry(pmd_t *pmd, unsigned long addr,
>  			     unsigned long next, struct mm_walk *walk)
>  {
> +	int ret = 0;
>  	struct page *head;
>  	struct vmemmap_remap_walk *vmemmap_walk = walk->private;
>  
> @@ -104,9 +105,30 @@ static int vmemmap_pmd_entry(pmd_t *pmd, unsigned long addr,
>  
>  	spin_lock(&init_mm.page_table_lock);
>  	head = pmd_leaf(*pmd) ? pmd_page(*pmd) : NULL;

I was going to ask why you dropped the:
	if (IS_ENABLED(CONFIG_MEMORY_HOTPLUG))
However, without the extra page table reads it really is not necessary.

Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
-- 
Mike Kravetz